[HBASE-13373] Squash HFileReaderV3 together with HFileReaderV2 and AbstractHFileReader; ditto for Scanners and BlockReader, etc.

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Hadoop Flags: Incompatible change, Reviewed
• Release Note: Marking as incompatible change. Requires hfiles be major version >= 2 and >= minor version 3. Version 3 files are enabled by default in 1.0. 0.98 writes version 2 minor version 3. You cannot go to 1.0 from anything before 0.98.
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 01/Apr/15 01:32
• Updated: 24/Jun/22 18:02
• Resolved: 06/Apr/15 17:49

Description

Profiling I actually ran into case where complaint that could not inline because:

MaxInlineLevel maximum number of nested calls that are inlined 9 intx

i.e. method was more than 9 levels deep.

The HFileReaderV? with Abstracts is not needed anymore now we are into the clear with V3 enabled since hbase 1.0.0; we can have just an Interface and an implementation. If we need to support a new hfile type, can hopefully do it in a backward compatible way now we have Cell Interface, etc.

Squashing all this stuff together actually makes it easier figuring what is going on when reading code. I can also get rid of a bunch of duplication too.

Attached is a WIP. Doesn't fully compile yet but you get the idea.

I'll keep on unless objection. Will try it against data written with old classes as soon as I have something working. I don't believe we write classnames into our data.

Issue Links

• incorporates: HBASE-13428 [DOC] Migration to hbase-2.0.0
• links to: reviewboard

Sub-Tasks

• Optimize memstore flushing to avoid writing tag information to hfiles when no tags are present.: Closed