[HBASE-13353] [Shell] get_counter is asking for too many parameters

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.0.0
• Component/s: shell
• Labels: beginner
• Assignee: Unassigned
• Reporter: Lars George
• Created: 27/Mar/15 20:18
• Updated: 24/Jun/22 17:44
• Resolved: 28/Mar/15 08:43

Description

Trying:

hbase(main):036:0> get_counter 'counters', '20150101', 'daily:hits'

and getting

ERROR: wrong number of arguments (3 for 4)
...
  hbase> get_counter 'ns1:t1', 'r1', 'c1'
  hbase> get_counter 't1', 'r1', 'c1'

It is asking for another, undocumented parameter. The issue is that there is a "can be nil" markup missing in get_counter.rb:

39 def command(table, row, column, value)
40    get_counter(table(table), row, column, value)
41 end

The first line should be:

39 def command(table, row, column, value = nil)

Easy fix, but makes me wonder why this is not caught anywhere or reported.

Issue Links

• duplicates: HBASE-10728 get_counter value is never used.