Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13346

Clean up Filter package for post 1.0 s/KeyValue/Cell/g

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0-alpha-4, 2.0.0
    • API, Filters
    • None
    • Reviewed

    Description

      Since we have a bit of a messy Filter API with KeyValue vs Cell reference mixed up all over the place, I recommend cleaning this up once and for all. There should be no KeyValue (or kv, kvs etc.) in any method or parameter name.

      This includes deprecating and renaming filters too, for example FirstKeyOnlyFilter, which really should be named FirstKeyValueFilter as it does not just return the key, but the entire cell. It should be deprecated and renamed to FirstCellFilter (or FirstColumnFilter if you prefer).

      In general we should clarify and settle on KeyValue vs Cell vs Column in our naming. The latter two are the only ones going forward with the public API, and are used synonymous. We should carefully check which is better suited (is it really a specific cell, or the newest cell, aka the newest column value) and settle on a naming schema.

      Attachments

        1. HBASE-13346.master.001.patch
          96 kB
          Tamas Penzes
        2. HBASE-13346.master.002.patch
          97 kB
          Tamas Penzes
        3. HBASE-13346.master.003.patch
          67 kB
          Tamas Penzes
        4. HBASE-13346.master.003.patch
          67 kB
          Michael Stack
        5. HBASE-13346.master.004.patch
          102 kB
          Tamas Penzes
        6. HBASE-13346.master.005.patch
          102 kB
          Tamas Penzes
        7. HBASE-13346.master.006.patch
          97 kB
          Tamas Penzes
        8. HBASE-13346.master.007.patch
          98 kB
          Tamas Penzes
        9. HBASE-13346.master.008.patch
          87 kB
          Tamas Penzes
        10. HBASE-13346.master.009.patch
          87 kB
          Tamas Penzes
        11. HBASE-13346.master.010.patch
          124 kB
          Tamas Penzes
        12. HBASE-13346.master.011.patch
          123 kB
          Tamas Penzes
        13. HBASE-13346.master.011.patch
          123 kB
          Michael Stack
        14. HBASE-13346.master.011.patch
          123 kB
          Michael Stack
        15. HBASE-13346.master.011.patch
          123 kB
          Michael Stack

        Issue Links

          Activity

            People

              tamaas Tamas Penzes
              larsgeorge Lars George
              Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: