[HBASE-13301] Possible memory leak in BucketCache

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.1, 1.1.0, 0.98.13, 2.0.0
• Component/s: BlockCache
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 20/Mar/15 14:11
• Updated: 27/Jun/18 09:22
• Resolved: 14/Apr/15 09:47

Description

BucketCache.java

public boolean evictBlock(BlockCacheKey cacheKey) {
      ...
      if (bucketEntry.equals(backingMap.remove(cacheKey))) {
        bucketAllocator.freeBlock(bucketEntry.offset());
        realCacheSize.addAndGet(-1 * bucketEntry.getLength());
        blocksByHFile.remove(cacheKey.getHfileName(), cacheKey);
        if (removedBlock == null) {
          this.blockNumber.decrementAndGet();
        }
      } else {
        return false;
      }
      ...

I think the problem is here. We remove a BucketEntry that should not be removed by us, but we do not put it back and also do not do any clean up.

Issue Links

• relates to: HBASE-20789 TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky
• links to: reviewboard