[HBASE-13294] Fix the critical ancient loopholes in security testing infrastructure.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.1, 1.1.0, 0.98.12, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Srikanth Srungarapu
• Reporter: Srikanth Srungarapu
• Created: 20/Mar/15 00:53
• Updated: 28/Apr/15 19:18
• Resolved: 25/Mar/15 18:23

Description

Unfortunately, the "verifyDenied" method doesn't fail when action parameter returns null. The relevant code snippet

try {
        Object obj = user.runAs(action);
        if (requireException) {
          fail("Expected exception was not thrown for user '" + user.getShortName() + "'");
        }
        if (obj != null && obj instanceof List<?>) {
          List<?> results = (List<?>) obj;
          if (results != null && !results.isEmpty()) {
            fail("Unexpected results for user '" + user.getShortName() + "'");
          }
        }
      }

As you can see, when obj is null, it returns silently.

Fixing this issue has uncovered another major bug. While constructing actions, we're using TEST_UTIL.getConnection(), which replaces the "doAs" user with the user who initiated the connection. I really am grateful to mbertozzi without whom debugging this would have been a nightmare.

Now, fixing these two issues have uncovered more issues in our tests . The main one is we're allowing the table owner to truncate table in code. But, in test, we're not allowing him. We should either remove the code that allows owner or document that the table owner can truncate table.

The other minor issues include granting permissions to namespace, but checking whether user was able to access tables inside other namespace.

That's it, folks!

Issue Links

• relates to: HBASE-13359 Update ACL matrix to include table owner.
• links to: reviewboard

Sub-Tasks

• Fix the usage of doAs/runAs in Visibility Controller tests.: Closed