[HBASE-13056] Refactor table.jsp code to remove repeated code and make it easier to add new checks

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 1.0.1, 1.1.0, 0.98.11, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Vikas Vishwakarma
• Reporter: Vikas Vishwakarma
• Created: 17/Feb/15 06:53
• Updated: 28/Apr/15 19:18
• Resolved: 21/Feb/15 01:42

Description

While trying to fix HBASE-13001, I realized that there is lot of html code repetition in table.jsp which is making addition of new checks slightly difficult in the sense I will have to:
1. Add the check at multiple places in the code
Or
2. Repeat the html code again for the new check

So I am proposing to re-factor table.jsp code such that the common html header/body is loaded without any condition check and then we generate the condition specific html code

snapshot.jsp follows the same format as explained below:

Current implementation:
====================

if( x ) {

  title_x
  common_html_header
  common_html_body
  x_specific_html_body

} else {

  title_y
  common_html_header
  common_html_body
  y_specific_html_body

}

New Implementation:
==================
if( x ) {

  title_x

} else {

  title_y

}
common_html_header
common_html_body

if( x ) {

  x_specific_html_body

} else {

  y_specific_html_body

}