[HBASE-12802] Remove unnecessary Table.flushCommits()

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0, 2.0.0
• Fix Version/s: 1.0.0, 1.1.0
• Hadoop Flags: Reviewed
• Assignee: Solomon Duskis
• Reporter: Solomon Duskis
• Created: 04/Jan/15 18:42
• Updated: 06/Apr/18 17:54
• Resolved: 05/Jan/15 23:56

Description

It looks like there are a lot of places where flushCommits() are called on tables that do not have autoFlush turned on. That might be a legacy concern from pre-autoFlush days. HBASE-12728 will likely result in removing the flushCommits() method from Table. The patch for this issue should remove all unnecessary calls to flushCommit() to prepare for the full fix.

flushCommits() are only necessary after a setAutoFlushTo(false) is called. Here's the relevant code from HTable.java:

HTable.java

  @Override
  public void put(final Put put)
      throws InterruptedIOException, RetriesExhaustedWithDetailsException {
    doPut(put);
    if (autoFlush) {
      flushCommits();
    }
  }

  /**
   * {@inheritDoc}
   */
  @Override
  public void put(final List<Put> puts)
      throws InterruptedIOException, RetriesExhaustedWithDetailsException {
    for (Put put : puts) {
      doPut(put);
    }
    if (autoFlush) {
      flushCommits();
    }
  }

Puts have implicit flushCommits() calls when autoFlush is true. Deletes are not affected by autoFlush() and are not directly impacted by flushCommits() since deletes are not added to the writeAysncBuffer.

Issue Links

• Is contained by: HBASE-12728 buffered writes substantially less useful after removal of HTablePool