[HBASE-12682] compaction thread throttle value is not correct in hbase-default.xml

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: Jerry He
• Reporter: Jerry He
• Created: 14/Dec/14 06:06
• Updated: 17/Jun/22 18:35
• Resolved: 17/Dec/14 00:15

Description

While doing some compaction tuning and looking up some of the parameters, I noticed that hbase.regionserver.thread.compaction.throttle default value in the documentation and in hbase-site.xml seems to be off the mark.

  <property>
    <name>hbase.regionserver.thread.compaction.throttle</name>
    <value>2560</value>
    <description>There are two different thread pools for compactions, one for large compactions and
      the other for small compactions. This helps to keep compaction of lean tables (such as
        <systemitem>hbase:meta</systemitem>) fast. If a compaction is larger than this threshold, it
      goes into the large compaction pool. In most cases, the default value is appropriate. Default:
      2 x hbase.hstore.compaction.max x hbase.hregion.memstore.flush.size (which defaults to 128).
      The value field assumes that the value of hbase.hregion.memstore.flush.size is unchanged from
      the default.</description>
  </property>

It should be in bytes. Or am I missing anything?
It is not a problem in 0.98 since the property is not in hbase-site.xml over there. It is obtained dynamically:

throttlePoint =  conf.getLong("hbase.regionserver.thread.compaction.throttle",
          2 * maxFilesToCompact * storeConfigInfo.getMemstoreFlushSize());