Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-12640

Add Thrift-over-HTTPS and doAs support for Thrift Server

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.0, 2.0.0
    • Component/s: Thrift
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In HBASE-11349, impersonation support has been added to Thrift Server. But the limitation is thrift client must use same set of credentials throughout the session. These changes will help us in circumventing this problem, by allowing user to populate doAs parameter as per his needs.

      1. HBASE-12640_v1.patch
        27 kB
        Srikanth Srungarapu
      2. HBASE-12640_v2.patch
        28 kB
        Srikanth Srungarapu
      3. HBASE-12640_v3.patch
        28 kB
        Srikanth Srungarapu
      4. HBASE-12640_addendum.patch
        2 kB
        Srikanth Srungarapu
      5. HBASE-12640_test_fix.patch
        0.9 kB
        Srikanth Srungarapu

        Issue Links

        There are no Sub-Tasks for this issue.

          Activity

          Hide
          enis Enis Soztutar added a comment -

          Closing this issue after 1.0.0 release.

          Show
          enis Enis Soztutar added a comment - Closing this issue after 1.0.0 release.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.0 #597 (See https://builds.apache.org/job/HBase-1.0/597/)
          HBASE-12640 Addendum fixes TestThriftHttpServer (Srikanth Srungarapu) (tedyu: rev ebf9c9bce70ad3b604d910931dd73b520bcb9579)

          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #597 (See https://builds.apache.org/job/HBase-1.0/597/ ) HBASE-12640 Addendum fixes TestThriftHttpServer (Srikanth Srungarapu) (tedyu: rev ebf9c9bce70ad3b604d910931dd73b520bcb9579) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #5941 (See https://builds.apache.org/job/HBase-TRUNK/5941/)
          HBASE-12640 Addendum fixes TestThriftHttpServer (Srikanth Srungarapu) (tedyu: rev 58cd2cf6e28af816d55688cd58ed3262a2d3b1f3)

          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5941 (See https://builds.apache.org/job/HBase-TRUNK/5941/ ) HBASE-12640 Addendum fixes TestThriftHttpServer (Srikanth Srungarapu) (tedyu: rev 58cd2cf6e28af816d55688cd58ed3262a2d3b1f3) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Addendum integrated to branch-1 and master.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Addendum integrated to branch-1 and master.
          Hide
          srikanth235 Srikanth Srungarapu added a comment -

          Ted Yu Attaching the patch for fixing the error. Strange that Hadoop QA bot didn't complain though.

          Show
          srikanth235 Srikanth Srungarapu added a comment - Ted Yu Attaching the patch for fixing the error. Strange that Hadoop QA bot didn't complain though.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          TestThriftHttpServer#testRunThriftServer fails in trunk build and branch-1 build.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - TestThriftHttpServer#testRunThriftServer fails in trunk build and branch-1 build.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #596 (See https://builds.apache.org/job/HBase-1.0/596/)
          HBASE-12640 Add Thrift-over-HTTPS and doAs support for Thrift Server – ADDENDUM (jxiang: rev 2b665a780a7e105b124449e69fee01cd5920ca69)

          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #596 (See https://builds.apache.org/job/HBase-1.0/596/ ) HBASE-12640 Add Thrift-over-HTTPS and doAs support for Thrift Server – ADDENDUM (jxiang: rev 2b665a780a7e105b124449e69fee01cd5920ca69) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5940 (See https://builds.apache.org/job/HBase-TRUNK/5940/)
          HBASE-12640 Add Thrift-over-HTTPS and doAs support for Thrift Server (jxiang: rev 072b2d659c9513ab95b58c64a91732f1e225edb9)

          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HttpAuthenticationException.java
          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java
          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/SecurityUtil.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
            HBASE-12640 Add Thrift-over-HTTPS and doAs support for Thrift Server – ADDENDUM (jxiang: rev 47738ff927385157b312ef4dfe61dbcaca05ea68)
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5940 (See https://builds.apache.org/job/HBase-TRUNK/5940/ ) HBASE-12640 Add Thrift-over-HTTPS and doAs support for Thrift Server (jxiang: rev 072b2d659c9513ab95b58c64a91732f1e225edb9) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HttpAuthenticationException.java hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/SecurityUtil.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java HBASE-12640 Add Thrift-over-HTTPS and doAs support for Thrift Server – ADDENDUM (jxiang: rev 47738ff927385157b312ef4dfe61dbcaca05ea68) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #595 (See https://builds.apache.org/job/HBase-1.0/595/)
          HBASE-12640 Add Thrift-over-HTTPS and doAs support for Thrift Server (jxiang: rev 85188d5d9dbeac51f87ec57de49f1552338a89e9)

          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/SecurityUtil.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HttpAuthenticationException.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #595 (See https://builds.apache.org/job/HBase-1.0/595/ ) HBASE-12640 Add Thrift-over-HTTPS and doAs support for Thrift Server (jxiang: rev 85188d5d9dbeac51f87ec57de49f1552338a89e9) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/SecurityUtil.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HttpAuthenticationException.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Hide
          jxiang Jimmy Xiang added a comment -

          Done. Thanks.

          Show
          jxiang Jimmy Xiang added a comment - Done. Thanks.
          Hide
          srikanth235 Srikanth Srungarapu added a comment -

          Jimmy Xiang Thanks for pushing it upstream. Attaching addendum to address concerns raised by Haddop QA bot. Can you please commit this too?

          Show
          srikanth235 Srikanth Srungarapu added a comment - Jimmy Xiang Thanks for pushing it upstream. Attaching addendum to address concerns raised by Haddop QA bot. Can you please commit this too?
          Hide
          jxiang Jimmy Xiang added a comment -

          Thanks Srikanth for the patch. Integrated into branch 1 and master.

          Show
          jxiang Jimmy Xiang added a comment - Thanks Srikanth for the patch. Integrated into branch 1 and master.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12687838/HBASE-12640_v3.patch
          against master branch at commit 6aa8b3727c75bf8578599ec35afcaad245f13e30.
          ATTACHMENT ID: 12687838

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2085 checkstyle errors (more than the master's current 2084 errors).

          -1 findbugs. The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/patchReleaseAuditWarnings.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687838/HBASE-12640_v3.patch against master branch at commit 6aa8b3727c75bf8578599ec35afcaad245f13e30. ATTACHMENT ID: 12687838 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2085 checkstyle errors (more than the master's current 2084 errors). -1 findbugs . The patch appears to introduce 5 new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/patchReleaseAuditWarnings.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12121//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12687818/HBASE-12640_v2.patch
          against master branch at commit 6aa8b3727c75bf8578599ec35afcaad245f13e30.
          ATTACHMENT ID: 12687818

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2085 checkstyle errors (more than the master's current 2084 errors).

          -1 findbugs. The patch appears to introduce 6 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/patchReleaseAuditWarnings.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687818/HBASE-12640_v2.patch against master branch at commit 6aa8b3727c75bf8578599ec35afcaad245f13e30. ATTACHMENT ID: 12687818 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2085 checkstyle errors (more than the master's current 2084 errors). -1 findbugs . The patch appears to introduce 6 new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/patchReleaseAuditWarnings.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12117//console This message is automatically generated.
          Hide
          srikanth235 Srikanth Srungarapu added a comment -

          Addressed the nits.

          Show
          srikanth235 Srikanth Srungarapu added a comment - Addressed the nits.
          Hide
          jxiang Jimmy Xiang added a comment -

          +1. Looks good to me. Just some nits: authFilter is not used/needed.

          Show
          jxiang Jimmy Xiang added a comment - +1. Looks good to me. Just some nits: authFilter is not used/needed.
          Hide
          srikanth235 Srikanth Srungarapu added a comment -

          Addressed small nits.

          Show
          srikanth235 Srikanth Srungarapu added a comment - Addressed small nits.
          Hide
          apurtell Andrew Purtell added a comment -

          I updated the title to be more descriptive of the scope of change.

          Show
          apurtell Andrew Purtell added a comment - I updated the title to be more descriptive of the scope of change.
          Hide
          apurtell Andrew Purtell added a comment -

          I have no objection if we have users asking for it.

          Show
          apurtell Andrew Purtell added a comment - I have no objection if we have users asking for it.
          Hide
          srikanth235 Srikanth Srungarapu added a comment -

          Why Thrift over HTTP with SSL authentication? Doesn't Thrift support SASL? (I think it does.) Does that make more sense?

          Yeah, Thrift does support SASL. But the problem with this apart from validating client to Thrift, there is no way(at least I couldn't find any) to specify "doAs" for each request made through the client.

          All of our client access methods use Kerberos authentication except for hbase-rest, which already provides support for data access over HTTP/HTTPS.

          This feature is a customer ask and they seem to be contended with using Thrift interface and not interested in migrating to REST interface. They just requested us to add provision for "doAs" support.

          We need a HBase access via HTTP option in Thrift too?

          I did have an offline chat with Jimmy Xiang about how to go about solving this problem. He suggested me to adapt the existing hive mechanism (HIVE-6738). But, if you think there is a better way, please do suggest...

          Show
          srikanth235 Srikanth Srungarapu added a comment - Why Thrift over HTTP with SSL authentication? Doesn't Thrift support SASL? (I think it does.) Does that make more sense? Yeah, Thrift does support SASL. But the problem with this apart from validating client to Thrift, there is no way(at least I couldn't find any) to specify "doAs" for each request made through the client. All of our client access methods use Kerberos authentication except for hbase-rest, which already provides support for data access over HTTP/HTTPS. This feature is a customer ask and they seem to be contended with using Thrift interface and not interested in migrating to REST interface. They just requested us to add provision for "doAs" support. We need a HBase access via HTTP option in Thrift too? I did have an offline chat with Jimmy Xiang about how to go about solving this problem. He suggested me to adapt the existing hive mechanism ( HIVE-6738 ). But, if you think there is a better way, please do suggest...
          Hide
          apurtell Andrew Purtell added a comment -

          Thrift over HTTP/HTTPS? There's a lot more here than just doAs support in the Thrift server.

          Why Thrift over HTTP with SSL authentication? Doesn't Thrift support SASL? (I think it does.) Does that make more sense? All of our client access methods use Kerberos authentication except for hbase-rest, which already provides support for data access over HTTP/HTTPS. We need a HBase access via HTTP option in Thrift too?

          Show
          apurtell Andrew Purtell added a comment - Thrift over HTTP/HTTPS? There's a lot more here than just doAs support in the Thrift server. Why Thrift over HTTP with SSL authentication? Doesn't Thrift support SASL? (I think it does.) Does that make more sense? All of our client access methods use Kerberos authentication except for hbase-rest, which already provides support for data access over HTTP/HTTPS. We need a HBase access via HTTP option in Thrift too?

            People

            • Assignee:
              srikanth235 Srikanth Srungarapu
              Reporter:
              srikanth235 Srikanth Srungarapu
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development