Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-12566

HRegion should have an InterfaceAudience of LimitedPrivate(PHOENIX)

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Not A Problem
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      I've discovered after HBASE-12550 that Phoenix has a class that was broken by a change to a package scoped method in HRegion:

      diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/reg
      index 39a9fdc..3377e6b 100644
      --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
      +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
      @@ -4628,11 +4628,12 @@ public class HRegion implements HeapSize { // , Writable{
         /**
          * Create a daughter region from given a temp directory with the region data.
          * @param hri Spec. for daughter region to open.
      +   * @param expectedReferenceFileCount
          * @throws IOException
          */
      -  HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException {
      +  HRegion createDaughterRegionFromSplits(final HRegionInfo hri, int expectedReferenceFileCount) throws IOException {
           // Move the files from the temporary .splits to the final /table/region directory
      -    fs.commitDaughterRegion(hri);
      +    fs.commitDaughterRegion(hri, expectedReferenceFileCount);
      

      We should change the HRegion InterfaceAudience to LimitedPrivate(COPROC, PHOENIX).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                apurtell Andrew Purtell
              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: