[HBASE-12566] HRegion should have an InterfaceAudience of LimitedPrivate(PHOENIX)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Labels: Phoenix
• Assignee: Unassigned
• Reporter: Andrew Kyle Purtell
• Created: 24/Nov/14 22:42
• Updated: 17/Jun/22 18:21
• Resolved: 01/Dec/14 21:48

Description

I've discovered after HBASE-12550 that Phoenix has a class that was broken by a change to a package scoped method in HRegion:

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/reg
index 39a9fdc..3377e6b 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
@@ -4628,11 +4628,12 @@ public class HRegion implements HeapSize { // , Writable{
   /**
    * Create a daughter region from given a temp directory with the region data.
    * @param hri Spec. for daughter region to open.
+   * @param expectedReferenceFileCount
    * @throws IOException
    */
-  HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException {
+  HRegion createDaughterRegionFromSplits(final HRegionInfo hri, int expectedReferenceFileCount) throws IOException {
     // Move the files from the temporary .splits to the final /table/region directory
-    fs.commitDaughterRegion(hri);
+    fs.commitDaughterRegion(hri, expectedReferenceFileCount);

We should change the HRegion InterfaceAudience to LimitedPrivate(COPROC, PHOENIX).

Issue Links

• is related to: PHOENIX-1479 IndexSplitTransaction won't compile after HBASE-12550
• is related to: HBASE-12550 Check all storefiles are referenced before splitting
• is related to: HBASE-12724 Upgrade the interface audience of RegionScanner from Private to LimitedPrivate
• relates to: PHOENIX-1638 Avoid batched mutations via direct use of HRegion
• relates to: PHOENIX-1636 Substitute HRegionInfo for HRegion where possible
• relates to: PHOENIX-1637 Use supported region locking protocols when available
• relates to: HBASE-12972 Region, a supportable public/evolving subset of HRegion
• relates to: PHOENIX-1501 Remove or replace all uses of InterfaceAudience.Private HBase APIs and classes