[HBASE-12356] Rpc with region replica does not propagate tracing spans

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.99.2
• Component/s: Client
• Hadoop Flags: Reviewed
• Assignee: Nick Dimiduk
• Reporter: Nick Dimiduk
• Created: 27/Oct/14 23:45
• Updated: 06/Apr/18 17:54
• Resolved: 28/Oct/14 17:30

Description

We don't have e2e tests involving htrace; we found this while running the phoenix IT suite on a build of 0.98 + region replicas.

Running org.apache.phoenix.end2end.index.ViewIndexIT
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 111.41 sec <<< FAILURE! - in org.apache.phoenix.trace.PhoenixTracingEndToEndIT
testScanTracingOnServer(org.apache.phoenix.trace.PhoenixTracingEndToEndIT)  Time elapsed: 41.157 sec  <<< FAILURE!
java.lang.AssertionError: Didn't find the parallel scanner in the tracing
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.apache.phoenix.trace.PhoenixTracingEndToEndIT.testScanTracingOnServer(PhoenixTracingEndToEndIT.java:357)

Digging in, it appears is not trace-wrapping its Callables before passing them to the executor.

Issue Links

• is related to: HBASE-13078 IntegrationTestSendTraceRequests is a noop