Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 0.99.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Forward port of HBASE-8805 and HBASE-8544 implemented by Gaurav Menghani in 89-fb. This improves operational efficiency in managing clusters that are serving production traffic. The idea is to have a central configuration which can manage notifying the configuration observers. The observers in turn should update their local state from the latest config. Minor caveats where configuration variables are corelated should be taken care of with additional care.

      This patch is the server-part only. TODO is the activation, coming in a later issue.
      Show
      Forward port of HBASE-8805 and HBASE-8544 implemented by Gaurav Menghani in 89-fb. This improves operational efficiency in managing clusters that are serving production traffic. The idea is to have a central configuration which can manage notifying the configuration observers. The observers in turn should update their local state from the latest config. Minor caveats where configuration variables are corelated should be taken care of with additional care. This patch is the server-part only. TODO is the activation, coming in a later issue.

      Description

      This jira is to track the forward port of HBASE-8805 and HBASE-8544 implemented by Gaurav Menghani in 89-fb. This improves operational efficiency in managing clusters that are serving production traffic.

      1. 0001-Online-config-change.patch
        55 kB
        Manukranth Kolloju
      2. 0001-Online-config-change.patch
        47 kB
        Manukranth Kolloju
      3. 0001-Online-config-change.patch
        53 kB
        Manukranth Kolloju
      4. 0001-Online-config-change.patch
        52 kB
        Manukranth Kolloju
      5. 0001-Online-config-change.patch
        53 kB
        Manukranth Kolloju
      6. 0001-Online-config-change.patch
        53 kB
        Manukranth Kolloju
      7. 0001-Online-config-change-Branch1.patch
        52 kB
        Manukranth Kolloju
      8. 0001-Online-config-change-Branch1.patch
        52 kB
        Manukranth Kolloju
      9. 0001-Online-config-change-Branch1.patch
        52 kB
        Manukranth Kolloju

        Issue Links

          Activity

          Hide
          enis Enis Soztutar added a comment -

          Closing this issue after 0.99.2 release.

          Show
          enis Enis Soztutar added a comment - Closing this issue after 0.99.2 release.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.0 #313 (See https://builds.apache.org/job/HBase-1.0/313/)
          HBASE-12147 Porting Online Config Change from 89-fb – REAPPLY (stack: rev dbd0ba36f53ce1adeaffc706090c390452f09f46)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerOnlineConfigChange.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationObserver.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/conf/PropagatingConfigurationObserver.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestOffPeakHours.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakHours.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/conf/TestConfigurationManager.java
            HBASE-12147 Porting Online Config Change from 89-fb – JAVADOC FIX ADDENDUM (stack: rev ca26d22b50773db4562752d12ba5eb4fdde59b20)
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #313 (See https://builds.apache.org/job/HBase-1.0/313/ ) HBASE-12147 Porting Online Config Change from 89-fb – REAPPLY (stack: rev dbd0ba36f53ce1adeaffc706090c390452f09f46) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerOnlineConfigChange.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationObserver.java hbase-server/src/main/java/org/apache/hadoop/hbase/conf/PropagatingConfigurationObserver.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestOffPeakHours.java hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakHours.java hbase-server/src/test/java/org/apache/hadoop/hbase/conf/TestConfigurationManager.java HBASE-12147 Porting Online Config Change from 89-fb – JAVADOC FIX ADDENDUM (stack: rev ca26d22b50773db4562752d12ba5eb4fdde59b20) hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
          Hide
          stack stack added a comment -

          Pushed the branch-1 patch and the little javadoc fix again. Thanks Manukranth Kolloju for fixup.

          Lets revisit using Writables for this stuff even in branch-1 in another issue.

          commit ca26d22b50773db4562752d12ba5eb4fdde59b20
          Author: stack <stack@apache.org>
          Date:   Mon Oct 13 21:25:51 2014 -0700
          
              HBASE-12147 Porting Online Config Change from 89-fb -- JAVADOC FIX ADDENDUM
          
          commit dbd0ba36f53ce1adeaffc706090c390452f09f46
          Author: stack <stack@apache.org>
          Date:   Tue Oct 14 12:51:49 2014 -0700
          
              HBASE-12147 Porting Online Config Change from 89-fb -- REAPPLY
          
          Show
          stack stack added a comment - Pushed the branch-1 patch and the little javadoc fix again. Thanks Manukranth Kolloju for fixup. Lets revisit using Writables for this stuff even in branch-1 in another issue. commit ca26d22b50773db4562752d12ba5eb4fdde59b20 Author: stack <stack@apache.org> Date: Mon Oct 13 21:25:51 2014 -0700 HBASE-12147 Porting Online Config Change from 89-fb -- JAVADOC FIX ADDENDUM commit dbd0ba36f53ce1adeaffc706090c390452f09f46 Author: stack <stack@apache.org> Date: Tue Oct 14 12:51:49 2014 -0700 HBASE-12147 Porting Online Config Change from 89-fb -- REAPPLY
          Hide
          manukranthk Manukranth Kolloju added a comment -

          stack, I attached the patch that you've asked. Let me know if that works.
          I have checked : mvn clean -DskipTests package

          Show
          manukranthk Manukranth Kolloju added a comment - stack , I attached the patch that you've asked. Let me know if that works. I have checked : mvn clean -DskipTests package
          Hide
          manukranthk Manukranth Kolloju added a comment -

          Patch for branch-1
          I also had to fix the test classification for this one.

          Show
          manukranthk Manukranth Kolloju added a comment - Patch for branch-1 I also had to fix the test classification for this one.
          Hide
          manukranthk Manukranth Kolloju added a comment -

          There was a change in the Bytes class to remove Writables and replace them with bytes. And as part of that some function names were changed as well. Hence this merge conflict. This is the change needed to fix the patch : https://reviews.facebook.net/F223347. I will attach the patch for branch-1

          Show
          manukranthk Manukranth Kolloju added a comment - There was a change in the Bytes class to remove Writables and replace them with bytes. And as part of that some function names were changed as well. Hence this merge conflict. This is the change needed to fix the patch : https://reviews.facebook.net/F223347 . I will attach the patch for branch-1
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.0 #311 (See https://builds.apache.org/job/HBase-1.0/311/)
          HBASE-12147 Porting Online Config Change from 89-fb – JAVADOC FIX ADDENDUM – REVERT (stack: rev 0ebb98d7b38337d226d1d210204c965acddf93be)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
            HBASE-12147 Porting Online Config Change from 89-fb – REVERT (stack: rev 2822a289f9bd59156fb5ea8305da26944fe5152e)
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/conf/TestConfigurationManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/conf/PropagatingConfigurationObserver.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerOnlineConfigChange.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationObserver.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakHours.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestOffPeakHours.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #311 (See https://builds.apache.org/job/HBase-1.0/311/ ) HBASE-12147 Porting Online Config Change from 89-fb – JAVADOC FIX ADDENDUM – REVERT (stack: rev 0ebb98d7b38337d226d1d210204c965acddf93be) hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java HBASE-12147 Porting Online Config Change from 89-fb – REVERT (stack: rev 2822a289f9bd59156fb5ea8305da26944fe5152e) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-server/src/test/java/org/apache/hadoop/hbase/conf/TestConfigurationManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java hbase-server/src/main/java/org/apache/hadoop/hbase/conf/PropagatingConfigurationObserver.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerOnlineConfigChange.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationObserver.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakHours.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestOffPeakHours.java
          Hide
          manukranthk Manukranth Kolloju added a comment -

          Let me take a look in a half hour.

          Show
          manukranthk Manukranth Kolloju added a comment - Let me take a look in a half hour.
          Hide
          stack stack added a comment -

          Yeah, I had to revert. CompoundConfguration is missing addBytesMap When I try to fix it up, it has dependency on Bytes class – there is stuff in Bytes that does not seem to have been backported. Any chance of looking at this Manukranth Kolloju else I'll dig in later t his morning.... Thanks.

          Show
          stack stack added a comment - Yeah, I had to revert. CompoundConfguration is missing addBytesMap When I try to fix it up, it has dependency on Bytes class – there is stuff in Bytes that does not seem to have been backported. Any chance of looking at this Manukranth Kolloju else I'll dig in later t his morning.... Thanks.
          Hide
          stack stack added a comment -

          Reverted from branch-1. I applied it wrong and broke branch-1 build. Let me try and figure what I did amiss.

          Show
          stack stack added a comment - Reverted from branch-1. I applied it wrong and broke branch-1 build. Let me try and figure what I did amiss.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #5661 (See https://builds.apache.org/job/HBase-TRUNK/5661/)
          HBASE-12147 Porting Online Config Change from 89-fb – JAVADOC FIX ADDENDUM (stack: rev 904654aa87d18cab4061a1b70553d691f5ba7f64)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5661 (See https://builds.apache.org/job/HBase-TRUNK/5661/ ) HBASE-12147 Porting Online Config Change from 89-fb – JAVADOC FIX ADDENDUM (stack: rev 904654aa87d18cab4061a1b70553d691f5ba7f64) hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #310 (See https://builds.apache.org/job/HBase-1.0/310/)
          HBASE-12147 Porting Online Config Change from 89-fb – JAVADOC FIX ADDENDUM (stack: rev 785d2fad2e83fe6f3304ea6be83823ba0552661e)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #310 (See https://builds.apache.org/job/HBase-1.0/310/ ) HBASE-12147 Porting Online Config Change from 89-fb – JAVADOC FIX ADDENDUM (stack: rev 785d2fad2e83fe6f3304ea6be83823ba0552661e) hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
          Hide
          stack stack added a comment -

          Oh, fixed the javadoc warning with an addendum post-commit.

          commit 904654aa87d18cab4061a1b70553d691f5ba7f64
          Author: stack <stack@apache.org>
          Date:   Mon Oct 13 21:25:51 2014 -0700
          
              HBASE-12147 Porting Online Config Change from 89-fb -- JAVADOC FIX ADDENDUM
          
          commit 962065de726d7f96cf49a96674032c3d0f189e3d
          Author: manukranthk <manukranthk@fb.com>
          Date:   Wed Oct 1 15:13:58 2014 -0700
          
              Online config change
          
              Summary: This diff is intended to forward port HBASE-8805 and HBASE-8544 implemented by Gaurav Menghani in 89-fb. This improves operational efficiency in managing clusters that are serving production traffic. The idea is to have a central configuration which can manage notifying the configuration observers. The observers in turn should update their local sta
          
              Test Plan: Unit tests
          
              Differential Revision: https://reviews.facebook.net/D24681
          
              Signed-off-by: stack <stack@apache.org>
          
          Show
          stack stack added a comment - Oh, fixed the javadoc warning with an addendum post-commit. commit 904654aa87d18cab4061a1b70553d691f5ba7f64 Author: stack <stack@apache.org> Date: Mon Oct 13 21:25:51 2014 -0700 HBASE-12147 Porting Online Config Change from 89-fb -- JAVADOC FIX ADDENDUM commit 962065de726d7f96cf49a96674032c3d0f189e3d Author: manukranthk <manukranthk@fb.com> Date: Wed Oct 1 15:13:58 2014 -0700 Online config change Summary: This diff is intended to forward port HBASE-8805 and HBASE-8544 implemented by Gaurav Menghani in 89-fb. This improves operational efficiency in managing clusters that are serving production traffic. The idea is to have a central configuration which can manage notifying the configuration observers. The observers in turn should update their local sta Test Plan: Unit tests Differential Revision: https: //reviews.facebook.net/D24681 Signed-off-by: stack <stack@apache.org>
          Hide
          stack stack added a comment -

          Committed to branch-1+. Thanks for the patch Manukranth Kolloju I added a release note. See what you think. Add in the link to the activation issue when it gets filed. Good stuff.

          Show
          stack stack added a comment - Committed to branch-1+. Thanks for the patch Manukranth Kolloju I added a release note. See what you think. Add in the link to the activation issue when it gets filed. Good stuff.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12674622/0001-Online-config-change.patch
          against trunk revision .
          ATTACHMENT ID: 12674622

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestSplitLogManager

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12674622/0001-Online-config-change.patch against trunk revision . ATTACHMENT ID: 12674622 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11331//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12674614/0001-Online-config-change.patch
          against trunk revision .
          ATTACHMENT ID: 12674614

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStoppedServerIsNotAlive(TestHttpServerLifecycle.java:93)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12674614/0001-Online-config-change.patch against trunk revision . ATTACHMENT ID: 12674614 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStoppedServerIsNotAlive(TestHttpServerLifecycle.java:93) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11330//console This message is automatically generated.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          +1 to option #1

          Show
          yuzhihong@gmail.com Ted Yu added a comment - +1 to option #1
          Hide
          manukranthk Manukranth Kolloju added a comment -

          After this, the next patch would be to provide a strategy to trigger this config change. I had 2 options,
          1) Provide an end point to let the regionserver know that it has to reload its config.
          2) Let regionserver periodically check if the configuration has changes and trigger the configuration change when it detects that it happened.

          Option 2 would be simpler to implement, but I feel that option 1 would be more safe and gives the admin more control. Will put up a patch for this idea shortly.

          Show
          manukranthk Manukranth Kolloju added a comment - After this, the next patch would be to provide a strategy to trigger this config change. I had 2 options, 1) Provide an end point to let the regionserver know that it has to reload its config. 2) Let regionserver periodically check if the configuration has changes and trigger the configuration change when it detects that it happened. Option 2 would be simpler to implement, but I feel that option 1 would be more safe and gives the admin more control. Will put up a patch for this idea shortly.
          Hide
          stack stack added a comment -

          +1 on commit (I can fix WARN on commit) Unless objection, I'll commit later today.

          Show
          stack stack added a comment - +1 on commit (I can fix WARN on commit) Unless objection, I'll commit later today.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          I agree it is not related.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - I agree it is not related.
          Hide
          manukranthk Manukranth Kolloju added a comment -

          I noticed that warning, but I don't think my patch had any changes in MetaScanner.java.

          Show
          manukranthk Manukranth Kolloju added a comment - I noticed that warning, but I don't think my patch had any changes in MetaScanner.java.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          This is the javadoc warning:

          [WARNING] Javadoc Warnings
          [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java:299: warning - @param argument "offlined" is not a parameter name.
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - This is the javadoc warning: [WARNING] Javadoc Warnings [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java:299: warning - @param argument "offlined" is not a parameter name.
          Hide
          manukranthk Manukranth Kolloju added a comment -

          Fixing TestHeapSize. I checked the javadoc warnings on the precommit build, but can't seem to find where the 1 warning is coming from.

          Show
          manukranthk Manukranth Kolloju added a comment - Fixing TestHeapSize. I checked the javadoc warnings on the precommit build, but can't seem to find where the 1 warning is coming from.
          Hide
          stack stack added a comment -

          Do you need annotations on public interface PropagatingConfigurationObserver extends ConfigurationObserver {

          Looks like you added Reference to HStore and that is why TestHeapSize is failing.

          Otherwise +1 on patch on skim. Very nice new feature. Needs fancy release note.

          Show
          stack stack added a comment - Do you need annotations on public interface PropagatingConfigurationObserver extends ConfigurationObserver { Looks like you added Reference to HStore and that is why TestHeapSize is failing. Otherwise +1 on patch on skim. Very nice new feature. Needs fancy release note.
          Hide
          stack stack added a comment -

          You know how to fix the heap size test Manukranth Kolloju? You changed 'size' of a base type. Run the test in your IDE to see what you need to fix. If you can't figure, come back and we'll help out....

          Show
          stack stack added a comment - You know how to fix the heap size test Manukranth Kolloju ? You changed 'size' of a base type. Run the test in your IDE to see what you need to fix. If you can't figure, come back and we'll help out....
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12674572/0001-Online-config-change.patch
          against trunk revision .
          ATTACHMENT ID: 12674572

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.io.TestHeapSize

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12674572/0001-Online-config-change.patch against trunk revision . ATTACHMENT ID: 12674572 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.TestHeapSize Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11329//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12674307/0001-Online-config-change.patch
          against trunk revision .
          ATTACHMENT ID: 12674307

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.io.TestHeapSize

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/trunk/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12674307/0001-Online-config-change.patch against trunk revision . ATTACHMENT ID: 12674307 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.TestHeapSize Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//artifact/trunk/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11311//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12673965/0001-Online-config-change.patch
          against trunk revision .
          ATTACHMENT ID: 12673965

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/trunk/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12673965/0001-Online-config-change.patch against trunk revision . ATTACHMENT ID: 12673965 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//artifact/trunk/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11291//console This message is automatically generated.
          Hide
          manukranthk Manukranth Kolloju added a comment -

          Added the diff to ease review : https://reviews.facebook.net/D24681

          Show
          manukranthk Manukranth Kolloju added a comment - Added the diff to ease review : https://reviews.facebook.net/D24681
          Hide
          manukranthk Manukranth Kolloju added a comment -

          Updating some of the javadocs and cleaning up the diff a little bit.

          Show
          manukranthk Manukranth Kolloju added a comment - Updating some of the javadocs and cleaning up the diff a little bit.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12673302/0001-Online-config-change.patch
          against trunk revision .
          ATTACHMENT ID: 12673302

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.util.TestHBaseFsck
          org.apache.hadoop.hbase.TestZooKeeper

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/trunk/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12673302/0001-Online-config-change.patch against trunk revision . ATTACHMENT ID: 12673302 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.util.TestHBaseFsck org.apache.hadoop.hbase.TestZooKeeper Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//artifact/trunk/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11233//console This message is automatically generated.
          Hide
          manukranthk Manukranth Kolloju added a comment -

          This is the initial patch, bringing together the Online Configuration with an application to update configs for compactions.

          Show
          manukranthk Manukranth Kolloju added a comment - This is the initial patch, bringing together the Online Configuration with an application to update configs for compactions.

            People

            • Assignee:
              manukranthk Manukranth Kolloju
              Reporter:
              manukranthk Manukranth Kolloju
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 168h
                168h
                Remaining:
                Remaining Estimate - 168h
                168h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development