Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-12145

Fix javadoc and findbugs so new folks aren't freaked when they see them

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Fix javadoc warnings.

      Fixup findbugs warnings mostly by adding annotations saying 'working as expected'.

      In RpcRetryingCallerWithReadReplicas made following change which findbugs spotted:

       - if (completed == null) tasks.wait();
      + while (completed == null) tasks.wait();

      In RecoverableZooKeeper, made all zk accesses synchronized -- we were doing it half-ways previously.

      In RatioBasedCompactionPolicy we were making an instance of Random on
      each invocation of getNextMajorCompactionTime
      Show
      Fix javadoc warnings. Fixup findbugs warnings mostly by adding annotations saying 'working as expected'. In RpcRetryingCallerWithReadReplicas made following change which findbugs spotted:  - if (completed == null) tasks.wait(); + while (completed == null) tasks.wait(); In RecoverableZooKeeper, made all zk accesses synchronized -- we were doing it half-ways previously. In RatioBasedCompactionPolicy we were making an instance of Random on each invocation of getNextMajorCompactionTime

      Description

      Misc set of fixes to get these attributes green again.

        Attachments

        1. 12145.txt
          28 kB
          Michael Stack
        2. 12145v2.txt
          27 kB
          Michael Stack

          Activity

            People

            • Assignee:
              stack Michael Stack
              Reporter:
              stack Michael Stack
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: