Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11339 HBase MOB
  3. HBASE-12094

Clean the code after adding IS_MOB and MOB_THRESHOLD to column family

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • hbase-11339
    • hbase-11339, 2.0.0
    • regionserver, Scanners
    • None

    Description

      Previously we defined two attribute IS_MOB and MOB_THRESHOLD in the MobConstants, and defined the method getMobThreshold() and isMobColumnFamily() in the MobUtils.
      Now we have these attributes and methods in HColumnDescriptor. They're duplicated, we will remove the ones in MobConstants and MobUtils, and modify the code that reference them.

      Attachments

        1. HBASE-12094.diff
          22 kB
          Jingcheng Du

        Issue Links

          Activity

            jingcheng.du@intel.com Jingcheng Du added a comment -

            Upload the patch to clean the duplicated code and the code that reference them.

            jingcheng.du@intel.com Jingcheng Du added a comment - Upload the patch to clean the duplicated code and the code that reference them.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12671182/HBASE-12094.diff
            against trunk revision .
            ATTACHMENT ID: 12671182

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 33 new or modified tests.

            -1 patch. The patch command could not apply the patch.

            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11074//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671182/HBASE-12094.diff against trunk revision . ATTACHMENT ID: 12671182 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 33 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11074//console This message is automatically generated.
            jingcheng.du@intel.com Jingcheng Du added a comment -

            The code will be cleaned directly in HBASE-12085.

            jingcheng.du@intel.com Jingcheng Du added a comment - The code will be cleaned directly in HBASE-12085 .

            People

              jingcheng.du@intel.com Jingcheng Du
              jingcheng.du@intel.com Jingcheng Du
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: