HBase
  1. HBase
  2. HBASE-11841

[0.98] Option for disabling location prefetch

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.6
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      On HBASE-10018 we removed location prefetch in versions > 0.98. That issue enumerates some of the issues with location prefetch. It is already possible to disable location prefetch on a per table basis via HTable#setRegionCachePrefetch(TableName tableName, boolean enable) but we should have a site configuration option that disables prefetch globally without requiring application code take some special action like setRegionCachePrefetch.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        8h 51m 1 Andrew Purtell 28/Aug/14 05:47
        Patch Available Patch Available Resolved Resolved
        13h 33m 1 Andrew Purtell 28/Aug/14 19:20
        Andrew Purtell made changes -
        Fix Version/s 0.98.6 [ 12327376 ]
        Fix Version/s 0.98.7 [ 12327560 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #454 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/454/)
        HBASE-11841 [0.98] Option for disabling location prefetch (apurtell: rev 4a3ddc7cb744759609809eef85690cd58127c85a)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        • hbase-common/src/main/resources/hbase-default.xml
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #454 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/454/ ) HBASE-11841 [0.98] Option for disabling location prefetch (apurtell: rev 4a3ddc7cb744759609809eef85690cd58127c85a) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java hbase-common/src/main/resources/hbase-default.xml hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #481 (See https://builds.apache.org/job/HBase-0.98/481/)
        HBASE-11841 [0.98] Option for disabling location prefetch (apurtell: rev 4a3ddc7cb744759609809eef85690cd58127c85a)

        • hbase-common/src/main/resources/hbase-default.xml
        • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #481 (See https://builds.apache.org/job/HBase-0.98/481/ ) HBASE-11841 [0.98] Option for disabling location prefetch (apurtell: rev 4a3ddc7cb744759609809eef85690cd58127c85a) hbase-common/src/main/resources/hbase-default.xml hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Andrew Purtell made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        Andrew Purtell added a comment -

        Pushed to 0.98

        Show
        Andrew Purtell added a comment - Pushed to 0.98
        Hide
        Andrew Purtell added a comment -

        Thanks N. Will commit shortly.

        Show
        Andrew Purtell added a comment - Thanks N. Will commit shortly.
        Hide
        Nicolas Liochon added a comment -

        +1

        Show
        Nicolas Liochon added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12664822/HBASE-11841-0.98.patch
        against trunk revision .
        ATTACHMENT ID: 12664822

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10616//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12664822/HBASE-11841-0.98.patch against trunk revision . ATTACHMENT ID: 12664822 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10616//console This message is automatically generated.
        Andrew Purtell made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Andrew Purtell added a comment -

        Setting patch available. Expect Jenkins to barf attempting to apply the patch to trunk

        Show
        Andrew Purtell added a comment - Setting patch available. Expect Jenkins to barf attempting to apply the patch to trunk
        Andrew Purtell made changes -
        Field Original Value New Value
        Attachment HBASE-11841-0.98.patch [ 12664822 ]
        Hide
        Andrew Purtell added a comment - - edited

        Attached patch for 0.98. New unit test passes:

        Running org.apache.hadoop.hbase.client.TestFromClientSide
        Tests run: 77, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 82.013 sec
        
        Results :
        
        Tests run: 77, Failures: 0, Errors: 0, Skipped: 4
        

        Edit: Fix formatting

        Show
        Andrew Purtell added a comment - - edited Attached patch for 0.98. New unit test passes: Running org.apache.hadoop.hbase.client.TestFromClientSide Tests run: 77, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 82.013 sec Results : Tests run: 77, Failures: 0, Errors: 0, Skipped: 4 Edit: Fix formatting
        Andrew Purtell created issue -

          People

          • Assignee:
            Andrew Purtell
            Reporter:
            Andrew Purtell
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development