HBase
  1. HBase
  2. HBASE-11820

ReplicationSource : Set replication codec class as RPC codec class on a clonned Configuration

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.99.0
    • Fix Version/s: 0.99.0, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HBASE-11820.patch
      1 kB
      Anoop Sam John

      Activity

      Hide
      Enis Soztutar added a comment -

      Closing this issue after 0.99.0 release.

      Show
      Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-1.0 #129 (See https://builds.apache.org/job/HBase-1.0/129/)
      HBASE-11820 ReplicationSource : Set replication codec class as RPC codec class on a clonned Configuration. (anoopsamjohn: rev 9bd9b26a0ee19cb49721b10a5121f101c72a7d58)

      • hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #129 (See https://builds.apache.org/job/HBase-1.0/129/ ) HBASE-11820 ReplicationSource : Set replication codec class as RPC codec class on a clonned Configuration. (anoopsamjohn: rev 9bd9b26a0ee19cb49721b10a5121f101c72a7d58) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-TRUNK #5436 (See https://builds.apache.org/job/HBase-TRUNK/5436/)
      HBASE-11820 ReplicationSource : Set replication codec class as RPC codec class on a clonned Configuration. (anoopsamjohn: rev 0cb2ab6a767aa143454d8b60c45f193423e3644c)

      • hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5436 (See https://builds.apache.org/job/HBase-TRUNK/5436/ ) HBASE-11820 ReplicationSource : Set replication codec class as RPC codec class on a clonned Configuration. (anoopsamjohn: rev 0cb2ab6a767aa143454d8b60c45f193423e3644c) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
      Hide
      Anoop Sam John added a comment -

      Pushed to branch-1 and master. Thanks for the reviews Ram and Enis.

      Show
      Anoop Sam John added a comment - Pushed to branch-1 and master. Thanks for the reviews Ram and Enis.
      Hide
      Enis Soztutar added a comment -

      1 for branch-1. Thanks Anoop.

      Show
      Enis Soztutar added a comment - 1 for branch-1 . Thanks Anoop.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12664306/HBASE-11820.patch
      against trunk revision .
      ATTACHMENT ID: 12664306

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 javadoc. The javadoc tool appears to have generated 7 warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 site. The mvn site goal succeeds with this patch.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12664306/HBASE-11820.patch against trunk revision . ATTACHMENT ID: 12664306 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 7 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10576//console This message is automatically generated.
      Hide
      Anoop Sam John added a comment -

      After getting this in, we can run QA on HBASE-11440. Might be helping that failed test I also think. Let us see. Thanks for the review Ram.

      Show
      Anoop Sam John added a comment - After getting this in, we can run QA on HBASE-11440 . Might be helping that failed test I also think. Let us see. Thanks for the review Ram.
      Hide
      ramkrishna.s.vasudevan added a comment -

      May be this helps https://issues.apache.org/jira/browse/HBASE-11440. If so we can commit HBASE-11440 also. I some how forgot that totally.

      Show
      ramkrishna.s.vasudevan added a comment - May be this helps https://issues.apache.org/jira/browse/HBASE-11440 . If so we can commit HBASE-11440 also. I some how forgot that totally.
      Hide
      Anoop Sam John added a comment -
      Show
      Anoop Sam John added a comment - Ping Enis Soztutar

        People

        • Assignee:
          Anoop Sam John
          Reporter:
          Anoop Sam John
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development