Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11716

LoadTestDataGeneratorWithVisibilityLabels should handle Delete mutations

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 0.98.5
        • Fix Version/s: 0.99.0, 2.0.0, 0.98.6
        • Component/s: None
        • Labels:
        • Hadoop Flags:
          Reviewed

          Description

            public Mutation beforeMutate(long rowkeyBase, Mutation m) throws IOException {
    if (!(m instanceof Delete)) {
      m.setCellVisibility(new CellVisibility(this.visibilityExps[(int) rowkeyBase
          % this.visibilityExps.length]));
    }
    return m;
  }

          Now we have delete CellVisibility matching and so we should add CellVisibility for Mutations also. Just removing the if check part will solve the issue.

          1. Text File
            HBASE-11716.patch
            1 kB
            Anoop Sam John

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ram_krish ramkrishna.s.vasudevan added a comment -

            Added this change in one the IT that was created using LTT. I will raise a JIRA to add that IT for visibility labels along with deletes that uses the LTT tool.

            Show
            ram_krish ramkrishna.s.vasudevan added a comment - Added this change in one the IT that was created using LTT. I will raise a JIRA to add that IT for visibility labels along with deletes that uses the LTT tool.
            Hide
            Permalink
            ram_krish ramkrishna.s.vasudevan added a comment -

            +1 on change.

            Show
            ram_krish ramkrishna.s.vasudevan added a comment - +1 on change.
            Hide
            Permalink
            busbey Sean Busbey added a comment -

            +1 LGTM

            Show
            busbey Sean Busbey added a comment - +1 LGTM
            Hide
            Permalink
            apurtell Andrew Purtell added a comment -

            Committed to 0.98+ . Thanks for the patch Anoop!

            Show
            apurtell Andrew Purtell added a comment - Committed to 0.98+ . Thanks for the patch Anoop!
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in HBase-1.0 #94 (See https://builds.apache.org/job/HBase-1.0/94/)
            HBASE-11716 LoadTestDataGeneratorWithVisibilityLabels should handle Delete mutations (Anoop Sam John) (apurtell: rev cc5024e6fce985ea3266f22724942886870b042b)

            • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #94 (See https://builds.apache.org/job/HBase-1.0/94/ ) HBASE-11716 LoadTestDataGeneratorWithVisibilityLabels should handle Delete mutations (Anoop Sam John) (apurtell: rev cc5024e6fce985ea3266f22724942886870b042b) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in HBase-TRUNK #5390 (See https://builds.apache.org/job/HBase-TRUNK/5390/)
            HBASE-11716 LoadTestDataGeneratorWithVisibilityLabels should handle Delete mutations (Anoop Sam John) (apurtell: rev d8a262996b43f9ffa9c641b1a0b0b2cd08677bc3)

            • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5390 (See https://builds.apache.org/job/HBase-TRUNK/5390/ ) HBASE-11716 LoadTestDataGeneratorWithVisibilityLabels should handle Delete mutations (Anoop Sam John) (apurtell: rev d8a262996b43f9ffa9c641b1a0b0b2cd08677bc3) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in HBase-0.98 #444 (See https://builds.apache.org/job/HBase-0.98/444/)
            HBASE-11716 LoadTestDataGeneratorWithVisibilityLabels should handle Delete mutations (Anoop Sam John) (apurtell: rev 93390aca70a2780fd1a017a8db28ad9b01a808fc)

            • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #444 (See https://builds.apache.org/job/HBase-0.98/444/ ) HBASE-11716 LoadTestDataGeneratorWithVisibilityLabels should handle Delete mutations (Anoop Sam John) (apurtell: rev 93390aca70a2780fd1a017a8db28ad9b01a808fc) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #418 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/418/)
            HBASE-11716 LoadTestDataGeneratorWithVisibilityLabels should handle Delete mutations (Anoop Sam John) (apurtell: rev 93390aca70a2780fd1a017a8db28ad9b01a808fc)

            • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #418 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/418/ ) HBASE-11716 LoadTestDataGeneratorWithVisibilityLabels should handle Delete mutations (Anoop Sam John) (apurtell: rev 93390aca70a2780fd1a017a8db28ad9b01a808fc) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/LoadTestDataGeneratorWithVisibilityLabels.java
            Hide
            Permalink
            enis Enis Soztutar added a comment -

            Closing this issue after 0.99.0 release.

            Show
            enis Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

              People

              • Assignee:
                anoop.hbase Anoop Sam John
                Reporter:
                anoop.hbase Anoop Sam John
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development