[HBASE-11707] Using Map instead of list in FailedServers of RpcClient

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: Client
• Hadoop Flags: Reviewed
• Assignee: Shaohui Liu
• Reporter: Shaohui Liu
• Created: 08/Aug/14 12:49
• Updated: 17/Jun/22 16:18
• Resolved: 01/Jul/17 23:12

Description

Currently, FailedServers uses a list to record the black list of servers and iterate the list to check if a server is in list. It's not efficient when the list is very large. And the list is not thread safe for the add and iteration operations.

RpcClient.java#175

      // iterate, looking for the search entry and cleaning expired entries
      Iterator<Pair<Long, String>> it = failedServers.iterator();
      while (it.hasNext()) {
        Pair<Long, String> cur = it.next();
         if (cur.getFirst() < now) {
          it.remove();
        } else {
          if (lookup.equals(cur.getSecond())) {
            return true;
          }
        }

A simple change is to change this list to ConcurrentHashMap.

Issue Links

• links to: Review Board (master)