Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11677

Make Logger instance modifiers consistent

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0, 2.0.0
    • Component/s: util
    • Labels:

      Description

      We have some instances of Logger that are missing one of being private, static, and final.

      ex from HealthChecker.java, missing final

          private static Log LOG = LogFactory.getLog(HealthChecker.class);
      
      • Clean up where possible by making private static final
      • If we can't, add a non-javadoc note about why

      One way to look for problematic instances is to grep for initial assignment for the commonly used LOG member, e.g.

      • missing final: grep -r "LOG =" * | grep -v "final"
      • missing static: grep -r "LOG =" * | grep -v "static"
      • missing private: grep -r "LOG =" * | grep -v "private"

        Attachments

        1. HBASE-11677.patch
          232 kB
          Usha Kuchibhotla
        2. HBASE-11677-v1.patch
          233 kB
          Usha Kuchibhotla
        3. HBASE-11677-v2.patch
          245 kB
          Usha Kuchibhotla
        4. HBASE-11677-v3.patch
          245 kB
          Usha Kuchibhotla
        5. HBASE-11677-v4.patch
          245 kB
          Usha Kuchibhotla
        6. HBase-11677-v5.patch
          253 kB
          Usha Kuchibhotla
        7. HBase-11677-v6.patch
          253 kB
          Usha Kuchibhotla
        8. HBase-11677-v6.patch
          253 kB
          Usha Kuchibhotla
        9. HBase-11677-v7.patch
          253 kB
          Usha Kuchibhotla

          Activity

            People

            • Assignee:
              Usha710 Usha Kuchibhotla
              Reporter:
              busbey Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: