Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11586

HFile's HDFS op latency sampling code is not used

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.4
    • Fix Version/s: 0.99.0, 0.98.5, 2.0.0
    • Component/s: None
    • Labels:
      None

      Description

      HFileReaderV2 calls HFile#offerReadLatency and HFileWriterV2 calls HFile#offerWriteLatency but the samples are never retrieved. There are no callers of HFile#getReadLatenciesNanos, HFile#getWriteLatenciesNanos, and related. The three ArrayBlockingQueues we are using as sample buffers in HFile will fill quickly and are never drained.

      There are also no callers of HFile#getReadTimeMs or HFile#getWriteTimeMs, and related, so we are incrementing a set of AtomicLong counters that will never be read nor reset.

      We are calling System.nanoTime in block read and write paths twice but not utilizing the measurements.

      We should hook this code back up to metrics or remove it.

      We are also not using HFile#getChecksumFailuresCount anywhere but in some unit test code.

        Attachments

        1. HBASE-11586.patch
          6 kB
          Andrew Purtell
        2. HBASE-11586.patch
          35 kB
          Andrew Purtell

          Activity

            People

            • Assignee:
              apurtell Andrew Purtell
              Reporter:
              apurtell Andrew Purtell
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: