Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11558

Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+

    Details

    • Release Note:
      Hide
      TableMapReduceUtil now restores the option to set scanner caching by setting it on the Scan object that is passe in. The priority order for choosing the scanner caching is as follows:

      1. Caching set on the scan object.
      2. Caching specified via the config "hbase.client.scanner.caching", which can either be set manually on the conf or via the helper method TableMapReduceUtil.setScannerCaching().
      3. The default value HConstants.DEFAULT_HBASE_CLIENT_SCANNER_CACHING, which is set to 100 currently.
      Show
      TableMapReduceUtil now restores the option to set scanner caching by setting it on the Scan object that is passe in. The priority order for choosing the scanner caching is as follows: 1. Caching set on the scan object. 2. Caching specified via the config "hbase.client.scanner.caching", which can either be set manually on the conf or via the helper method TableMapReduceUtil.setScannerCaching(). 3. The default value HConstants.DEFAULT_HBASE_CLIENT_SCANNER_CACHING, which is set to 100 currently.

      Description

      0.94 and before, if one sets caching on the Scan object in the Job by calling scan.setCaching(int) and passes it to TableMapReduceUtil, it is correctly read and used by the mappers during a mapreduce job. This is because Scan.write respects and serializes caching, which is used internally by TableMapReduceUtil to serialize and transfer the scan object to the mappers.

      0.95+, after the move to protobuf, ProtobufUtil.toScan does not respect caching anymore as ClientProtos.Scan does not have the field caching. Caching is passed via the ScanRequest object to the server and so is not needed in the Scan object. However, this breaks application code that relies on the earlier behavior. This will lead to sudden degradation in Scan performance 0.96+ for users relying on the old behavior.

      There are 2 options here:
      1. Add caching to Scan object, adding an extra int to the payload for the Scan object which is really not needed in the general case.
      2. Document and preach that TableMapReduceUtil.setScannerCaching must be called by the client.

      1. HBASE_11558-0.96.patch
        16 kB
        Ishan Chhabra
      2. HBASE_11558-0.98.patch
        17 kB
        Ishan Chhabra
      3. HBASE_11558.patch
        17 kB
        Ishan Chhabra
      4. HBASE_11558_v2.patch
        18 kB
        Ishan Chhabra
      5. HBASE_11558-0.96_v2.patch
        17 kB
        Ishan Chhabra
      6. HBASE_11558-0.98_v2.patch
        17 kB
        Ishan Chhabra
      7. HBASE_11558_v2.patch
        18 kB
        Andrew Purtell

        Issue Links

          Activity

          Hide
          ndimiduk Nick Dimiduk added a comment -

          Silently dropping support for passing this configuration is a bug, agreed. However, we also increased the default value of hbase.client.scanner.caching from 1 to 100, so perf drop shouldn't be too egregious.

          Show
          ndimiduk Nick Dimiduk added a comment - Silently dropping support for passing this configuration is a bug, agreed. However, we also increased the default value of hbase.client.scanner.caching from 1 to 100, so perf drop shouldn't be too egregious.
          Hide
          ishanc Ishan Chhabra added a comment -

          Unfortunately our configuration has this value set to 1 (carried over from the default in 0.94) and we faced this issue. Another fellow in the mailing list got perplexed because of this (not sure if he went from 5000 to 100 or 5000 to 1).

          Show
          ishanc Ishan Chhabra added a comment - Unfortunately our configuration has this value set to 1 (carried over from the default in 0.94) and we faced this issue. Another fellow in the mailing list got perplexed because of this (not sure if he went from 5000 to 100 or 5000 to 1).
          Hide
          apurtell Andrew Purtell added a comment -

          Add caching to Scan object, adding an extra int to the payload for the Scan object which is really not needed in the general case.

          But with protobuf there's no overhead if not set.

          Are you working on a patch Ishan Chhabra, or would you like one of us to take it?

          Show
          apurtell Andrew Purtell added a comment - Add caching to Scan object, adding an extra int to the payload for the Scan object which is really not needed in the general case. But with protobuf there's no overhead if not set. Are you working on a patch Ishan Chhabra , or would you like one of us to take it?
          Hide
          ishanc Ishan Chhabra added a comment -

          Andrew Purtell, If caching is set during a general scan (not MapReduce), it will be serialized and sent in the openScanner request even though it is not needed. However, it would just be 3-4 bytes more overhead, and only in the openScanner call and not the next call.

          If this is ok, I would be happy to put a patch up.

          Show
          ishanc Ishan Chhabra added a comment - Andrew Purtell , If caching is set during a general scan (not MapReduce), it will be serialized and sent in the openScanner request even though it is not needed. However, it would just be 3-4 bytes more overhead, and only in the openScanner call and not the next call. If this is ok, I would be happy to put a patch up.
          Hide
          apurtell Andrew Purtell added a comment -

          If this is ok, I would be happy to put a patch up.

          It is. Thanks! Reassigning to you

          Show
          apurtell Andrew Purtell added a comment - If this is ok, I would be happy to put a patch up. It is. Thanks! Reassigning to you
          Hide
          ishanc Ishan Chhabra added a comment -

          Patch for trunk, 96 and 98.

          Show
          ishanc Ishan Chhabra added a comment - Patch for trunk, 96 and 98.
          Hide
          ishanc Ishan Chhabra added a comment -

          Attached patch and added 0.96 as a fix version.

          Show
          ishanc Ishan Chhabra added a comment - Attached patch and added 0.96 as a fix version.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12657987/HBASE_11558.patch
          against trunk revision .
          ATTACHMENT ID: 12657987

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + "\022\024\n\014more_results\030\003 \001(\010\022\013\n\003ttl\030\004 \001(\r\022\030\n\007r" +
          + new java.lang.String[]

          { "Column", "Attribute", "StartRow", "StopRow", "Filter", "TimeRange", "MaxVersions", "CacheBlocks", "BatchSize", "MaxResultSize", "StoreLimit", "StoreOffset", "LoadColumnFamiliesOnDemand", "Small", "Reversed", "Consistency", "Caching", }

          );

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.protobuf.TestProtobufUtil

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657987/HBASE_11558.patch against trunk revision . ATTACHMENT ID: 12657987 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + "\022\024\n\014more_results\030\003 \001(\010\022\013\n\003ttl\030\004 \001(\r\022\030\n\007r" + + new java.lang.String[] { "Column", "Attribute", "StartRow", "StopRow", "Filter", "TimeRange", "MaxVersions", "CacheBlocks", "BatchSize", "MaxResultSize", "StoreLimit", "StoreOffset", "LoadColumnFamiliesOnDemand", "Small", "Reversed", "Consistency", "Caching", } ); +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.protobuf.TestProtobufUtil Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10194//console This message is automatically generated.
          Hide
          ishanc Ishan Chhabra added a comment -

          Fixed ProtobufUtil test and enhanced it a bit. PTAL.

          Show
          ishanc Ishan Chhabra added a comment - Fixed ProtobufUtil test and enhanced it a bit. PTAL.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12658110/HBASE_11558-0.98_v2.patch
          against trunk revision .
          ATTACHMENT ID: 12658110

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10209//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12658110/HBASE_11558-0.98_v2.patch against trunk revision . ATTACHMENT ID: 12658110 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10209//console This message is automatically generated.
          Hide
          apurtell Andrew Purtell added a comment -

          Attach trunk patch again to be most current

          Show
          apurtell Andrew Purtell added a comment - Attach trunk patch again to be most current
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12658453/HBASE_11558_v2.patch
          against trunk revision .
          ATTACHMENT ID: 12658453

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + "\022\024\n\014more_results\030\003 \001(\010\022\013\n\003ttl\030\004 \001(\r\022\030\n\007r" +
          + new java.lang.String[]

          { "Column", "Attribute", "StartRow", "StopRow", "Filter", "TimeRange", "MaxVersions", "CacheBlocks", "BatchSize", "MaxResultSize", "StoreLimit", "StoreOffset", "LoadColumnFamiliesOnDemand", "Small", "Reversed", "Consistency", "Caching", }

          );

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.compactions.TestStripeCompactionPolicy
          org.apache.hadoop.hbase.regionserver.TestDefaultCompactSelection

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12658453/HBASE_11558_v2.patch against trunk revision . ATTACHMENT ID: 12658453 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + "\022\024\n\014more_results\030\003 \001(\010\022\013\n\003ttl\030\004 \001(\r\022\030\n\007r" + + new java.lang.String[] { "Column", "Attribute", "StartRow", "StopRow", "Filter", "TimeRange", "MaxVersions", "CacheBlocks", "BatchSize", "MaxResultSize", "StoreLimit", "StoreOffset", "LoadColumnFamiliesOnDemand", "Small", "Reversed", "Consistency", "Caching", } ); +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.compactions.TestStripeCompactionPolicy org.apache.hadoop.hbase.regionserver.TestDefaultCompactSelection Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10215//console This message is automatically generated.
          Hide
          ishanc Ishan Chhabra added a comment -

          Test failures are due to HBASE-11316

          Show
          ishanc Ishan Chhabra added a comment - Test failures are due to HBASE-11316
          Hide
          ishanc Ishan Chhabra added a comment -

          Andrew Purtell, how can I trigger the build for 0.96 and 0.98 patches?

          Show
          ishanc Ishan Chhabra added a comment - Andrew Purtell , how can I trigger the build for 0.96 and 0.98 patches?
          Hide
          apurtell Andrew Purtell added a comment -

          You cannot. Precommit builds always check out trunk. The test failures reported in the last precommit build do not look related.

          +1 for commit

          Show
          apurtell Andrew Purtell added a comment - You cannot. Precommit builds always check out trunk. The test failures reported in the last precommit build do not look related. +1 for commit
          Hide
          ishanc Ishan Chhabra added a comment -

          Nick Dimiduk, can you +1 and commit?

          Show
          ishanc Ishan Chhabra added a comment - Nick Dimiduk , can you +1 and commit?
          Hide
          ndimiduk Nick Dimiduk added a comment -

          +1 for patch v2.

          TestStripeCompactionPolicy and TestDefaultCompactSelection both pass for me locally. Will commit.

          Show
          ndimiduk Nick Dimiduk added a comment - +1 for patch v2. TestStripeCompactionPolicy and TestDefaultCompactSelection both pass for me locally. Will commit.
          Hide
          ndimiduk Nick Dimiduk added a comment -

          Pushed to 4 branches. Thanks for the patch, Ishan Chhabra.

          Show
          ndimiduk Nick Dimiduk added a comment - Pushed to 4 branches. Thanks for the patch, Ishan Chhabra .
          Hide
          ndimiduk Nick Dimiduk added a comment -

          Ishan Chhabra as a follow-on, what do you think about deprecating TableMapReduceUtil.setScannerCaching in favor of setScanner? Is there any sense in having two ways to specify this?

          We should also look at what happens when a user specifies both. What's the effective behavior? Mind updating the release note appropriately?

          Show
          ndimiduk Nick Dimiduk added a comment - Ishan Chhabra as a follow-on, what do you think about deprecating TableMapReduceUtil.setScannerCaching in favor of setScanner? Is there any sense in having two ways to specify this? We should also look at what happens when a user specifies both. What's the effective behavior? Mind updating the release note appropriately?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #425 (See https://builds.apache.org/job/HBase-0.98/425/)
          HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev 61de4e47835f98dd7d2cec92bf33641c9de072a8)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • hbase-protocol/src/main/protobuf/Client.proto
          • hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #425 (See https://builds.apache.org/job/HBase-0.98/425/ ) HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev 61de4e47835f98dd7d2cec92bf33641c9de072a8) hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-protocol/src/main/protobuf/Client.proto hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5355 (See https://builds.apache.org/job/HBase-TRUNK/5355/)
          HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev 50ac59fa8530bbd35c21cd61cfd64d2bd7d3eb57)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
          • hbase-protocol/src/main/protobuf/Client.proto
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5355 (See https://builds.apache.org/job/HBase-TRUNK/5355/ ) HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev 50ac59fa8530bbd35c21cd61cfd64d2bd7d3eb57) hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java hbase-protocol/src/main/protobuf/Client.proto hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          Hide
          ishanc Ishan Chhabra added a comment -

          Updated release notes. It makes sense to remove the second method. Do you propose to delete the method or mark it as deprecated for now? Which branches should get this patch? I can open a separate JIRA and put in the patch there once the answers are clear.

          Show
          ishanc Ishan Chhabra added a comment - Updated release notes. It makes sense to remove the second method. Do you propose to delete the method or mark it as deprecated for now? Which branches should get this patch? I can open a separate JIRA and put in the patch there once the answers are clear.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in hbase-0.96 #414 (See https://builds.apache.org/job/hbase-0.96/414/)
          HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev efdbe072ef7e910259360bfb01bc4200eab86a4f)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • hbase-protocol/src/main/protobuf/Client.proto
          Show
          hudson Hudson added a comment - FAILURE: Integrated in hbase-0.96 #414 (See https://builds.apache.org/job/hbase-0.96/414/ ) HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev efdbe072ef7e910259360bfb01bc4200eab86a4f) hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-protocol/src/main/protobuf/Client.proto
          Hide
          ndimiduk Nick Dimiduk added a comment -

          Thanks, looks good.

          Go ahead and open the ticket. Should be deprecated on 0.98 and branch-1, removed from master. In addition to the deprecation annotations on Java methods, we should WARN when the config is used.

          Show
          ndimiduk Nick Dimiduk added a comment - Thanks, looks good. Go ahead and open the ticket. Should be deprecated on 0.98 and branch-1, removed from master. In addition to the deprecation annotations on Java methods, we should WARN when the config is used.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #403 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/403/)
          HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev 61de4e47835f98dd7d2cec92bf33641c9de072a8)

          • hbase-protocol/src/main/protobuf/Client.proto
          • hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #403 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/403/ ) HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev 61de4e47835f98dd7d2cec92bf33641c9de072a8) hbase-protocol/src/main/protobuf/Client.proto hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in hbase-0.96-hadoop2 #287 (See https://builds.apache.org/job/hbase-0.96-hadoop2/287/)
          HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev efdbe072ef7e910259360bfb01bc4200eab86a4f)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • hbase-protocol/src/main/protobuf/Client.proto
          • hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #287 (See https://builds.apache.org/job/hbase-0.96-hadoop2/287/ ) HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev efdbe072ef7e910259360bfb01bc4200eab86a4f) hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-protocol/src/main/protobuf/Client.proto hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #76 (See https://builds.apache.org/job/HBase-1.0/76/)
          HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev 2af67c298645361b86a424362e705c2501e0c1eb)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
          • hbase-protocol/src/main/protobuf/Client.proto
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #76 (See https://builds.apache.org/job/HBase-1.0/76/ ) HBASE-11558 Caching set on Scan object gets lost when using TableMapReduceUtil in 0.95+ (Ishan Chhabra) (ndimiduk: rev 2af67c298645361b86a424362e705c2501e0c1eb) hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-protocol/src/main/protobuf/Client.proto
          Hide
          enis Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          enis Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

            People

            • Assignee:
              ishanc Ishan Chhabra
              Reporter:
              ishanc Ishan Chhabra
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development