Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10403 Simplify offheap cache configuration
  3. HBASE-11520

Simplify offheap cache config by removing the confusing "hbase.bucketcache.percentage.in.combinedcache"

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.99.0
    • 0.99.0
    • io
    • None
    • Reviewed
    • Hide
      Remove "hbase.bucketcache.percentage.in.combinedcache". Simplifies config of block cache. If you are using this config., after this patch goes in, it will be ignored. The L1 LruBlockCache will be whatever hfile.block.cache.size is set to and the L2 BucketCache will be whatever hbase.bucketcache.size is set to.
      Show
      Remove "hbase.bucketcache.percentage.in.combinedcache". Simplifies config of block cache. If you are using this config., after this patch goes in, it will be ignored. The L1 LruBlockCache will be whatever hfile.block.cache.size is set to and the L2 BucketCache will be whatever hbase.bucketcache.size is set to.

    Description

      Remove "hbase.bucketcache.percentage.in.combinedcache". It is unnecessary complication of block cache config. Let L1 config setup be as it is whether a L2 present or not, just set hfile.block.cache.size (not hbase.bucketcache.size * (1.0 - hbase.bucketcache.percentage.in.combinedcache)). For L2, let hbase.bucketcache.size be the actual size of the bucket cache, not hbase.bucketcache.size * hbase.bucketcache.percentage.in.combinedcache.

      Attached patch removes the config. and updates docs. Adds tests to confirm configs are as expected whether a CombinedBlockCache deploy or a strict L1+L2 deploy.

      Attachments

        1. 11520.txt
          17 kB
          Michael Stack
        2. 11520v2.txt
          18 kB
          Michael Stack
        3. 11520v3.txt
          24 kB
          Michael Stack
        4. 11520v3.txt
          24 kB
          Michael Stack

        Activity

          People

            stack Michael Stack
            stack Michael Stack
            Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: