Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11480

ClientScanner might not close the HConnection created in construction

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.96.2, 0.94.20, 0.98.3
    • 0.96.3, 0.98.5, 0.94.22
    • Client, Scanners
    • None
    • Reviewed
    • Deprecate a (unused) ClientScanner constructor because can leave a connection open.

    Description

      ClientScanner will create HConnection in its construction:

          public ClientScanner(final Configuration conf, final Scan scan,
              final byte[] tableName) throws IOException {
            this(conf, scan, tableName, HConnectionManager.getConnection(conf));
          }
      

      However, this connection won't be closed in ClientScanner.close(). Is it better to deprecate this construction?

      Attachments

        1. HBASE-11480-0.98-v1.patch
          0.7 kB
          Jianwei Cui
        2. HBASE-11480-0.96-v1.patch
          0.7 kB
          Jianwei Cui
        3. HBASE-11480-0.95-v1.patch
          0.7 kB
          Jianwei Cui
        4. HBASE-11480-0.94-v1.patch
          0.7 kB
          Jianwei Cui

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cuijianwei Jianwei Cui
            cuijianwei Jianwei Cui
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment