Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11474

[Thrift2] support authentication/impersonation

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, 0.98.4, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is to do the same as HBASE-11349 for Thrift2.

      1. hbase-11474.patch
        23 kB
        Jimmy Xiang
      2. hbase-11474_1.patch
        23 kB
        Jimmy Xiang

        Issue Links

          Activity

          Hide
          enis Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          enis Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #74 (See https://builds.apache.org/job/HBase-1.0/74/)
          HBASE-11540 Document HBASE-11474 (Misty Stanley-Jones) (jxiang: rev 90eb08eda58f5d921f4c311cfd50ae55dbb1b7d6)

          • src/main/docbkx/security.xml
          • src/main/docbkx/thrift_filter_language.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #74 (See https://builds.apache.org/job/HBase-1.0/74/ ) HBASE-11540 Document HBASE-11474 (Misty Stanley-Jones) (jxiang: rev 90eb08eda58f5d921f4c311cfd50ae55dbb1b7d6) src/main/docbkx/security.xml src/main/docbkx/thrift_filter_language.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5351 (See https://builds.apache.org/job/HBase-TRUNK/5351/)
          HBASE-11540 Document HBASE-11474 (Misty Stanley-Jones) (jxiang: rev 9cc2b0ae9d8f08e01cc703447994368596e9874a)

          • src/main/docbkx/thrift_filter_language.xml
          • src/main/docbkx/security.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5351 (See https://builds.apache.org/job/HBase-TRUNK/5351/ ) HBASE-11540 Document HBASE-11474 (Misty Stanley-Jones) (jxiang: rev 9cc2b0ae9d8f08e01cc703447994368596e9874a) src/main/docbkx/thrift_filter_language.xml src/main/docbkx/security.xml
          Hide
          jxiang Jimmy Xiang added a comment -

          Integrated into 0.98, branch 1, and master. Thanks Matteo for the review.

          Show
          jxiang Jimmy Xiang added a comment - Integrated into 0.98, branch 1, and master. Thanks Matteo for the review.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #372 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/372/)
          HBASE-11474 [Thrift2] support authentication/impersonation (jxiang: rev 9cf54eee53e184b78ff05b0c6d2485f062c8cb83)

          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #372 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/372/ ) HBASE-11474 [Thrift2] support authentication/impersonation (jxiang: rev 9cf54eee53e184b78ff05b0c6d2485f062c8cb83) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #34 (See https://builds.apache.org/job/HBase-1.0/34/)
          HBASE-11474 [Thrift2] support authentication/impersonation (jxiang: rev 757ecdb14f75169b1c1a02e7b36fd9c463a7b8f7)

          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.0 #34 (See https://builds.apache.org/job/HBase-1.0/34/ ) HBASE-11474 [Thrift2] support authentication/impersonation (jxiang: rev 757ecdb14f75169b1c1a02e7b36fd9c463a7b8f7) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #5295 (See https://builds.apache.org/job/HBase-TRUNK/5295/)
          HBASE-11474 [Thrift2] support authentication/impersonation (jxiang: rev fc573634041242c322c29cff722eb0d74d3ab20f)

          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java
          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5295 (See https://builds.apache.org/job/HBase-TRUNK/5295/ ) HBASE-11474 [Thrift2] support authentication/impersonation (jxiang: rev fc573634041242c322c29cff722eb0d74d3ab20f) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98 #392 (See https://builds.apache.org/job/HBase-0.98/392/)
          HBASE-11474 [Thrift2] support authentication/impersonation (jxiang: rev 9cf54eee53e184b78ff05b0c6d2485f062c8cb83)

          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
          • hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java
          • hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98 #392 (See https://builds.apache.org/job/HBase-0.98/392/ ) HBASE-11474 [Thrift2] support authentication/impersonation (jxiang: rev 9cf54eee53e184b78ff05b0c6d2485f062c8cb83) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConnectionCache.java hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Hide
          mbertozzi Matteo Bertozzi added a comment -

          +1

          Show
          mbertozzi Matteo Bertozzi added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12655267/hbase-11474_1.patch
          against trunk revision .
          ATTACHMENT ID: 12655267

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 findbugs. The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + private static TServer getTNonBlockingServer(TProtocolFactory protocolFactory, TProcessor processor,
          + private static TServer getTThreadPoolServer(TProtocolFactory protocolFactory, TProcessor processor,

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655267/hbase-11474_1.patch against trunk revision . ATTACHMENT ID: 12655267 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + private static TServer getTNonBlockingServer(TProtocolFactory protocolFactory, TProcessor processor, + private static TServer getTThreadPoolServer(TProtocolFactory protocolFactory, TProcessor processor, +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10038//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12655267/hbase-11474_1.patch
          against trunk revision .
          ATTACHMENT ID: 12655267

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 findbugs. The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + private static TServer getTNonBlockingServer(TProtocolFactory protocolFactory, TProcessor processor,
          + private static TServer getTThreadPoolServer(TProtocolFactory protocolFactory, TProcessor processor,

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655267/hbase-11474_1.patch against trunk revision . ATTACHMENT ID: 12655267 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + private static TServer getTNonBlockingServer(TProtocolFactory protocolFactory, TProcessor processor, + private static TServer getTThreadPoolServer(TProtocolFactory protocolFactory, TProcessor processor, +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10037//console This message is automatically generated.
          Hide
          jxiang Jimmy Xiang added a comment -

          Attached the same patch that hadoopqa should understand now.

          Show
          jxiang Jimmy Xiang added a comment - Attached the same patch that hadoopqa should understand now.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12655261/hbase-11474.patch
          against trunk revision .
          ATTACHMENT ID: 12655261

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10036//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655261/hbase-11474.patch against trunk revision . ATTACHMENT ID: 12655261 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10036//console This message is automatically generated.

            People

            • Assignee:
              jxiang Jimmy Xiang
              Reporter:
              jxiang Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development