HBase
  1. HBase
  2. HBASE-11452

add getUserPermission feature in AccessControlClient as client API

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 0.99.0, 0.98.4, 2.0.0
    • Component/s: Client, security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently user can 'grant','revoke' and show 'user_permission' through hbase shell. And there are client api implemented in AccessControlClient.java for 'grant' and 'revoke'. This jira is to add the 'user_permission' feature with a new method called 'getUserPermission'

      To keep interface consistant, this jira will also update user_permission.rb to use this API directly. The test result is

      hbase(main):001:0> user_permission
      User                                                Table,Family,Qualifier:Permission                                                                                                                      
       hbase                                              dn:t1,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]                                                                                            
       biadmin                                            etest,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]                                                                                            
       hive                                               t1_dn,,: [Permission: actions=READ,WRITE]                                                                                                              
       biadmin                                            table1,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]                                                                                           
       biadmin                                            table2,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]                                                                                           
       biadmin                                            test_dn,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]                                                                                          
      6 row(s) in 1.6220 seconds
      
      hbase(main):002:0> user_permission 't.*'
      User                                                Table,Family,Qualifier:Permission                                                                                                                      
       hive                                               t1_dn,,: [Permission: actions=READ,WRITE]                                                                                                              
       biadmin                                            table1,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]                                                                                           
       biadmin                                            table2,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]                                                                                           
       biadmin                                            test_dn,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]                                                                                          
      4 row(s) in 0.2130 seconds
      
      hbase(main):003:0> user_permission 'dn:t1'
      User                                                Table,Family,Qualifier:Permission                                                                                                                      
       hbase                                              dn:t1,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]                                                                                            
      1 row(s) in 0.0790 seconds
      
      1. HBASE-11452-master-v0.patch
        9 kB
        Demai Ni
      2. HBASE-11452-master-v1.patch
        9 kB
        Demai Ni
      3. HBASE-11452-master-v1.patch
        9 kB
        Demai Ni
      4. HBASE-11452-master-v2.patch
        9 kB
        Demai Ni
      5. HBASE-11452-master-v3.patch
        9 kB
        stack

        Activity

        Hide
        Demai Ni added a comment -

        patch is attached for master branch.

        Show
        Demai Ni added a comment - patch is attached for master branch.
        Hide
        Andrew Purtell added a comment -

        I don't have a strong preference, but can we consider calling this getUserPermission? Do I have a Java variant of Stockholm Syndrome?

        +
        +  /**
        +   * List all the userPermissions matching the given pattern.
        +   * @param conf
        +   * @param tableRegex The regular expression string to match against
        +   * @return - returns an array of UserPermissions
        +   * @throws Throwable
        +   */
        +  public static List<UserPermission> userPermission(Configuration conf, String tableRegex)
        +      throws Throwable {
        

        Patch looks good

        Show
        Andrew Purtell added a comment - I don't have a strong preference, but can we consider calling this getUserPermission? Do I have a Java variant of Stockholm Syndrome? + + /** + * List all the userPermissions matching the given pattern. + * @param conf + * @param tableRegex The regular expression string to match against + * @return - returns an array of UserPermissions + * @throws Throwable + */ + public static List<UserPermission> userPermission(Configuration conf, String tableRegex) + throws Throwable { Patch looks good
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12653503/HBASE-11452-master-v0.patch
        against trunk revision .
        ATTACHMENT ID: 12653503

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 findbugs. The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.client.TestReplicaWithCluster.testChangeTable(TestReplicaWithCluster.java:217)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12653503/HBASE-11452-master-v0.patch against trunk revision . ATTACHMENT ID: 12653503 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.client.TestReplicaWithCluster.testChangeTable(TestReplicaWithCluster.java:217) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9933//console This message is automatically generated.
        Hide
        Demai Ni added a comment -

        the failed replication Testcases should not related with this patch. I also can't find the artifact of findingbugs warnings. The link will hit 404 error, which is odd.

        Andrew Purtell, thanks for the comments.

        can we consider calling this getUserPermission?

        sure. I will change the method name.

        Do I have a Java variant of Stockholm Syndrome?

        would you please elaborate a little bit? do you feel that we have too many ways to retrieve the same userPermission information? or we should use 'tableName' directly instead of 'tableRegex'? Thanks

        Demai

        Show
        Demai Ni added a comment - the failed replication Testcases should not related with this patch. I also can't find the artifact of findingbugs warnings. The link will hit 404 error, which is odd. Andrew Purtell , thanks for the comments. can we consider calling this getUserPermission? sure. I will change the method name. Do I have a Java variant of Stockholm Syndrome? would you please elaborate a little bit? do you feel that we have too many ways to retrieve the same userPermission information? or we should use 'tableName' directly instead of 'tableRegex'? Thanks Demai
        Hide
        Demai Ni added a comment -

        attached v1 patch with method name changed to getUserPermission().

        also to use it to get another round with hadoopQA for the failed testcases and the findingbug warning

        Show
        Demai Ni added a comment - attached v1 patch with method name changed to getUserPermission(). also to use it to get another round with hadoopQA for the failed testcases and the findingbug warning
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12653656/HBASE-11452-master-v1.patch
        against trunk revision .
        ATTACHMENT ID: 12653656

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestMultiParallel
        org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation
        org.apache.hadoop.hbase.regionserver.TestZKLessSplitOnCluster

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels.testMRWithOutputFormat(TestImportTSVWithVisibilityLabels.java:213)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12653656/HBASE-11452-master-v1.patch against trunk revision . ATTACHMENT ID: 12653656 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation org.apache.hadoop.hbase.regionserver.TestZKLessSplitOnCluster -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels.testMRWithOutputFormat(TestImportTSVWithVisibilityLabels.java:213) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9942//console This message is automatically generated.
        Hide
        Andrew Purtell added a comment -

        Do I have a Java variant of Stockholm Syndrome?

        would you please elaborate a little bit?

        Never mind

        Patch v1 looks good, +1

        The unit test failures look unrelated to this patch, high load up on HadoopQA maybe

        Show
        Andrew Purtell added a comment - Do I have a Java variant of Stockholm Syndrome? would you please elaborate a little bit? Never mind Patch v1 looks good, +1 The unit test failures look unrelated to this patch, high load up on HadoopQA maybe
        Hide
        Andrew Purtell added a comment -

        This change adds a new method to a client API so should be fine for 0.98+

        Show
        Andrew Purtell added a comment - This change adds a new method to a client API so should be fine for 0.98+
        Hide
        Demai Ni added a comment -

        Andrew Purtell,

        thanks for the review. The patch can be applied to 0.98 directly.

        the ' 11 new Findbugs' is still a puzzle to me, as I can't access the files of 'Findbugs warnings' from HadoopQA and couldn't generate them locally. I re-exam the code, and don't think the patch can cause so many Fingbugs warnings. well, I certainly could be wrong here.

        on a side note, stack mentioned that trunk is probably broken. so probably better to rerun the QA again after fixed.

        Demai

        Show
        Demai Ni added a comment - Andrew Purtell , thanks for the review. The patch can be applied to 0.98 directly. the ' 11 new Findbugs' is still a puzzle to me, as I can't access the files of 'Findbugs warnings' from HadoopQA and couldn't generate them locally. I re-exam the code, and don't think the patch can cause so many Fingbugs warnings. well, I certainly could be wrong here. on a side note, stack mentioned that trunk is probably broken. so probably better to rerun the QA again after fixed. Demai
        Hide
        Andrew Purtell added a comment -

        Let me try this out locally. Will commit shortly. Ping Enis Soztutar, going into branch-1 also

        Show
        Andrew Purtell added a comment - Let me try this out locally. Will commit shortly. Ping Enis Soztutar , going into branch-1 also
        Hide
        Demai Ni added a comment -

        Andrew Purtell,

        thanks. since Stack fixed the findbugs link, let me try the patch one more time.

        Demai

        Show
        Demai Ni added a comment - Andrew Purtell , thanks. since Stack fixed the findbugs link, let me try the patch one more time. Demai
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12654036/HBASE-11452-master-v1.patch
        against trunk revision .
        ATTACHMENT ID: 12654036

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9966//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12654036/HBASE-11452-master-v1.patch against trunk revision . ATTACHMENT ID: 12654036 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9966//console This message is automatically generated.
        Hide
        Demai Ni added a comment -

        a minor conflict due to new commit. upload v2 patch

        Show
        Demai Ni added a comment - a minor conflict due to new commit. upload v2 patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12654042/HBASE-11452-master-v2.patch
        against trunk revision .
        ATTACHMENT ID: 12654042

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.wal.TestLogRolling

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.regionserver.TestHRegion.testWritesWhileGetting(TestHRegion.java:3500)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12654042/HBASE-11452-master-v2.patch against trunk revision . ATTACHMENT ID: 12654042 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRolling -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.regionserver.TestHRegion.testWritesWhileGetting(TestHRegion.java:3500) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9967//console This message is automatically generated.
        Hide
        Enis Soztutar added a comment -

        looks good for branch-1 as well. Should this be getUserPermissions instead?

        Show
        Enis Soztutar added a comment - looks good for branch-1 as well. Should this be getUserPermissions instead?
        Hide
        Demai Ni added a comment -

        Enis Soztutar,

        thanks. the method name is 'getUserPermission' in the patch now. let me change the jira description.

        Demai

        Show
        Demai Ni added a comment - Enis Soztutar , thanks. the method name is 'getUserPermission' in the patch now. let me change the jira description. Demai
        Hide
        Demai Ni added a comment -

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        didn't find any of them related with this patch. And also saw same warnings show up from other recent HadoopQA testing.

        The unit test failures doesn't look related either.

        Demai

        Show
        Demai Ni added a comment - -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. didn't find any of them related with this patch. And also saw same warnings show up from other recent HadoopQA testing. The unit test failures doesn't look related either. Demai
        Hide
        stack added a comment -

        I think Enis was suggesting change method name from getUserPermission to getUserPermissions. I can change on commit np Demai Ni but where is it used in the *.rb files? It doesn't seem to be used? Am I reading it right?

        The findbugs are not yours I'd say. We are currently running with 4 findbugs warnings (was 13 but one of the lads has been knocking them down).

        Show
        stack added a comment - I think Enis was suggesting change method name from getUserPermission to getUserPermissions. I can change on commit np Demai Ni but where is it used in the *.rb files? It doesn't seem to be used? Am I reading it right? The findbugs are not yours I'd say. We are currently running with 4 findbugs warnings (was 13 but one of the lads has been knocking them down).
        Hide
        Andrew Purtell added a comment -

        I can change on commit np Demai Ni but where is it used in the *.rb files? It doesn't seem to be used?

        You missed the change in security.rb

        Show
        Andrew Purtell added a comment - I can change on commit np Demai Ni but where is it used in the *.rb files? It doesn't seem to be used? You missed the change in security.rb
        Hide
        stack added a comment -

        Thanks Andrew. I was expecting some ruby magic to be going on. Here is patch that does Enis suggestion. It is what I committed.

        Show
        stack added a comment - Thanks Andrew. I was expecting some ruby magic to be going on. Here is patch that does Enis suggestion. It is what I committed.
        Hide
        stack added a comment -

        Committed to 0.98, branch-1 and master. Thanks Demai.

        Show
        stack added a comment - Committed to 0.98, branch-1 and master. Thanks Demai.
        Hide
        Demai Ni added a comment -

        stack,Andrew Purtell and Enis Soztutar, many thanks for the review and commit the fix. Sorry for the late response. Appreciate the help

        Demai

        Show
        Demai Ni added a comment - stack , Andrew Purtell and Enis Soztutar , many thanks for the review and commit the fix. Sorry for the late response. Appreciate the help Demai
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #357 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/357/)
        HBASE-11452 add getUserPermission feature in AccessControlClient as client API (Demai Ni) (stack: rev 576d734e5b712fb82688c412f3f1aecc2ddd39e6)

        • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java
        • hbase-shell/src/main/ruby/shell/commands/user_permission.rb
        • hbase-shell/src/main/ruby/hbase/security.rb
        • hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #357 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/357/ ) HBASE-11452 add getUserPermission feature in AccessControlClient as client API (Demai Ni) (stack: rev 576d734e5b712fb82688c412f3f1aecc2ddd39e6) hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java hbase-shell/src/main/ruby/shell/commands/user_permission.rb hbase-shell/src/main/ruby/hbase/security.rb hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #377 (See https://builds.apache.org/job/HBase-0.98/377/)
        HBASE-11452 add getUserPermission feature in AccessControlClient as client API (Demai Ni) (stack: rev 576d734e5b712fb82688c412f3f1aecc2ddd39e6)

        • hbase-shell/src/main/ruby/shell/commands/user_permission.rb
        • hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
        • hbase-shell/src/main/ruby/hbase/security.rb
        • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #377 (See https://builds.apache.org/job/HBase-0.98/377/ ) HBASE-11452 add getUserPermission feature in AccessControlClient as client API (Demai Ni) (stack: rev 576d734e5b712fb82688c412f3f1aecc2ddd39e6) hbase-shell/src/main/ruby/shell/commands/user_permission.rb hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java hbase-shell/src/main/ruby/hbase/security.rb hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5274 (See https://builds.apache.org/job/HBase-TRUNK/5274/)
        HBASE-11452 add getUserPermission feature in AccessControlClient as client API (Demai Ni) (stack: rev c6db30897704af040b73eb0ff3138ce4e7b956d5)

        • hbase-shell/src/main/ruby/hbase/security.rb
        • hbase-shell/src/main/ruby/shell/commands/user_permission.rb
        • hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5274 (See https://builds.apache.org/job/HBase-TRUNK/5274/ ) HBASE-11452 add getUserPermission feature in AccessControlClient as client API (Demai Ni) (stack: rev c6db30897704af040b73eb0ff3138ce4e7b956d5) hbase-shell/src/main/ruby/hbase/security.rb hbase-shell/src/main/ruby/shell/commands/user_permission.rb hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-1.0 #14 (See https://builds.apache.org/job/HBase-1.0/14/)
        HBASE-11452 add getUserPermission feature in AccessControlClient as client API (Demai Ni) (stack: rev b9906005d9397c721a5a8f87f2fa31e3fab84f09)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestSSLHttpServer.java
        • hbase-shell/src/main/ruby/shell/commands/user_permission.rb
        • hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java
        • hbase-shell/src/main/ruby/hbase/security.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-1.0 #14 (See https://builds.apache.org/job/HBase-1.0/14/ ) HBASE-11452 add getUserPermission feature in AccessControlClient as client API (Demai Ni) (stack: rev b9906005d9397c721a5a8f87f2fa31e3fab84f09) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestSSLHttpServer.java hbase-shell/src/main/ruby/shell/commands/user_permission.rb hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java hbase-shell/src/main/ruby/hbase/security.rb
        Hide
        Andrew Purtell added a comment -

        Thanks stack

        Show
        Andrew Purtell added a comment - Thanks stack
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Demai Ni
            Reporter:
            Demai Ni
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development