HBase
  1. HBase
  2. HBASE-11272

Backport HBASE-11218 (Data loss in HBase standalone mode) to 0.98

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Consider backporting the fix on HBASE-11218 to 0.98.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        7h 3m 1 Andrew Purtell 30/May/14 00:56
        Patch Available Patch Available Resolved Resolved
        22m 58s 1 Andrew Purtell 30/May/14 01:19
        Andrew Purtell made changes -
        Fix Version/s 0.98.3 [ 12326765 ]
        Fix Version/s 0.98.4 [ 12326810 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #321 (See https://builds.apache.org/job/HBase-0.98/321/)
        HBASE-11272 Backport HBASE-11218 (Data loss in HBase standalone mode) to 0.98 (apurtell: rev 13c7ff669532e18ebf5261734b98c51a4ad69c6b)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #321 (See https://builds.apache.org/job/HBase-0.98/321/ ) HBASE-11272 Backport HBASE-11218 (Data loss in HBase standalone mode) to 0.98 (apurtell: rev 13c7ff669532e18ebf5261734b98c51a4ad69c6b) hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #302 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/302/)
        HBASE-11272 Backport HBASE-11218 (Data loss in HBase standalone mode) to 0.98 (apurtell: rev 13c7ff669532e18ebf5261734b98c51a4ad69c6b)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #302 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/302/ ) HBASE-11272 Backport HBASE-11218 (Data loss in HBase standalone mode) to 0.98 (apurtell: rev 13c7ff669532e18ebf5261734b98c51a4ad69c6b) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
        Andrew Purtell made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        Andrew Purtell added a comment -

        Committed to 0.98, thanks Enis.

        Show
        Andrew Purtell added a comment - Committed to 0.98, thanks Enis.
        Hide
        Enis Soztutar added a comment -

        +1

        Show
        Enis Soztutar added a comment - +1
        Andrew Purtell made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12647484/HBASE-11272-0.98.patch
        against trunk revision .
        ATTACHMENT ID: 12647484

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 15 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9640//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12647484/HBASE-11272-0.98.patch against trunk revision . ATTACHMENT ID: 12647484 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 15 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9640//console This message is automatically generated.
        Andrew Purtell made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Andrew Purtell added a comment -

        Setting to Patch Available but Hadoop QA will barf on the 0.98 patch

        Show
        Andrew Purtell added a comment - Setting to Patch Available but Hadoop QA will barf on the 0.98 patch
        Andrew Purtell made changes -
        Field Original Value New Value
        Attachment HBASE-11272-0.98.patch [ 12647484 ]
        Hide
        Andrew Purtell added a comment -

        As requested.

        Show
        Andrew Purtell added a comment - As requested.
        Hide
        Enis Soztutar added a comment -

        It might be ok to check for method existence and call it if it is there if there is no corresponding API in hadoop1. It should be fine to only have this working with h2 I would say.

        Show
        Enis Soztutar added a comment - It might be ok to check for method existence and call it if it is there if there is no corresponding API in hadoop1. It should be fine to only have this working with h2 I would say.
        Hide
        Andrew Purtell added a comment -

        We have to work around the lack of FileSystem#setWriteChecksum(boolean) in Hadoop 1. I may resolve this as Wont Fix if it's too much trouble.

        Show
        Andrew Purtell added a comment - We have to work around the lack of FileSystem#setWriteChecksum(boolean) in Hadoop 1. I may resolve this as Wont Fix if it's too much trouble.
        Andrew Purtell created issue -

          People

          • Assignee:
            Andrew Purtell
            Reporter:
            Andrew Purtell
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development