Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11232

Add MultiRowMutation tests.

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.94.19
    • 0.94.23
    • regionserver
    • None

    Description

      The failback code in processRowsWithLocks did not check the column family. If there is an illegal CF in the muation, it will throw NullPointException and the update lock will not be released. So the region can not be flushed and compacted.
      HRegion #4946

              if (!mutations.isEmpty() && !walSyncSuccessful) {
                LOG.warn("Wal sync failed. Roll back " + mutations.size() +
                    " memstore keyvalues for row(s):" +
                    processor.getRowsToLock().iterator().next() + "...");
                for (KeyValue kv : mutations) {
                  stores.get(kv.getFamily()).rollback(kv);
                }
              }
              // 11. Roll mvcc forward
              if (writeEntry != null) {
                mvcc.completeMemstoreInsert(writeEntry);
                writeEntry = null;
              }
              if (locked) {
                this.updatesLock.readLock().unlock();
                locked = false;
              }
      

      Attachments

        1. HBASE-11232-0.94.diff
          9 kB
          Shaohui Liu

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            liushaohui Shaohui Liu
            liushaohui Shaohui Liu
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment