Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11220

Add listeners to ServerManager and AssignmentManager

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.99.0
    • Fix Version/s: 0.99.0, 0.98.3
    • Component/s: master
    • Labels:
      None

      Description

      Add support for listeners to ServerManager and AssignmentManager.
      This will allows to get notified about servers added/removed or regions added/removed/moved.

      I'm planning to use this in the MasterProcedureManager. Since we are starting using the Procedures for distributed operations, we must add support for RS joining or Regions moving. At the moment the operation on the "moving" set of RSs is "lost".

      1. HBASE-11220-v0.patch
        21 kB
        Matteo Bertozzi
      2. HBASE-11220-v1.patch
        21 kB
        Matteo Bertozzi

        Issue Links

          Activity

          Hide
          apurtell Andrew Purtell added a comment -

          Can this target 0.98 also? I can see the issues with "lost" operations, would be good to fix it on that branch also.

          Show
          apurtell Andrew Purtell added a comment - Can this target 0.98 also? I can see the issues with "lost" operations, would be good to fix it on that branch also.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12646806/HBASE-11220-v0.patch
          against trunk revision .
          ATTACHMENT ID: 12646806

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 31 release audit warnings (more than the trunk's current 0 warnings).

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestTableLockManager

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12646806/HBASE-11220-v0.patch against trunk revision . ATTACHMENT ID: 12646806 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 31 release audit warnings (more than the trunk's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestTableLockManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9589//console This message is automatically generated.
          Hide
          otis Otis Gospodnetic added a comment -

          Is this for 0.98 or 0.99?

          Show
          otis Otis Gospodnetic added a comment - Is this for 0.98 or 0.99?
          Hide
          stack stack added a comment -

          Matteo Bertozzi Should it be regionOpened and regionClosed rather than regionLoaded and regionUnloaded? Or onlined and offlined (that is what you call it in your distribution method). Otherwise +1

          Show
          stack stack added a comment - Matteo Bertozzi Should it be regionOpened and regionClosed rather than regionLoaded and regionUnloaded? Or onlined and offlined (that is what you call it in your distribution method). Otherwise +1
          Hide
          mbertozzi Matteo Bertozzi added a comment -

          renamed to opened/closed

          Show
          mbertozzi Matteo Bertozzi added a comment - renamed to opened/closed
          Hide
          stack stack added a comment -

          +1

          Show
          stack stack added a comment - +1
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5147 (See https://builds.apache.org/job/HBase-TRUNK/5147/)
          HBASE-11220 Add listeners to ServerManager and AssignmentManager (matteo.bertozzi: rev ab896f05d1d84f3e634c364a0772ada4c6cd6b9d)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerListener.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentListener.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5147 (See https://builds.apache.org/job/HBase-TRUNK/5147/ ) HBASE-11220 Add listeners to ServerManager and AssignmentManager (matteo.bertozzi: rev ab896f05d1d84f3e634c364a0772ada4c6cd6b9d) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerListener.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentListener.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #318 (See https://builds.apache.org/job/HBase-0.98/318/)
          HBASE-11220 Add listeners to ServerManager and AssignmentManager (matteo.bertozzi: rev 6e4f0fb4b888e24bd575bdb065731f4f33ebc455)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentListener.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerListener.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #318 (See https://builds.apache.org/job/HBase-0.98/318/ ) HBASE-11220 Add listeners to ServerManager and AssignmentManager (matteo.bertozzi: rev 6e4f0fb4b888e24bd575bdb065731f4f33ebc455) hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentListener.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerListener.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #299 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/299/)
          HBASE-11220 Add listeners to ServerManager and AssignmentManager (matteo.bertozzi: rev 6e4f0fb4b888e24bd575bdb065731f4f33ebc455)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentListener.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerListener.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #299 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/299/ ) HBASE-11220 Add listeners to ServerManager and AssignmentManager (matteo.bertozzi: rev 6e4f0fb4b888e24bd575bdb065731f4f33ebc455) hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentListener.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerListener.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentListener.java
          Hide
          enis Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          enis Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

            People

            • Assignee:
              mbertozzi Matteo Bertozzi
              Reporter:
              mbertozzi Matteo Bertozzi
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development