[HBASE-11189] Subprocedure should be marked as complete upon failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.99.0, 0.98.3
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 15/May/14 22:38
• Updated: 21/Feb/15 23:34
• Resolved: 17/May/14 04:05

Description

ProcedureMember#submitSubprocedure() uses the following check:

      if (!rsub.isComplete()) {
        LOG.error("Subproc '" + procName + "' is already running. Bailing out");
        return false;
      }

If a subprocedure of that name previously ran but failed, its complete field would stay false, leading to early bailout.

A failed subprocedure should mark itself complete.