HBase
  1. HBase
  2. HBASE-10979

Fix AnnotationReadingPriorityFunction "scan" handling

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.96.2, 0.98.1, 0.99.0
    • Fix Version/s: 0.99.0, 0.98.2, 0.96.3
    • Component/s: None
    • Labels:
      None

      Description

      AnnotationReadingPriorityFunction does a equals() instead of equalsIgnoreCase() for "Scan", so we never prioritize scan on META

      1. HBASE-10979-0.96-v0.patch
        1 kB
        Matteo Bertozzi
      2. HBASE-10979-v0.patch
        1 kB
        Matteo Bertozzi

        Activity

        Hide
        Jonathan Hsieh added a comment -

        +1

        Show
        Jonathan Hsieh added a comment - +1
        Hide
        Lars Hofhansl added a comment -

        Wow. Good find. +1

        Show
        Lars Hofhansl added a comment - Wow. Good find. +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12640184/HBASE-10979-0.96-v0.patch
        against trunk revision .
        ATTACHMENT ID: 12640184

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9285//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640184/HBASE-10979-0.96-v0.patch against trunk revision . ATTACHMENT ID: 12640184 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9285//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12640177/HBASE-10979-v0.patch
        against trunk revision .
        ATTACHMENT ID: 12640177

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScan(TestMultiTableInputFormat.java:244)
        at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScanYZYToEmpty(TestMultiTableInputFormat.java:195)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640177/HBASE-10979-v0.patch against trunk revision . ATTACHMENT ID: 12640177 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScan(TestMultiTableInputFormat.java:244) at org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat.testScanYZYToEmpty(TestMultiTableInputFormat.java:195) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9284//console This message is automatically generated.
        Hide
        Matteo Bertozzi added a comment -

        committed to 0.96, 0.98 and trunk

        Show
        Matteo Bertozzi added a comment - committed to 0.96, 0.98 and trunk
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #263 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/263/)
        HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587645)

        • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #263 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/263/ ) HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587645) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5087 (See https://builds.apache.org/job/HBase-TRUNK/5087/)
        HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587644)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5087 (See https://builds.apache.org/job/HBase-TRUNK/5087/ ) HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587644) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #279 (See https://builds.apache.org/job/HBase-0.98/279/)
        HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587645)

        • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #279 (See https://builds.apache.org/job/HBase-0.98/279/ ) HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587645) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AnnotationReadingPriorityFunction.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #265 (See https://builds.apache.org/job/hbase-0.96-hadoop2/265/)
        HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587646)

        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #265 (See https://builds.apache.org/job/hbase-0.96-hadoop2/265/ ) HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587646) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #386 (See https://builds.apache.org/job/hbase-0.96/386/)
        HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587646)

        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96 #386 (See https://builds.apache.org/job/hbase-0.96/386/ ) HBASE-10979 Fix AnnotationReadingPriorityFunction 'scan' handling (mbertozzi: rev 1587646) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Matteo Bertozzi
            Reporter:
            Matteo Bertozzi
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development