HBase
  1. HBase
  2. HBASE-10846

Links between active and backup masters are broken

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Not a Problem
    • Affects Version/s: None
    • Fix Version/s: 0.99.0
    • Component/s: None
    • Labels:
      None

      Description

      Links between active and backup masters are broken for the the blanks before info port in the url.

      href="//wcc-hadoop-tst-ct01.bj: 12501/master-status"
      

        Activity

        Hide
        Liu Shaohui added a comment -

        Remove the enter and blanks before the info port

        Show
        Liu Shaohui added a comment - Remove the enter and blanks before the info port
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12637100/HBASE-10846-trunk-v1.diff
        against trunk revision .
        ATTACHMENT ID: 12637100

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 6 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637100/HBASE-10846-trunk-v1.diff against trunk revision . ATTACHMENT ID: 12637100 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc . The javadoc tool appears to have generated 6 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9109//console This message is automatically generated.
        Hide
        stack added a comment -

        Jimmy Xiang You like this?

        Show
        stack added a comment - Jimmy Xiang You like this?
        Hide
        stack added a comment -

        lgtm

        Show
        stack added a comment - lgtm
        Hide
        Jimmy Xiang added a comment -

        I think I fixed it in HBASE-10569 for trunk. We can have this patch for 0.98 and 0.96.

        Show
        Jimmy Xiang added a comment - I think I fixed it in HBASE-10569 for trunk. We can have this patch for 0.98 and 0.96.
        Hide
        Jimmy Xiang added a comment - - edited

        The patch is for trunk actually. Do we need this patch for trunk?

        Before HBASE-10569, I know the link doesn't work. So I fixed it in HBASE-10569 and it's working for me now on firefox at least.
        I don't see if this patch makes any difference for trunk.

        Liu Shaohui, do you see this issue with the latest truck code? Can you have a patch for 0.98/0.96?

        Show
        Jimmy Xiang added a comment - - edited The patch is for trunk actually. Do we need this patch for trunk? Before HBASE-10569 , I know the link doesn't work. So I fixed it in HBASE-10569 and it's working for me now on firefox at least. I don't see if this patch makes any difference for trunk. Liu Shaohui , do you see this issue with the latest truck code? Can you have a patch for 0.98/0.96?
        Hide
        Liu Shaohui added a comment -

        stack Jimmy Xiang
        Sorry for not updating the trunk code and the latest trunk code does't have this issue.
        I will upload a patch for 0.98/0.96 later.

        Show
        Liu Shaohui added a comment - stack Jimmy Xiang Sorry for not updating the trunk code and the latest trunk code does't have this issue. I will upload a patch for 0.98/0.96 later.
        Hide
        Liu Shaohui added a comment -

        stackJimmy Xiang
        0.98 and 0.96 don't have this issue too, for the links are written in one line.

          <td><a href="//<% serverName.getHostname() %>:<% master.getConfiguration().getInt("hbase.master.info.port", 60010) %>/master-status" target="_blank"><% serverName.get
        

        Please close this issue. Sorry for my mistake.

        Show
        Liu Shaohui added a comment - stack Jimmy Xiang 0.98 and 0.96 don't have this issue too, for the links are written in one line. <td><a href= " //<% serverName.getHostname() %>:<% master.getConfiguration().getInt(" hbase.master.info.port ", 60010) %>/master-status" target= "_blank" ><% serverName.get Please close this issue. Sorry for my mistake.
        Hide
        stack added a comment -

        Closing at Liu Shaohui's request

        Show
        stack added a comment - Closing at Liu Shaohui 's request
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Liu Shaohui
            Reporter:
            Liu Shaohui
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development