HBase
  1. HBase
  2. HBASE-10806

Two protos missing in hbase-protocol/pom.xml

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.1, 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      VisibilityLabels.proto and Encryption.proto are missing in hbase-protocol/pom.xml. The corresponding classes are not regenerated in maven cmd:

      mvn compile -Pcompile-protobuf
      

        Activity

        Liu Shaohui created issue -
        Liu Shaohui made changes -
        Field Original Value New Value
        Description VisibilityLabels.proto and Encryption.proto are missing in hbase-protocol/pom.xml. The corresponding classed are not regenerated in maven cmd:
        {code}
        mvn compile -Pcompile-protobuf
        {code}
        Liu Shaohui made changes -
        Environment VisibilityLabels.proto and Encryption.proto are missing in hbase-protocol/pom.xml. The corresponding classed are not regenerated in maven cmd:
        {code}
        mvn compile -Pcompile-protobuf
        {code}
        Hide
        Liu Shaohui added a comment -

        A small patch

        Show
        Liu Shaohui added a comment - A small patch
        Liu Shaohui made changes -
        Attachment HBASE-10806-trunk-v1.diff [ 12635968 ]
        Liu Shaohui made changes -
        Description VisibilityLabels.proto and Encryption.proto are missing in hbase-protocol/pom.xml. The corresponding classed are not regenerated in maven cmd:
        {code}
        mvn compile -Pcompile-protobuf
        {code}
        VisibilityLabels.proto and Encryption.proto are missing in hbase-protocol/pom.xml. The corresponding classes are not regenerated in maven cmd:
        {code}
        mvn compile -Pcompile-protobuf
        {code}
        Liang Xie made changes -
        Assignee Liu Shaohui [ liushaohui ]
        Liang Xie made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12635968/HBASE-10806-trunk-v1.diff
        against trunk revision .
        ATTACHMENT ID: 12635968

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12635968/HBASE-10806-trunk-v1.diff against trunk revision . ATTACHMENT ID: 12635968 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9060//console This message is automatically generated.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Andrew Purtell added a comment -

        Committed to trunk and 0.98. Tested the compile command locally first. Thanks for the patch!

        Show
        Andrew Purtell added a comment - Committed to trunk and 0.98. Tested the compile command locally first. Thanks for the patch!
        Andrew Purtell made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.99.0 [ 12325675 ]
        Fix Version/s 0.98.2 [ 12326505 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5031 (See https://builds.apache.org/job/HBase-TRUNK/5031/)
        HBASE-10806 Two protos missing in hbase-protocol/pom.xml (Liu Shaohui) (apurtell: rev 1579999)

        • /hbase/trunk/hbase-protocol/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5031 (See https://builds.apache.org/job/HBase-TRUNK/5031/ ) HBASE-10806 Two protos missing in hbase-protocol/pom.xml (Liu Shaohui) (apurtell: rev 1579999) /hbase/trunk/hbase-protocol/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #246 (See https://builds.apache.org/job/HBase-0.98/246/)
        HBASE-10806 Two protos missing in hbase-protocol/pom.xml (Liu Shaohui) (apurtell: rev 1580000)

        • /hbase/branches/0.98/hbase-protocol/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #246 (See https://builds.apache.org/job/HBase-0.98/246/ ) HBASE-10806 Two protos missing in hbase-protocol/pom.xml (Liu Shaohui) (apurtell: rev 1580000) /hbase/branches/0.98/hbase-protocol/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #230 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/230/)
        HBASE-10806 Two protos missing in hbase-protocol/pom.xml (Liu Shaohui) (apurtell: rev 1580000)

        • /hbase/branches/0.98/hbase-protocol/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #230 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/230/ ) HBASE-10806 Two protos missing in hbase-protocol/pom.xml (Liu Shaohui) (apurtell: rev 1580000) /hbase/branches/0.98/hbase-protocol/pom.xml
        Liu Shaohui made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Andrew Purtell made changes -
        Fix Version/s 0.98.1 [ 12325664 ]
        Fix Version/s 0.98.2 [ 12326505 ]
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Enis Soztutar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        11m 23s 1 Liang Xie 21/Mar/14 06:31
        Patch Available Patch Available Resolved Resolved
        11h 30m 1 Andrew Purtell 21/Mar/14 18:01
        Resolved Resolved Closed Closed
        337d 5h 29m 1 Enis Soztutar 21/Feb/15 23:31

          People

          • Assignee:
            Liu Shaohui
            Reporter:
            Liu Shaohui
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development