Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, hbase-10070
    • Component/s: None
    • Labels:
      None

      Description

      Currently the way cache works is that the meta row is stored together for all replicas of a region, so if some replicas are in recovery, getting locations for a region will still go to cache only and return null locations for these. Multi-get currently ignores such replicas. It should instead try to get location again from meta if any replica is null.

      1. HBASE-10794.patch
        13 kB
        Sergey Shelukhin
      2. HBASE-10794.patch
        33 kB
        Sergey Shelukhin
      3. HBASE-10794.03.patch
        36 kB
        Sergey Shelukhin
      4. HBASE-10794.02.patch
        34 kB
        Sergey Shelukhin
      5. HBASE-10794.02.addendum.patch
        3 kB
        Sergey Shelukhin
      6. HBASE-10794.01.patch
        33 kB
        Sergey Shelukhin
      7. 0033-HBASE-10794-multi-get-should-handle-replica-location.patch
        37 kB
        Enis Soztutar

        Issue Links

          Activity

          Sergey Shelukhin created issue -
          Sergey Shelukhin made changes -
          Field Original Value New Value
          Link This issue is blocked by HBASE-10634 [ HBASE-10634 ]
          Hide
          Sergey Shelukhin added a comment -
          Show
          Sergey Shelukhin added a comment - Enis Soztutar Devaraj Das fyi
          Sergey Shelukhin made changes -
          Parent HBASE-10070 [ 12682280 ]
          Issue Type Improvement [ 4 ] Sub-task [ 7 ]
          Sergey Shelukhin made changes -
          Link This issue is blocked by HBASE-10701 [ HBASE-10701 ]
          Hide
          Sergey Shelukhin added a comment -

          This patch is on top of two blocking patches

          Show
          Sergey Shelukhin added a comment - This patch is on top of two blocking patches
          Sergey Shelukhin made changes -
          Attachment HBASE-10794.patch [ 12635644 ]
          Hide
          Sergey Shelukhin added a comment -

          include other changes that are not part of HBASE-10634

          Show
          Sergey Shelukhin added a comment - include other changes that are not part of HBASE-10634
          Sergey Shelukhin made changes -
          Attachment HBASE-10794.patch [ 12635662 ]
          Sergey Shelukhin made changes -
          Attachment HBASE-10794.01.patch [ 12635720 ]
          Hide
          Sergey Shelukhin added a comment -

          Another iteration, on top of two patches from blocking jiras

          Show
          Sergey Shelukhin added a comment - Another iteration, on top of two patches from blocking jiras
          Sergey Shelukhin made changes -
          Attachment HBASE-10794.02.patch [ 12635886 ]
          Hide
          Sergey Shelukhin added a comment -

          addendum to the 2nd patch to fix a bug; when upstream patches are committed I'll figure out how to combine all this stuff, it will be committed together

          Show
          Sergey Shelukhin added a comment - addendum to the 2nd patch to fix a bug; when upstream patches are committed I'll figure out how to combine all this stuff, it will be committed together
          Sergey Shelukhin made changes -
          Attachment HBASE-10794.02.addendum.patch [ 12637522 ]
          Hide
          Sergey Shelukhin added a comment -

          Rebased patch, merged in the addendum. No substantial changes so I will commit to branch later today

          Show
          Sergey Shelukhin added a comment - Rebased patch, merged in the addendum. No substantial changes so I will commit to branch later today
          Sergey Shelukhin made changes -
          Attachment HBASE-10794.03.patch [ 12639644 ]
          Sergey Shelukhin made changes -
          Summary multi-get should handle missing replica location from cache multi-get should handle replica location missing from cache
          Hide
          Sergey Shelukhin added a comment -

          committed to branch

          Show
          Sergey Shelukhin added a comment - committed to branch
          Sergey Shelukhin made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Enis Soztutar made changes -
          Hide
          Enis Soztutar added a comment -

          Attaching rebased patch for master that is committed

          Show
          Enis Soztutar added a comment - Attaching rebased patch for master that is committed
          Hide
          Enis Soztutar added a comment -

          Committed to master as part of hbase-10070 branch merge

          Show
          Enis Soztutar added a comment - Committed to master as part of hbase-10070 branch merge
          Enis Soztutar made changes -
          Fix Version/s 0.99.0 [ 12325675 ]
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5245 (See https://builds.apache.org/job/HBase-TRUNK/5245/)
          HBASE-10794 multi-get should handle replica location missing from cache (enis: rev 579f305bd0fb5673a82d3eeb74660db7a0d6ddd8)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/client/CoprocessorHConnection.java
          • hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionAdapter.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5245 (See https://builds.apache.org/job/HBase-TRUNK/5245/ ) HBASE-10794 multi-get should handle replica location missing from cache (enis: rev 579f305bd0fb5673a82d3eeb74660db7a0d6ddd8) hbase-server/src/main/java/org/apache/hadoop/hbase/client/CoprocessorHConnection.java hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClusterConnection.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionAdapter.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
          Enis Soztutar made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          22d 10m 1 Sergey Shelukhin 10/Apr/14 21:58
          Resolved Resolved Closed Closed
          317d 2h 36m 1 Enis Soztutar 21/Feb/15 23:34

            People

            • Assignee:
              Sergey Shelukhin
              Reporter:
              Sergey Shelukhin
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development