HBase
  1. HBase
  2. HBASE-10766

SnapshotCleaner allows to delete referenced files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.96.1.1, 0.94.17
    • Fix Version/s: 0.96.2, 0.98.1, 0.99.0, 0.94.19
    • Component/s: snapshots
    • Labels:
      None

      Description

      The SnapshotFileCache is checking the lastModificationTime() of the ".hbase-snapshot" directory.
      But in this way "pending" snapshots created in temp are not considered.
      since only the parent directory timestamp is updated.

      so, if we create .hbase-snapshot/.tmp/SNAPSHOT_NAME the lastModification timestamp of .hbase-snapshot will not be updated

      https://github.com/apache/hbase/blob/af62395ef3f7e2a8be2ab16d272e5245902d7864/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java#L197

      1. HBASE-10766-v2.patch
        6 kB
        Matteo Bertozzi
      2. HBASE-10766-v1.patch
        6 kB
        Matteo Bertozzi

        Activity

        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #121 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/121/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578450)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #121 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/121/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578450) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96-hadoop2 #246 (See https://builds.apache.org/job/hbase-0.96-hadoop2/246/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578452)

        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #246 (See https://builds.apache.org/job/hbase-0.96-hadoop2/246/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578452) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #58 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/58/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578453)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #58 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/58/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578453) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5020 (See https://builds.apache.org/job/HBase-TRUNK/5020/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578450)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5020 (See https://builds.apache.org/job/HBase-TRUNK/5020/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578450) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-JDK7 #92 (See https://builds.apache.org/job/HBase-0.94-JDK7/92/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578453)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-JDK7 #92 (See https://builds.apache.org/job/HBase-0.94-JDK7/92/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578453) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #356 (See https://builds.apache.org/job/hbase-0.96/356/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578452)

        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96 #356 (See https://builds.apache.org/job/hbase-0.96/356/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578452) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #223 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/223/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578451)

        • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #223 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/223/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578451) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94 #1330 (See https://builds.apache.org/job/HBase-0.94/1330/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578453)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1330 (See https://builds.apache.org/job/HBase-0.94/1330/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578453) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #239 (See https://builds.apache.org/job/HBase-0.98/239/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578451)

        • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #239 (See https://builds.apache.org/job/HBase-0.98/239/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578451) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-security #448 (See https://builds.apache.org/job/HBase-0.94-security/448/)
        HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578453)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-security #448 (See https://builds.apache.org/job/HBase-0.94-security/448/ ) HBASE-10766 SnapshotCleaner allows to delete referenced files (Bharath Vissapragada) (mbertozzi: rev 1578453) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotFileCache.java
        Hide
        Matteo Bertozzi added a comment -

        committed to 0.94, 0.96, 0.98 and trunk

        Show
        Matteo Bertozzi added a comment - committed to 0.94, 0.96, 0.98 and trunk
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12635046/HBASE-10766-v2.patch
        against trunk revision .
        ATTACHMENT ID: 12635046

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12635046/HBASE-10766-v2.patch against trunk revision . ATTACHMENT ID: 12635046 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9024//console This message is automatically generated.
        Hide
        Matteo Bertozzi added a comment -

        v2 should fix the lineLengths problem, no other changes

        Show
        Matteo Bertozzi added a comment - v2 should fix the lineLengths problem, no other changes
        Hide
        Lars Hofhansl added a comment -

        +1 nice find and test.

        Show
        Lars Hofhansl added a comment - +1 nice find and test.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12635014/HBASE-10766-v1.patch
        against trunk revision .
        ATTACHMENT ID: 12635014

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 lineLengths. The patch introduces the following lines longer than 100:
        + tempStatus = fs.getFileStatus(new Path(snapshotDir, SnapshotDescriptionUtils.SNAPSHOT_TMP_DIR_NAME));
        + this.lastModifiedTime = Math.min(dirStatus.getModificationTime(), tempStatus.getModificationTime());

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12635014/HBASE-10766-v1.patch against trunk revision . ATTACHMENT ID: 12635014 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + tempStatus = fs.getFileStatus(new Path(snapshotDir, SnapshotDescriptionUtils.SNAPSHOT_TMP_DIR_NAME)); + this.lastModifiedTime = Math.min(dirStatus.getModificationTime(), tempStatus.getModificationTime()); +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9019//console This message is automatically generated.
        Hide
        Matteo Bertozzi added a comment -

        I've attached patch v1 written by Bharath.
        I've changed the fs.create() to fs.createNewFile() because my machine was complaining about the unclosed files

        Show
        Matteo Bertozzi added a comment - I've attached patch v1 written by Bharath. I've changed the fs.create() to fs.createNewFile() because my machine was complaining about the unclosed files

          People

          • Assignee:
            bharath v
            Reporter:
            Matteo Bertozzi
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development