[HBASE-10766] SnapshotCleaner allows to delete referenced files

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.98.0, 0.96.1.1, 0.94.17
• Fix Version/s: 0.96.2, 0.98.1, 0.99.0, 0.94.19
• Component/s: snapshots
• Assignee: Bharath Vissapragada
• Reporter: Matteo Bertozzi
• Created: 16/Mar/14 20:16
• Updated: 28/Apr/14 22:29
• Resolved: 17/Mar/14 16:16

Description

The SnapshotFileCache is checking the lastModificationTime() of the ".hbase-snapshot" directory.
But in this way "pending" snapshots created in temp are not considered.
since only the parent directory timestamp is updated.

so, if we create .hbase-snapshot/.tmp/SNAPSHOT_NAME the lastModification timestamp of .hbase-snapshot will not be updated

https://github.com/apache/hbase/blob/af62395ef3f7e2a8be2ab16d272e5245902d7864/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java#L197