HBase
  1. HBase
  2. HBASE-10737

HConnectionImplementation should stop RpcClient on close

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.96.2, 0.98.1, 0.99.0
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HConnectionImplementation doesn't stop RpcClient on close so that it could leak some RpcClient connections/worker threads.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        21m 14s 1 Jimmy Xiang 13/Mar/14 16:15
        Patch Available Patch Available Resolved Resolved
        4h 12m 1 Jimmy Xiang 13/Mar/14 20:28
        Resolved Resolved Closed Closed
        345d 3h 2m 1 Enis Soztutar 21/Feb/15 23:30
        Enis Soztutar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #237 (See https://builds.apache.org/job/hbase-0.96-hadoop2/237/)
        HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577307)

        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #237 (See https://builds.apache.org/job/hbase-0.96-hadoop2/237/ ) HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577307) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #116 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/116/)
        HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577304)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #116 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/116/ ) HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577304) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #212 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/212/)
        HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577306)

        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #212 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/212/ ) HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577306) /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96 #344 (See https://builds.apache.org/job/hbase-0.96/344/)
        HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577307)

        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #344 (See https://builds.apache.org/job/hbase-0.96/344/ ) HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577307) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #226 (See https://builds.apache.org/job/HBase-0.98/226/)
        HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577306)

        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #226 (See https://builds.apache.org/job/HBase-0.98/226/ ) HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577306) /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5006 (See https://builds.apache.org/job/HBase-TRUNK/5006/)
        HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577304)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5006 (See https://builds.apache.org/job/HBase-TRUNK/5006/ ) HBASE-10737 HConnectionImplementation should stop RpcClient on close (jxiang: rev 1577304) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
        Jimmy Xiang made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.96.2 [ 12325658 ]
        Fix Version/s 0.98.1 [ 12325664 ]
        Fix Version/s 0.99.0 [ 12325675 ]
        Resolution Fixed [ 1 ]
        Hide
        Jimmy Xiang added a comment -

        Integrated into 0.96, 0.98, and trunk. Thanks Nicolas for the review.

        Show
        Jimmy Xiang added a comment - Integrated into 0.96, 0.98, and trunk. Thanks Nicolas for the review.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12634456/hbase-10737.patch
        against trunk revision .
        ATTACHMENT ID: 12634456

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634456/hbase-10737.patch against trunk revision . ATTACHMENT ID: 12634456 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8970//console This message is automatically generated.
        Hide
        Nicolas Liochon added a comment -

        lgtm, +1

        Show
        Nicolas Liochon added a comment - lgtm, +1
        Jimmy Xiang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Jimmy Xiang made changes -
        Field Original Value New Value
        Attachment hbase-10737.patch [ 12634456 ]
        Jimmy Xiang created issue -

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development