HBase
  1. HBase
  2. HBASE-10639

Unload script displays wrong counts (off by one) when unloading regions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.94.17
    • Fix Version/s: 0.96.2, 0.98.1, 0.99.0
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Upon running an unload command, such as:
      hbase org.jruby.Main /usr/lib/hbase/bin/region_mover.rb unload `hostname`, the region counter is indexed at 0 and hence, when the regions are being moved, regions are being counted from 0 instead of 1.

      1. hbase_10639.patch
        1 kB
        Srikanth Srungarapu
      2. HBASE-10639_v2.patch
        2 kB
        Srikanth Srungarapu

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-JDK7 #114 (See https://builds.apache.org/job/HBase-0.94-JDK7/114/)
        HBASE-10991 Port HBASE-10639 'Unload script displays wrong counts (off by one) when unloading regions' to 0.94 (Srikanth Srungarapu) (tedyu: rev 1587762)

        • /hbase/branches/0.94/bin/region_mover.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-JDK7 #114 (See https://builds.apache.org/job/HBase-0.94-JDK7/114/ ) HBASE-10991 Port HBASE-10639 'Unload script displays wrong counts (off by one) when unloading regions' to 0.94 (Srikanth Srungarapu) (tedyu: rev 1587762) /hbase/branches/0.94/bin/region_mover.rb
        Hide
        Srikanth Srungarapu added a comment -

        Ted Yu I apologize for not creating the backport request myself and thank you for taking time to reviewing and committing the patch.

        Show
        Srikanth Srungarapu added a comment - Ted Yu I apologize for not creating the backport request myself and thank you for taking time to reviewing and committing the patch.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94 #1348 (See https://builds.apache.org/job/HBase-0.94/1348/)
        HBASE-10991 Port HBASE-10639 'Unload script displays wrong counts (off by one) when unloading regions' to 0.94 (Srikanth Srungarapu) (tedyu: rev 1587762)

        • /hbase/branches/0.94/bin/region_mover.rb
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1348 (See https://builds.apache.org/job/HBase-0.94/1348/ ) HBASE-10991 Port HBASE-10639 'Unload script displays wrong counts (off by one) when unloading regions' to 0.94 (Srikanth Srungarapu) (tedyu: rev 1587762) /hbase/branches/0.94/bin/region_mover.rb
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-security #467 (See https://builds.apache.org/job/HBase-0.94-security/467/)
        HBASE-10991 Port HBASE-10639 'Unload script displays wrong counts (off by one) when unloading regions' to 0.94 (Srikanth Srungarapu) (tedyu: rev 1587762)

        • /hbase/branches/0.94/bin/region_mover.rb
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #467 (See https://builds.apache.org/job/HBase-0.94-security/467/ ) HBASE-10991 Port HBASE-10639 'Unload script displays wrong counts (off by one) when unloading regions' to 0.94 (Srikanth Srungarapu) (tedyu: rev 1587762) /hbase/branches/0.94/bin/region_mover.rb
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #71 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/71/)
        HBASE-10991 Port HBASE-10639 'Unload script displays wrong counts (off by one) when unloading regions' to 0.94 (Srikanth Srungarapu) (tedyu: rev 1587762)

        • /hbase/branches/0.94/bin/region_mover.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #71 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/71/ ) HBASE-10991 Port HBASE-10639 'Unload script displays wrong counts (off by one) when unloading regions' to 0.94 (Srikanth Srungarapu) (tedyu: rev 1587762) /hbase/branches/0.94/bin/region_mover.rb
        Hide
        Ted Yu added a comment -

        I created HBASE-10991 for the backport.

        Show
        Ted Yu added a comment - I created HBASE-10991 for the backport.
        Hide
        Srikanth Srungarapu added a comment -

        Uploading the patch for 0.94 branch as the previous patch is for 0.98, 0.99 and trunk

        Show
        Srikanth Srungarapu added a comment - Uploading the patch for 0.94 branch as the previous patch is for 0.98, 0.99 and trunk
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #223 (See https://builds.apache.org/job/hbase-0.96-hadoop2/223/)
        HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573680)

        • /hbase/branches/0.96/bin/region_mover.rb
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #223 (See https://builds.apache.org/job/hbase-0.96-hadoop2/223/ ) HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573680) /hbase/branches/0.96/bin/region_mover.rb
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #106 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/106/)
        HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573678)

        • /hbase/trunk/bin/region_mover.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #106 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/106/ ) HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573678) /hbase/trunk/bin/region_mover.rb
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4973 (See https://builds.apache.org/job/HBase-TRUNK/4973/)
        HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573678)

        • /hbase/trunk/bin/region_mover.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4973 (See https://builds.apache.org/job/HBase-TRUNK/4973/ ) HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573678) /hbase/trunk/bin/region_mover.rb
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96 #323 (See https://builds.apache.org/job/hbase-0.96/323/)
        HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573680)

        • /hbase/branches/0.96/bin/region_mover.rb
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #323 (See https://builds.apache.org/job/hbase-0.96/323/ ) HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573680) /hbase/branches/0.96/bin/region_mover.rb
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #195 (See https://builds.apache.org/job/HBase-0.98/195/)
        HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573679)

        • /hbase/branches/0.98/bin/region_mover.rb
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #195 (See https://builds.apache.org/job/HBase-0.98/195/ ) HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573679) /hbase/branches/0.98/bin/region_mover.rb
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #183 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/183/)
        HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573679)

        • /hbase/branches/0.98/bin/region_mover.rb
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #183 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/183/ ) HBASE-10639 Unload script displays wrong counts (off by one) when unloading regions (Srikanth Srungarapu) (jmhsieh: rev 1573679) /hbase/branches/0.98/bin/region_mover.rb
        Hide
        Jonathan Hsieh added a comment -

        looks good to me. Thanks Srikanth! committed to 0.96/0.98/trunk.

        Show
        Jonathan Hsieh added a comment - looks good to me. Thanks Srikanth! committed to 0.96/0.98/trunk.
        Hide
        Ted Yu added a comment -

        +1

        Show
        Ted Yu added a comment - +1
        Hide
        Srikanth Srungarapu added a comment -

        Uploading new patch to get rid off the references to HRegionServer.java present in the previous patch.

        Show
        Srikanth Srungarapu added a comment - Uploading new patch to get rid off the references to HRegionServer.java present in the previous patch.
        Hide
        Srikanth Srungarapu added a comment -

        The changes to HRegionServer.java are not intended. The git diff command is unnecessarily generating these changes.

        Show
        Srikanth Srungarapu added a comment - The changes to HRegionServer.java are not intended. The git diff command is unnecessarily generating these changes.
        Hide
        Ted Yu added a comment -

        Is the change in HRegionServer.java intentional ?

        Show
        Ted Yu added a comment - Is the change in HRegionServer.java intentional ?

          People

          • Assignee:
            Srikanth Srungarapu
            Reporter:
            Srikanth Srungarapu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development