HBase
  1. HBase
  2. HBASE-10606

Bad timeout in RpcRetryingCaller#callWithRetries w/o parameters

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.99.0
    • Fix Version/s: 0.99.0
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When we call this method w/o parameters, we don't take into account the configuration, but use the hardcoded default (Integer.MAX).

      If someone was relying on having an infinite timeout whatever the setting, fixing this bug will cause him a surprise. But there is no magic...

      1. 10606.v1.patch
        13 kB
        Nicolas Liochon
      2. 10606.v2.patch
        21 kB
        Nicolas Liochon
      3. 10606.v4.patch
        25 kB
        Nicolas Liochon

        Activity

        Nicolas Liochon created issue -
        Nicolas Liochon made changes -
        Field Original Value New Value
        Description When we call this method w/o parameters, we don't take into account the configuration, but use the hardcoded default (Integer.MAX).

        As well, this class can be reused, in such case we will get the values of the previous callTimeout.

        If someone was relying on having an infinite timeout whatever the setting, fixing this bug will cause him a surprise. But there is no magic...
        When we call this method w/o parameters, we don't take into account the configuration, but use the hardcoded default (Integer.MAX).

        If someone was relying on having an infinite timeout whatever the setting, fixing this bug will cause him a surprise. But there is no magic...
        Nicolas Liochon made changes -
        Attachment 10606.v1.patch [ 12630981 ]
        Nicolas Liochon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Nicolas Liochon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Nicolas Liochon made changes -
        Attachment 10606.v2.patch [ 12630987 ]
        Nicolas Liochon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Nicolas Liochon made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Nicolas Liochon made changes -
        Attachment 10606.v4.patch [ 12631217 ]
        Nicolas Liochon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Nicolas Liochon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Enis Soztutar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Nicolas Liochon
            Reporter:
            Nicolas Liochon
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development