[HBASE-10539] HRegion.addAndGetGlobalMemstoreSize returns previous size

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.96.2, 0.98.1, 0.99.0, 0.94.17
• Component/s: regionserver
• Assignee: Honghua Feng
• Reporter: Honghua Feng
• Created: 14/Feb/14 15:31
• Updated: 26/Feb/14 04:45
• Resolved: 18/Feb/14 19:27

Description

HRegion.addAndGetGlobalMemstoreSize(addedSize) is called once some write succeeds and 'addedSize' is the size of the edits newly put to the memstore, the returned value of HRegion.addAndGetGlobalMemstoreSize(addedSize) is then checked against the flush threshold to determine if a flush for the region should be triggered.

By design the returned value should be the updated memstore size after adding 'addedSize', but current implementation uses this.memstoreSize.getAndAdd which returns the previous size before adding, actually 'addAndGet' rather than 'getAndAdd' should be used here.