HBase
  1. HBase
  2. HBASE-10514

Forward port HBASE-10466, possible data loss when failed flushes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.96.2, 0.98.1, 0.99.0, 0.94.18
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Critical data loss issues that we need to ensure are not in branches beyond 0.89fb. Assigning myself.

      1. 10514v6.098.txt
        74 kB
        stack
      2. 10514v5.txt
        81 kB
        stack
      3. 10514v4.txt
        81 kB
        stack
      4. 10514v3.txt
        51 kB
        stack
      5. 10514v3.txt
        51 kB
        stack
      6. 10514v2.txt
        51 kB
        stack
      7. 10514.txt
        50 kB
        stack
      8. 10154v94.txt
        9 kB
        stack
      9. 10154v4.096.txt
        75 kB
        stack

        Issue Links

          Activity

          Hide
          Andrew Purtell added a comment -

          10464 and ... ?

          Show
          Andrew Purtell added a comment - 10464 and ... ?
          Hide
          stack added a comment -

          oops. fixed.

          Show
          stack added a comment - oops. fixed.
          Hide
          stack added a comment -

          Making blocker on 0.96.2 which I'm trying to do now.

          Show
          stack added a comment - Making blocker on 0.96.2 which I'm trying to do now.
          Hide
          Andrew Purtell added a comment -

          These should go into 0.98.0 then too? No sense releasing something with available fixes for data loss bugs.

          Show
          Andrew Purtell added a comment - These should go into 0.98.0 then too? No sense releasing something with available fixes for data loss bugs.
          Hide
          Lars Hofhansl added a comment -

          Whoa. Not good. Needs to be in 0.94 for sure.

          Show
          Lars Hofhansl added a comment - Whoa. Not good. Needs to be in 0.94 for sure.
          Hide
          Lars Hofhansl added a comment -

          Looks like we cover HBASE-10464 already (checked 0.94). HRegionServer.openRegion(...) calls checkOpen() first, which checks this.stopped || this.abortRequested. If anything we might need to add a check for stopping there.

          I am not sure I follow HBASE-10466 completely.

          Show
          Lars Hofhansl added a comment - Looks like we cover HBASE-10464 already (checked 0.94). HRegionServer.openRegion(...) calls checkOpen() first, which checks this.stopped || this.abortRequested. If anything we might need to add a check for stopping there. I am not sure I follow HBASE-10466 completely.
          Hide
          ramkrishna.s.vasudevan added a comment -

          Is HBASE-10466 someway related to HBASE-5568?

          Show
          ramkrishna.s.vasudevan added a comment - Is HBASE-10466 someway related to HBASE-5568 ?
          Hide
          Lars Hofhansl added a comment -

          Looks similar indeed. I was having a quick look at the code in 0.94 and couldn't make out anything wrong with it, offhand (didn't post that before, because I did not want to look like idiot if I was wrong - and I might yet be wrong )

          Show
          Lars Hofhansl added a comment - Looks similar indeed. I was having a quick look at the code in 0.94 and couldn't make out anything wrong with it, offhand (didn't post that before, because I did not want to look like idiot if I was wrong - and I might yet be wrong )
          Hide
          stack added a comment -

          We do not need HBASE-10464. I took a look. We spawn a thread to open regions. The open handler already has this check for stopping or stopped regionserver host before we add region to online regions list. We should be good.

          Show
          stack added a comment - We do not need HBASE-10464 . I took a look. We spawn a thread to open regions. The open handler already has this check for stopping or stopped regionserver host before we add region to online regions list. We should be good.
          Hide
          Lars Hofhansl added a comment -

          Lemme change the blocker status. I don't think this is a block for 0.94.17.

          Show
          Lars Hofhansl added a comment - Lemme change the blocker status. I don't think this is a block for 0.94.17.
          Hide
          stack added a comment -

          I missed your comments lads. Yeah, don't need hbase-10464. I'm at 10466 now. Will report back. Had it as blocker for 0.96.2 only so I'd look at it.

          Show
          stack added a comment - I missed your comments lads. Yeah, don't need hbase-10464. I'm at 10466 now. Will report back. Had it as blocker for 0.96.2 only so I'd look at it.
          Hide
          stack added a comment -

          HBASE-10466 is different to HBASE-5568. As I read it, we could be carrying an extra snapshot if failed flush. It does not look like it gets cleared flushed out on subsequent flush calls. Instead we see:

              if (!this.snapshot.isEmpty()) {
                LOG.warn("Snapshot called again without clearing previous. " +
                    "Doing nothing. Another ongoing flush or did we fail last attempt?");
          

          Will report back.

          Show
          stack added a comment - HBASE-10466 is different to HBASE-5568 . As I read it, we could be carrying an extra snapshot if failed flush. It does not look like it gets cleared flushed out on subsequent flush calls. Instead we see: if (! this .snapshot.isEmpty()) { LOG.warn( "Snapshot called again without clearing previous. " + "Doing nothing. Another ongoing flush or did we fail last attempt?" ); Will report back.
          Hide
          Lars Hofhansl added a comment -

          <ping>

          Show
          Lars Hofhansl added a comment - <ping>
          Hide
          stack added a comment -

          Thanks Lars Hofhansl Pinging myself now.

          Show
          stack added a comment - Thanks Lars Hofhansl Pinging myself now.
          Hide
          stack added a comment -

          Writing tests to demo the "Bugs" listed at head of HBASE-10466. We are messing up the heap calculation sizes on failed flush for sure.

          Show
          stack added a comment - Writing tests to demo the "Bugs" listed at head of HBASE-10466 . We are messing up the heap calculation sizes on failed flush for sure.
          Hide
          stack added a comment -

          Patch is forward-port of the core of HBASE-10466 with added unit tests around memory accounting in face of flush failures in TestHRegion but also in TestStore. Has a bit of cleanup of TestStore making it junit4 while was in here.

          Show
          stack added a comment - Patch is forward-port of the core of HBASE-10466 with added unit tests around memory accounting in face of flush failures in TestHRegion but also in TestStore. Has a bit of cleanup of TestStore making it junit4 while was in here.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12633410/10514.txt
          against trunk revision .
          ATTACHMENT ID: 12633410

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.io.TestHeapSize

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633410/10514.txt against trunk revision . ATTACHMENT ID: 12633410 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.TestHeapSize Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8925//console This message is automatically generated.
          Hide
          stack added a comment -

          Unit test fix.

          Show
          stack added a comment - Unit test fix.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12633446/10514v2.txt
          against trunk revision .
          ATTACHMENT ID: 12633446

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestMultiParallel
          org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed
          org.apache.hadoop.hbase.regionserver.wal.TestWALReplay
          org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay
          org.apache.hadoop.hbase.regionserver.TestParallelPut

          -1 core zombie tests. There are 2 zombie test(s): at org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels.testVisibilityLabelsOnKillingOfRSContainingLabelsTable(TestVisibilityLabels.java:315)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633446/10514v2.txt against trunk revision . ATTACHMENT ID: 12633446 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed org.apache.hadoop.hbase.regionserver.wal.TestWALReplay org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay org.apache.hadoop.hbase.regionserver.TestParallelPut -1 core zombie tests . There are 2 zombie test(s): at org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels.testVisibilityLabelsOnKillingOfRSContainingLabelsTable(TestVisibilityLabels.java:315) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8927//console This message is automatically generated.
          Hide
          stack added a comment -

          Fix assert that shouldn't be asserting on server abort.

          Show
          stack added a comment - Fix assert that shouldn't be asserting on server abort.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12633477/10514v3.txt
          against trunk revision .
          ATTACHMENT ID: 12633477

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 3 zombie test(s): at org.apache.maven.surefire.junitcore.ConcurrentReporterManager.testSetCompleted(ConcurrentReporterManager.java:78)
          at org.apache.maven.surefire.junitcore.JUnitCoreRunListener.testRunFinished(JUnitCoreRunListener.java:61)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633477/10514v3.txt against trunk revision . ATTACHMENT ID: 12633477 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 3 zombie test(s): at org.apache.maven.surefire.junitcore.ConcurrentReporterManager.testSetCompleted(ConcurrentReporterManager.java:78) at org.apache.maven.surefire.junitcore.JUnitCoreRunListener.testRunFinished(JUnitCoreRunListener.java:61) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8928//console This message is automatically generated.
          Hide
          stack added a comment -

          Retry.

          Show
          stack added a comment - Retry.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12633507/10514v3.txt
          against trunk revision .
          ATTACHMENT ID: 12633507

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 2 zombie test(s): at org.apache.maven.surefire.junitcore.ConcurrentReporterManager.testSetCompleted(ConcurrentReporterManager.java:78)
          at org.apache.maven.surefire.junitcore.JUnitCoreRunListener.testRunFinished(JUnitCoreRunListener.java:61)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633507/10514v3.txt against trunk revision . ATTACHMENT ID: 12633507 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 2 zombie test(s): at org.apache.maven.surefire.junitcore.ConcurrentReporterManager.testSetCompleted(ConcurrentReporterManager.java:78) at org.apache.maven.surefire.junitcore.JUnitCoreRunListener.testRunFinished(JUnitCoreRunListener.java:61) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8930//console This message is automatically generated.
          Hide
          stack added a comment -

          My added tests are not closing the WAL (and making zombies). Even fixing that, there are some stragglers still. Looking.

          Show
          stack added a comment - My added tests are not closing the WAL (and making zombies). Even fixing that, there are some stragglers still. Looking.
          Hide
          stack added a comment -

          Try now. I wasn't closing the WAL that was being created when a region was created.

          TestHRegion is a little fragile. testDurability was failing on mac os x for me when doing fsync call. Would just hang. Passes on linux. Lets see how this does up against hadoopqa.

          Show
          stack added a comment - Try now. I wasn't closing the WAL that was being created when a region was created. TestHRegion is a little fragile. testDurability was failing on mac os x for me when doing fsync call. Would just hang. Passes on linux. Lets see how this does up against hadoopqa.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12634093/10514v4.txt
          against trunk revision .
          ATTACHMENT ID: 12634093

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634093/10514v4.txt against trunk revision . ATTACHMENT ID: 12634093 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8955//console This message is automatically generated.
          Hide
          Anoop Sam John added a comment -
          -    long flushsize = this.memstoreSize.get();
          +    long totalFlushableSize = 0;
               status.setStatus("Preparing to flush by snapshotting stores");
               List<StoreFlushContext> storeFlushCtxs = new ArrayList<StoreFlushContext>(stores.size());
               long flushSeqId = -1L;
          @@ -1630,6 +1649,7 @@ public class HRegion implements HeapSize { // , Writable{
                 }
           
                 for (Store s : stores.values()) {
          +        totalFlushableSize += s.getFlushableSize();
          
          ...
          
          -      this.addAndGetGlobalMemstoreSize(-flushsize);
          +      this.addAndGetGlobalMemstoreSize(-totalFlushableSize);
          
          

          So when one snapshot was already in place in MemStore and we again undergo a flush request, now we dont decrease by the begin time memstoreSize. But we check with all MemStores.

          Now the MemStore returns the previous snapshot's size when one was in place. The snapshot() to MemStore won't take new snaphot when already a snapshot is in place.

          This can make we decrease the memstore's snapshot size 2 times from this global memstore size? (When a flush requested while another was in progress)

          Show
          Anoop Sam John added a comment - - long flushsize = this .memstoreSize.get(); + long totalFlushableSize = 0; status.setStatus( "Preparing to flush by snapshotting stores" ); List<StoreFlushContext> storeFlushCtxs = new ArrayList<StoreFlushContext>(stores.size()); long flushSeqId = -1L; @@ -1630,6 +1649,7 @@ public class HRegion implements HeapSize { // , Writable{ } for (Store s : stores.values()) { + totalFlushableSize += s.getFlushableSize(); ... - this .addAndGetGlobalMemstoreSize(-flushsize); + this .addAndGetGlobalMemstoreSize(-totalFlushableSize); So when one snapshot was already in place in MemStore and we again undergo a flush request, now we dont decrease by the begin time memstoreSize. But we check with all MemStores. Now the MemStore returns the previous snapshot's size when one was in place. The snapshot() to MemStore won't take new snaphot when already a snapshot is in place. This can make we decrease the memstore's snapshot size 2 times from this global memstore size? (When a flush requested while another was in progress)
          Hide
          stack added a comment -

          Thanks for the review Anoop Sam John

          So when one snapshot was already in place in MemStore and we again undergo a flush request, now we dont decrease by the begin time memstoreSize. But we check with all MemStores.

          Sorry. Having trouble parsing the above. Are you asking a question. Yes, if a snapshot is in place already, and we call flush – we flush the existing snapshot only... that is how this stuff has always worked but our memory accounting did not reflect this... it would subtrace memstore size even though memstore was in place still post flush when existing snapshot.

          Now the MemStore returns the previous snapshot's size when one was in place. The snapshot() to MemStore won't take new snaphot when already a snapshot is in place.

          Yes. This is how it works. This patch does not change that. This patch just makes our memory accounting align w/ how snapshotting/flush actually works.

          ....When a flush requested while another was in progress....

          Again pardon me for not following.... Only one flush can be going on at a time (you can make a request any time). I am not seeing how we can decrement twice the flush size.

          I can add new tests no problem if you can come up with a scenario.

          Show
          stack added a comment - Thanks for the review Anoop Sam John So when one snapshot was already in place in MemStore and we again undergo a flush request, now we dont decrease by the begin time memstoreSize. But we check with all MemStores. Sorry. Having trouble parsing the above. Are you asking a question. Yes, if a snapshot is in place already, and we call flush – we flush the existing snapshot only... that is how this stuff has always worked but our memory accounting did not reflect this... it would subtrace memstore size even though memstore was in place still post flush when existing snapshot. Now the MemStore returns the previous snapshot's size when one was in place. The snapshot() to MemStore won't take new snaphot when already a snapshot is in place. Yes. This is how it works. This patch does not change that. This patch just makes our memory accounting align w/ how snapshotting/flush actually works. ....When a flush requested while another was in progress.... Again pardon me for not following.... Only one flush can be going on at a time (you can make a request any time). I am not seeing how we can decrement twice the flush size. I can add new tests no problem if you can come up with a scenario.
          Hide
          Andrew Purtell added a comment -

          Could this make a 0.98.1 RC this week?

          Show
          Andrew Purtell added a comment - Could this make a 0.98.1 RC this week?
          Hide
          stack added a comment -

          Andrew Purtell Just need review.

          Show
          stack added a comment - Andrew Purtell Just need review.
          Hide
          Andrew Purtell added a comment -

          Just need review.

          Jetlagged, back tomorrow.

          Show
          Andrew Purtell added a comment - Just need review. Jetlagged, back tomorrow.
          Hide
          Anoop Sam John added a comment -

          Only one flush can be going on at a time (you can make a request any time).

          This created doubt for me

          -    if (!abort && !wasFlushing && worthPreFlushing()) {
          +    if (!abort && worthPreFlushing()) {
          

          Checking more closely now Stack.

          Show
          Anoop Sam John added a comment - Only one flush can be going on at a time (you can make a request any time). This created doubt for me - if (!abort && !wasFlushing && worthPreFlushing()) { + if (!abort && worthPreFlushing()) { Checking more closely now Stack.
          Hide
          Anoop Sam John added a comment -

          Oh.. whatever doubt was there in my mind seems not an issue.. Reading these lines

          synchronized (writestate) {
                // Disable compacting and flushing by background threads for this
                // region.
                writestate.writesEnabled = false;
                LOG.debug("Closing " + this + ": disabling compactions & flushes");
                waitForFlushesAndCompactions();
              }
              // If we were not just flushing, is it worth doing a preflush...one
              // that will clear out of the bulk of the memstore before we put up
              // the close flag?
              if (!abort && worthPreFlushing()) {
          
          Show
          Anoop Sam John added a comment - Oh.. whatever doubt was there in my mind seems not an issue.. Reading these lines synchronized (writestate) { // Disable compacting and flushing by background threads for this // region. writestate.writesEnabled = false ; LOG.debug( "Closing " + this + ": disabling compactions & flushes" ); waitForFlushesAndCompactions(); } // If we were not just flushing, is it worth doing a preflush...one // that will clear out of the bulk of the memstore before we put up // the close flag? if (!abort && worthPreFlushing()) {
          Hide
          Lars Hofhansl added a comment -

          lgtm

          This is a bit scary:

          +        int flushCount = 0;
          +        while (this.getMemstoreSize().get() > 0) {
          +          try {
          +            if (flushCount++ > 0) {
          +              LOG.info("Running extra flush (carrying snapshot?) " + this);
          +            }
          +            internalFlushcache(status);
          +          } catch (IOException ioe) {
          +            status.setStatus("Failed flush " + this + ", putting online again");
          +            synchronized (writestate) {
          +              writestate.writesEnabled = true;
          +            }
          +            // Have to throw to upper layers.  I can't abort server from here.
          +            throw ioe;
          +          }
          +        }
          

          We better be sure we never get the accounting wrong, or we'll see an endless loop. Will the loop ever have more than two iterations?
          If not, we might want to limit the number of iterations to two
          for (int flushCount = 0; flushCount < 2 && this.getMemstoreSize().get() > 0; flushCount++)
          or something like that...?

          Show
          Lars Hofhansl added a comment - lgtm This is a bit scary: + int flushCount = 0; + while ( this .getMemstoreSize().get() > 0) { + try { + if (flushCount++ > 0) { + LOG.info( "Running extra flush (carrying snapshot?) " + this ); + } + internalFlushcache(status); + } catch (IOException ioe) { + status.setStatus( "Failed flush " + this + ", putting online again" ); + synchronized (writestate) { + writestate.writesEnabled = true ; + } + // Have to throw to upper layers. I can't abort server from here. + throw ioe; + } + } We better be sure we never get the accounting wrong, or we'll see an endless loop. Will the loop ever have more than two iterations? If not, we might want to limit the number of iterations to two for (int flushCount = 0; flushCount < 2 && this.getMemstoreSize().get() > 0; flushCount++) or something like that...?
          Hide
          stack added a comment -

          Ok. Let me do that and abort the server if we cycle more than 3 times.... Thanks Anoop Sam John and Lars Hofhansl

          Show
          stack added a comment - Ok. Let me do that and abort the server if we cycle more than 3 times.... Thanks Anoop Sam John and Lars Hofhansl
          Hide
          stack added a comment -

          What I am going to commit.

          Show
          stack added a comment - What I am going to commit.
          Hide
          Andrew Purtell added a comment -

          v5 lgtm. Like the new tests.

          Show
          Andrew Purtell added a comment - v5 lgtm. Like the new tests.
          Hide
          stack added a comment -

          What I committed to 0.98 and to 0.96... small diffs.

          Show
          stack added a comment - What I committed to 0.98 and to 0.96... small diffs.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12634589/10154v4.096.txt
          against trunk revision .
          ATTACHMENT ID: 12634589

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8981//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634589/10154v4.096.txt against trunk revision . ATTACHMENT ID: 12634589 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8981//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          +1

          Show
          Lars Hofhansl added a comment - +1
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.96-hadoop2 #237 (See https://builds.apache.org/job/hbase-0.96-hadoop2/237/)
          HBASE-10514 Forward port HBASE-10466, possible data loss when failed flushes (stack: rev 1577386)

          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #237 (See https://builds.apache.org/job/hbase-0.96-hadoop2/237/ ) HBASE-10514 Forward port HBASE-10466 , possible data loss when failed flushes (stack: rev 1577386) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5007 (See https://builds.apache.org/job/HBase-TRUNK/5007/)
          HBASE-10514 Forward port HBASE-10466, possible data loss when failed flushes (stack: rev 1577353)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5007 (See https://builds.apache.org/job/HBase-TRUNK/5007/ ) HBASE-10514 Forward port HBASE-10466 , possible data loss when failed flushes (stack: rev 1577353) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #227 (See https://builds.apache.org/job/HBase-0.98/227/)
          HBASE-10514 Forward port HBASE-10466, possible data loss when failed flushes (stack: rev 1577371)

          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java
          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java
          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #227 (See https://builds.apache.org/job/HBase-0.98/227/ ) HBASE-10514 Forward port HBASE-10466 , possible data loss when failed flushes (stack: rev 1577371) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Hide
          stack added a comment -

          Want a 0.94 patch Lars Hofhansl ?

          Show
          stack added a comment - Want a 0.94 patch Lars Hofhansl ?
          Hide
          Lars Hofhansl added a comment -

          Yes sir.

          Show
          Lars Hofhansl added a comment - Yes sir.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #213 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/213/)
          HBASE-10514 Forward port HBASE-10466, possible data loss when failed flushes (stack: rev 1577371)

          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java
          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java
          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #213 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/213/ ) HBASE-10514 Forward port HBASE-10466 , possible data loss when failed flushes (stack: rev 1577371) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Hide
          stack added a comment -

          Patch for 0.94. Does not include tests.

          Show
          stack added a comment - Patch for 0.94. Does not include tests.
          Hide
          stack added a comment -

          Hmm.. Something wrong w/ TestHRegion? If I do below...

          MAVEN_OPTS=" -Xmx3g" ~/bin/mvn/bin/mvn test -Dtest=TestHRegion

          It just complains nothing to run, with or without my patch.

          Show
          stack added a comment - Hmm.. Something wrong w/ TestHRegion? If I do below... MAVEN_OPTS=" -Xmx3g" ~/bin/mvn/bin/mvn test -Dtest=TestHRegion It just complains nothing to run, with or without my patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12634644/10154v94.txt
          against trunk revision .
          ATTACHMENT ID: 12634644

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8985//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634644/10154v94.txt against trunk revision . ATTACHMENT ID: 12634644 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8985//console This message is automatically generated.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96 #346 (See https://builds.apache.org/job/hbase-0.96/346/)
          HBASE-10514 Forward port HBASE-10466, possible data loss when failed flushes (stack: rev 1577386)

          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #346 (See https://builds.apache.org/job/hbase-0.96/346/ ) HBASE-10514 Forward port HBASE-10466 , possible data loss when failed flushes (stack: rev 1577386) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Hide
          Yu Li added a comment -

          Hi stack,

          Patch for 0.94. Does not include tests

          Will the v94 patch be integrated into 0.94 branch w/o tests? Or you're still working on it?

          Show
          Yu Li added a comment - Hi stack , Patch for 0.94. Does not include tests Will the v94 patch be integrated into 0.94 branch w/o tests? Or you're still working on it?
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #117 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/117/)
          HBASE-10514 Forward port HBASE-10466, possible data loss when failed flushes (stack: rev 1577353)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #117 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/117/ ) HBASE-10514 Forward port HBASE-10466 , possible data loss when failed flushes (stack: rev 1577353) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionBusyWait.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          Hide
          stack added a comment -

          Yu Li Applying to 0.94 w/o backporting the tests.

          I tested the patch by running test suite. I could not figure how to make just TestHRegion work. Patch seems to work. Let me commit.

          Show
          stack added a comment - Yu Li Applying to 0.94 w/o backporting the tests. I tested the patch by running test suite. I could not figure how to make just TestHRegion work. Patch seems to work. Let me commit.
          Hide
          stack added a comment -

          Resolving. Committed to all branches 0.94-0.99.

          Show
          stack added a comment - Resolving. Committed to all branches 0.94-0.99.
          Hide
          Andrew Purtell added a comment -

          I tested the patch by running test suite. I could not figure how to make just TestHRegion work.

          Maybe 'mvn test -PlocalTests -Dtest=TestHRegion'

          Show
          Andrew Purtell added a comment - I tested the patch by running test suite. I could not figure how to make just TestHRegion work. Maybe 'mvn test -PlocalTests -Dtest=TestHRegion'
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.96-hadoop2 #239 (See https://builds.apache.org/job/hbase-0.96-hadoop2/239/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577667)

          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #239 (See https://builds.apache.org/job/hbase-0.96-hadoop2/239/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577667) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.96 #349 (See https://builds.apache.org/job/hbase-0.96/349/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577667)

          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.96 #349 (See https://builds.apache.org/job/hbase-0.96/349/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577667) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98 #232 (See https://builds.apache.org/job/HBase-0.98/232/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577666)

          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98 #232 (See https://builds.apache.org/job/HBase-0.98/232/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577666) /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5012 (See https://builds.apache.org/job/HBase-TRUNK/5012/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577664)

          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5012 (See https://builds.apache.org/job/HBase-TRUNK/5012/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577664) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #217 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/217/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577666)

          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #217 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/217/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577666) /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #118 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/118/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577664)

          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #118 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/118/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577664) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Lars Hofhansl added a comment -
          [ERROR] COMPILATION ERROR : 
          [INFO] -------------------------------------------------------------
          [ERROR] /home/jenkins/jenkins-slave/workspace/HBase-0.94/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java:[3265,15] cannot find symbol
          symbol  : class DroppedSnapshotException
          location: class org.apache.hadoop.hbase.regionserver.TestHRegion
          

          Probably from this. Will create an addendum shortly.

          Show
          Lars Hofhansl added a comment - [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /home/jenkins/jenkins-slave/workspace/HBase-0.94/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java:[3265,15] cannot find symbol symbol : class DroppedSnapshotException location: class org.apache.hadoop.hbase.regionserver.TestHRegion Probably from this. Will create an addendum shortly.
          Hide
          Lars Hofhansl added a comment -

          Done.

          Show
          Lars Hofhansl added a comment - Done.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94.18-security #7 (See https://builds.apache.org/job/HBase-0.94.18-security/7/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784)

          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
            HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782)
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94.18-security #7 (See https://builds.apache.org/job/HBase-0.94.18-security/7/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.94-security #447 (See https://builds.apache.org/job/HBase-0.94-security/447/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784)

          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
            HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782)
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.94-security #447 (See https://builds.apache.org/job/HBase-0.94-security/447/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94.18 #17 (See https://builds.apache.org/job/HBase-0.94.18/17/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784)

          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
            HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782)
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94.18 #17 (See https://builds.apache.org/job/HBase-0.94.18/17/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.94 #1328 (See https://builds.apache.org/job/HBase-0.94/1328/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784)

          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
            HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782)
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.94 #1328 (See https://builds.apache.org/job/HBase-0.94/1328/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #57 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/57/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784)

          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
            HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782)
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #57 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/57/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.94-JDK7 #91 (See https://builds.apache.org/job/HBase-0.94-JDK7/91/)
          HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784)

          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
            HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782)
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.94-JDK7 #91 (See https://builds.apache.org/job/HBase-0.94-JDK7/91/ ) HBASE-10751 TestHRegion testWritesWhileScanning occasional fail since HBASE-10514 went in (stack: rev 1577784) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java HBASE-10514 Addendum; fixing missing import (larsh: rev 1577782) /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

            People

            • Assignee:
              stack
              Reporter:
              stack
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development