HBase
  1. HBase
  2. HBASE-10493

InclusiveStopFilter#filterKeyValue() should perform filtering on row key

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.96.2, 0.98.1, 0.99.0, 0.94.17
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      InclusiveStopFilter inherits filterKeyValue() from FilterBase which always returns ReturnCode.INCLUDE

      InclusiveStopFilter#filterKeyValue() should be consistent with filtering on row key.

      1. 10493-0.94.txt
        3 kB
        Ted Yu
      2. 10493-v1.txt
        3 kB
        Ted Yu
      3. 10493-v2.txt
        3 kB
        Ted Yu

        Activity

        Hide
        Lars Hofhansl added a comment -

        Can we hint NEXT_ROW? Also I'd go with a simpler test as suggested n HBASE-10485.

        Show
        Lars Hofhansl added a comment - Can we hint NEXT_ROW? Also I'd go with a simpler test as suggested n HBASE-10485 .
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12628101/10493-v1.txt
        against trunk revision .
        ATTACHMENT ID: 12628101

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8654//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12628101/10493-v1.txt against trunk revision . ATTACHMENT ID: 12628101 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8654//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Will post new patch once HBASE-10485 is resolved.

        Show
        Ted Yu added a comment - Will post new patch once HBASE-10485 is resolved.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12628124/10493-v2.txt
        against trunk revision .
        ATTACHMENT ID: 12628124

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12628124/10493-v2.txt against trunk revision . ATTACHMENT ID: 12628124 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8657//console This message is automatically generated.
        Hide
        Lars Hofhansl added a comment -

        +1

        Show
        Lars Hofhansl added a comment - +1
        Hide
        Ted Yu added a comment -

        Integrated to 0.98 and trunk.

        Thanks Lars for the reviews.

        Show
        Ted Yu added a comment - Integrated to 0.98 and trunk. Thanks Lars for the reviews.
        Hide
        Lars Hofhansl added a comment -

        This is important correctness stuff that should be in 0.94 and 0.96 as well.

        Show
        Lars Hofhansl added a comment - This is important correctness stuff that should be in 0.94 and 0.96 as well.
        Hide
        stack added a comment -

        Agree

        Show
        stack added a comment - Agree
        Hide
        Ted Yu added a comment -

        Patch for 0.94 coming

        Show
        Ted Yu added a comment - Patch for 0.94 coming
        Hide
        Lars Hofhansl added a comment -

        +1 on 0.94.
        I assume the trunk patch applies to 0.96. I'll handle HBASE-10485 after this has gone in.

        Show
        Lars Hofhansl added a comment - +1 on 0.94. I assume the trunk patch applies to 0.96. I'll handle HBASE-10485 after this has gone in.
        Hide
        Ted Yu added a comment -

        Integrated to 0.94 and 0.96

        Show
        Ted Yu added a comment - Integrated to 0.94 and 0.96
        Hide
        stack added a comment -

        Thanks Ted Yu

        Show
        stack added a comment - Thanks Ted Yu
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-security #407 (See https://builds.apache.org/job/HBase-0.94-security/407/)
        HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567426)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #407 (See https://builds.apache.org/job/HBase-0.94-security/407/ ) HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567426) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #18 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/18/)
        HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567426)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-on-Hadoop-2 #18 (See https://builds.apache.org/job/HBase-0.94-on-Hadoop-2/18/ ) HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567426) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #87 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/87/)
        HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567403)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #87 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/87/ ) HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567403) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4910 (See https://builds.apache.org/job/HBase-TRUNK/4910/)
        HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567403)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4910 (See https://builds.apache.org/job/HBase-TRUNK/4910/ ) HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567403) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #137 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/137/)
        HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567402)

        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #137 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/137/ ) HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567402) /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #149 (See https://builds.apache.org/job/HBase-0.98/149/)
        HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567402)

        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #149 (See https://builds.apache.org/job/HBase-0.98/149/ ) HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567402) /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #200 (See https://builds.apache.org/job/hbase-0.96-hadoop2/200/)
        HBASE-10493 Fix TestFilterList (tedyu: rev 1567418)

        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
          HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key, add test (tedyu: rev 1567416)
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
          HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567414)
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #200 (See https://builds.apache.org/job/hbase-0.96-hadoop2/200/ ) HBASE-10493 Fix TestFilterList (tedyu: rev 1567418) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key, add test (tedyu: rev 1567416) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567414) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94 #1282 (See https://builds.apache.org/job/HBase-0.94/1282/)
        HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567426)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94 #1282 (See https://builds.apache.org/job/HBase-0.94/1282/ ) HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567426) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #289 (See https://builds.apache.org/job/hbase-0.96/289/)
        HBASE-10493 Fix TestFilterList (tedyu: rev 1567418)

        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
          HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key, add test (tedyu: rev 1567416)
        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
          HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567414)
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96 #289 (See https://builds.apache.org/job/hbase-0.96/289/ ) HBASE-10493 Fix TestFilterList (tedyu: rev 1567418) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key, add test (tedyu: rev 1567416) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567414) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.94-JDK7 #46 (See https://builds.apache.org/job/HBase-0.94-JDK7/46/)
        HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567426)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.94-JDK7 #46 (See https://builds.apache.org/job/HBase-0.94-JDK7/46/ ) HBASE-10493 InclusiveStopFilter#filterKeyValue() should perform filtering on row key (tedyu: rev 1567426) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
        Hide
        Lars Hofhansl added a comment -

        So this and HBASE-10485 actually unveil another problem: Import does not call filterRowKey, so the filter is not setup correctly before we call filterKeyValue. This is a problem!
        Ted Yu, stack. So we can either fix Import in all branches or roll these two changes back.
        (but note that Import is already broken for other filters - such as RowFilter - that also relies on filterRowKey to be called first)

        Show
        Lars Hofhansl added a comment - So this and HBASE-10485 actually unveil another problem: Import does not call filterRowKey, so the filter is not setup correctly before we call filterKeyValue. This is a problem! Ted Yu , stack . So we can either fix Import in all branches or roll these two changes back. (but note that Import is already broken for other filters - such as RowFilter - that also relies on filterRowKey to be called first)
        Hide
        Lars Hofhansl added a comment -

        Filed HBASE-10505. This was completely broken in Import. TestImportExport only passed by pure accident.

        Show
        Lars Hofhansl added a comment - Filed HBASE-10505 . This was completely broken in Import. TestImportExport only passed by pure accident.

          People

          • Assignee:
            Ted Yu
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development