Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.99.0
    • Fix Version/s: 0.99.0, hbase-10070
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The code is complex. Here is a set of proposed changes, for trunk:
      1) remove PingInputStream. if rpcTimeout > 0 it just rethrows the exception. I expect that we always have a rpcTimeout. So we can remove the code.
      2) remove the sendPing: instead, just close the connection if it's not used for a while, instead of trying to ping the server.
      3) remove maxIddle time: to avoid the confusion if someone has overwritten the conf.
      4) remove shouldCloseConnection: it was more or less synchronized with closeException. Having a single variable instead of two avoids the synchro
      5) remove lastActivity: instead of trying to have an exact timeout, just kill the connection after some time. lastActivity could be set to wrong values if the server was slow to answer.
      6) hopefully, a better management of the exception; we don't use the close exception of someone else as an input for another one. Same goes for interruption.

      I may have something wrong in the code. I will review it myself again. Feedback welcome, especially on the ping removal: I hope I got all the use cases.

      1. 10490.v6.patch
        34 kB
        Nicolas Liochon
      2. 10490.v5.patch
        34 kB
        Nicolas Liochon
      3. 10490.v3.patch
        33 kB
        Nicolas Liochon
      4. 10490.v2.patch
        31 kB
        Nicolas Liochon
      5. 10490.v1.patch
        30 kB
        Nicolas Liochon

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Nicolas Liochon
              Reporter:
              Nicolas Liochon
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development