HBase
  1. HBase
  2. HBASE-10483

Provide API for retrieving info port when hbase.master.info.port is set to 0

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 0.99.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Adds new method to Admin so clients can ask the master's info port. Also fixes info port display in UI to use what master is actually using rather than display what is Configuration

      {code}
      + /**
      + * Get the info port of the current master if one is available.
      + * @return master info port
      + * @throws IOException
      + */
      + public int getMasterInfoPort() throws IOException;
      {code}
      Show
      Adds new method to Admin so clients can ask the master's info port. Also fixes info port display in UI to use what master is actually using rather than display what is Configuration {code} + /** + * Get the info port of the current master if one is available. + * @return master info port + * @throws IOException + */ + public int getMasterInfoPort() throws IOException; {code}

      Description

      When hbase.master.info.port is set to 0, info port is dynamically determined.

      An API should be provided so that client can retrieve the actual info port.

      1. HBASE-10483-v5.diff
        30 kB
        Liu Shaohui
      2. HBASE-10483-v4.diff
        31 kB
        Liu Shaohui
      3. HBASE-10483-v3.diff
        32 kB
        Liu Shaohui
      4. HBASE-10483-trunk-v2.diff
        24 kB
        Liu Shaohui
      5. HBASE-10483-trunk-v1.diff
        24 kB
        Liu Shaohui

        Issue Links

          Activity

          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.2 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.2 release.
          Hide
          Enis Soztutar added a comment -

          Sorry for coming to this later. I was going over the methods in Admin, and bumped into this. I think we should not have the method Admin.getMasterInfoPort(). The reasoning is that, that method will only return the active master's info port, but not any other detail about the active master. So you have to obtain the hostname of the active master one way, and obtain the info port some other way. That means when the master is failing over etc, it can go out of sync.

          For region server info ports, we did a hacky-ish way of adding the info port to the ServerLoad object. Since master and RS are the same daemon now, their info port is the same? Can we create a follow up jira to either change the method to return the full information for the active master or remove the method and rely on ClusterStatus ?

          Show
          Enis Soztutar added a comment - Sorry for coming to this later. I was going over the methods in Admin, and bumped into this. I think we should not have the method Admin.getMasterInfoPort(). The reasoning is that, that method will only return the active master's info port, but not any other detail about the active master. So you have to obtain the hostname of the active master one way, and obtain the info port some other way. That means when the master is failing over etc, it can go out of sync. For region server info ports, we did a hacky-ish way of adding the info port to the ServerLoad object. Since master and RS are the same daemon now, their info port is the same? Can we create a follow up jira to either change the method to return the full information for the active master or remove the method and rely on ClusterStatus ?
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-1.0 #457 (See https://builds.apache.org/job/HBase-1.0/457/)
          HBASE-10483 Provide API for retrieving info port when hbase.master.info.port is set to 0 (Liu Shaohui) (stack: rev f3a38dcf16e9738da034e0436e8e099ca02e7ece)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
          • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
          • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
          • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperNodeTracker.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressTracker.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • hbase-protocol/src/main/protobuf/ZooKeeper.proto
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #457 (See https://builds.apache.org/job/HBase-1.0/457/ ) HBASE-10483 Provide API for retrieving info port when hbase.master.info.port is set to 0 (Liu Shaohui) (stack: rev f3a38dcf16e9738da034e0436e8e099ca02e7ece) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperNodeTracker.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressTracker.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java hbase-protocol/src/main/protobuf/ZooKeeper.proto
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #5766 (See https://builds.apache.org/job/HBase-TRUNK/5766/)
          HBASE-10483 Provide API for retrieving info port when hbase.master.info.port is set to 0 (Liu Shaohui) (stack: rev fb6c5c7fe8ea5e18209e3a969b49441ada4b25da)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java
          • hbase-protocol/src/main/protobuf/ZooKeeper.proto
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperNodeTracker.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java
          • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressTracker.java
          • hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5766 (See https://builds.apache.org/job/HBase-TRUNK/5766/ ) HBASE-10483 Provide API for retrieving info port when hbase.master.info.port is set to 0 (Liu Shaohui) (stack: rev fb6c5c7fe8ea5e18209e3a969b49441ada4b25da) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java hbase-protocol/src/main/protobuf/ZooKeeper.proto hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperNodeTracker.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/BackupMasterStatusTmpl.jamon hbase-server/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressTracker.java hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
          Hide
          stack added a comment -

          Pushed to branch-1+. Lots of conflicts trying to cherry-pick to 0.98 so passed. Thanks for patch Liu Shaohui

          Show
          stack added a comment - Pushed to branch-1+. Lots of conflicts trying to cherry-pick to 0.98 so passed. Thanks for patch Liu Shaohui
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12681021/HBASE-10483-v5.diff
          against trunk revision .
          ATTACHMENT ID: 12681021

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          -1 checkstyle. The applied patch generated 3786 checkstyle errors (more than the trunk's current 3785 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + "\020\001\022\014\n\010RESIGNED\020\002\022\010\n\004DONE\020\003\022\007\n\003ERR\020\004\">\n\014R" +
          + infoPort = masterAddressTracker == null ? 0 : masterAddressTracker.getBackupMasterInfoPort(serverName);

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12681021/HBASE-10483-v5.diff against trunk revision . ATTACHMENT ID: 12681021 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. -1 checkstyle . The applied patch generated 3786 checkstyle errors (more than the trunk's current 3785 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + "\020\001\022\014\n\010RESIGNED\020\002\022\010\n\004DONE\020\003\022\007\n\003ERR\020\004\">\n\014R" + + infoPort = masterAddressTracker == null ? 0 : masterAddressTracker.getBackupMasterInfoPort(serverName); +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11647//console This message is automatically generated.
          Hide
          Liu Shaohui added a comment -

          Update.
          Thnaks for stack's review.

          Show
          Liu Shaohui added a comment - Update. Thnaks for stack 's review.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12680781/HBASE-10483-v4.diff
          against trunk revision .
          ATTACHMENT ID: 12680781

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 3786 checkstyle errors (more than the trunk's current 3783 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + "\020\001\022\014\n\010RESIGNED\020\002\022\010\n\004DONE\020\003\022\007\n\003ERR\020\004\">\n\014R" +
          + infoPort = masterAddressTracker == null ? 0 : masterAddressTracker.getBackupMasterInfoPort(serverName);

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12680781/HBASE-10483-v4.diff against trunk revision . ATTACHMENT ID: 12680781 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 3786 checkstyle errors (more than the trunk's current 3783 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + "\020\001\022\014\n\010RESIGNED\020\002\022\010\n\004DONE\020\003\022\007\n\003ERR\020\004\">\n\014R" + + infoPort = masterAddressTracker == null ? 0 : masterAddressTracker.getBackupMasterInfoPort(serverName); +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11632//console This message is automatically generated.
          Hide
          Liu Shaohui added a comment -

          Ted Yu
          It seems that the test has been triggered atomaitcally.
          How to start it manually?

          Show
          Liu Shaohui added a comment - Ted Yu It seems that the test has been triggered atomaitcally. How to start it manually?
          Hide
          Liu Shaohui added a comment -

          Update for Ted Yu's review

          Show
          Liu Shaohui added a comment - Update for Ted Yu 's review
          Hide
          Ted Yu added a comment -

          Put some minor comments on review board.
          Please submit to Hadoop QA for test run.

          Show
          Ted Yu added a comment - Put some minor comments on review board. Please submit to Hadoop QA for test run.
          Hide
          Liu Shaohui added a comment -

          A new patch for hbase master.

          • Add info port field to master pb in zk
          • Client, RegionServersand Backup Masters get active master's info port through MasterAddressTracker.

          stack Ted Yu Enis Soztutar
          Please help to review this patch, thx.

          Show
          Liu Shaohui added a comment - A new patch for hbase master. Add info port field to master pb in zk Client, RegionServersand Backup Masters get active master's info port through MasterAddressTracker. stack Ted Yu Enis Soztutar Please help to review this patch, thx.
          Hide
          Liu Shaohui added a comment -

          Ted Yu
          Take it please. Sorry for not finishing it. Thanks.

          Show
          Liu Shaohui added a comment - Ted Yu Take it please. Sorry for not finishing it. Thanks.
          Hide
          Ted Yu added a comment -

          Shaohui:
          If you don't have time, I can come up with new patch.

          Show
          Ted Yu added a comment - Shaohui: If you don't have time, I can come up with new patch.
          Hide
          Liu Shaohui added a comment -

          Ted Yu
          Sorry for leaving this issue so long.
          According to the suggestion of stack and Enis Soztutar, i will add new api to get info port of HMaster rather than putting it in HMaste zk node.

          Show
          Liu Shaohui added a comment - Ted Yu Sorry for leaving this issue so long. According to the suggestion of stack and Enis Soztutar , i will add new api to get info port of HMaster rather than putting it in HMaste zk node.
          Hide
          Ted Yu added a comment -

          Liu Shaohui:
          Do you have time to address review comments ?

          Show
          Ted Yu added a comment - Liu Shaohui : Do you have time to address review comments ?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12629020/HBASE-10483-trunk-v2.diff
          against trunk revision .
          ATTACHMENT ID: 12629020

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629020/HBASE-10483-trunk-v2.diff against trunk revision . ATTACHMENT ID: 12629020 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8701//console This message is automatically generated.
          Hide
          Liu Shaohui added a comment -

          Add null check in MasterAddressTracker for no master scenario.

          All failed tests pass in local machine. Please retrigger the test, thx.

          Show
          Liu Shaohui added a comment - Add null check in MasterAddressTracker for no master scenario. All failed tests pass in local machine. Please retrigger the test, thx.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12628954/HBASE-10483-trunk-v1.diff
          against trunk revision .
          ATTACHMENT ID: 12628954

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.master.TestMasterFailover
          org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
          org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster

          -1 core zombie tests. There are 2 zombie test(s): at org.apache.hadoop.hbase.master.TestOpenedRegionHandler.testOpenedRegionHandlerOnMasterRestart(TestOpenedRegionHandler.java:104)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12628954/HBASE-10483-trunk-v1.diff against trunk revision . ATTACHMENT ID: 12628954 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 9 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestMasterFailover org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster -1 core zombie tests . There are 2 zombie test(s): at org.apache.hadoop.hbase.master.TestOpenedRegionHandler.testOpenedRegionHandlerOnMasterRestart(TestOpenedRegionHandler.java:104) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8696//console This message is automatically generated.
          Hide
          Liu Shaohui added a comment -

          Patch for trunk.
          Test in standalone mode with 2 masters

          Show
          Liu Shaohui added a comment - Patch for trunk. Test in standalone mode with 2 masters
          Hide
          stack added a comment -

          Doing it the way Liu Shaohui suggests would have master info port align w/ how info port is done for regionserver HBASE-9892 – makes sense.

          Show
          stack added a comment - Doing it the way Liu Shaohui suggests would have master info port align w/ how info port is done for regionserver HBASE-9892 – makes sense.
          Hide
          Liu Shaohui added a comment -

          This feature is needed in some scenarios, where we can't pre-define hbase.master.info.port, eg. hbase on yarn.
          Maybe we can write master info.port to master zk node when master get master lock. Then HBaseAdmin can get this master info port from master zk node.

          Show
          Liu Shaohui added a comment - This feature is needed in some scenarios, where we can't pre-define hbase.master.info.port, eg. hbase on yarn. Maybe we can write master info.port to master zk node when master get master lock. Then HBaseAdmin can get this master info port from master zk node.

            People

            • Assignee:
              Liu Shaohui
              Reporter:
              Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development