HBase
  1. HBase
  2. HBASE-10377

Add test for HBASE-10370 Compaction in out-of-date Store causes region split failure

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBASE-10370 fixes the issue where region split fails following compacting out-of-date Store

      The new test failed in this build:

      https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/82/testReport/org.apache.hadoop.hbase.regionserver/TestSplitTransactionOnCluster/testSplitFailedCompactionAndSplit/

      This issue is to make the new test, testSplitFailedCompactionAndSplit, robust.

        Activity

        Ted Yu created issue -
        Hide
        Ted Yu added a comment -

        Test output from Jenkins.

        Show
        Ted Yu added a comment - Test output from Jenkins.
        Ted Yu made changes -
        Field Original Value New Value
        Attachment 10377-testSplitFailedCompactionAndSplit.html [ 12623749 ]
        Hide
        Liu Shaohui added a comment -

        Run the test for several times in local machine and they all pass.

        Someone help to re-trigger the ci tests.

        The reason why test failed in HBASE-10370 is that RS had run a major compaction , so when test request a compaction manually, it return null, which made the test failed.

        Show
        Liu Shaohui added a comment - Run the test for several times in local machine and they all pass. Someone help to re-trigger the ci tests. The reason why test failed in HBASE-10370 is that RS had run a major compaction , so when test request a compaction manually, it return null, which made the test failed.
        Liu Shaohui made changes -
        Attachment HBASE-10377-v1.patch [ 12623939 ]
        Liang Xie made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Liu Shaohui [ liushaohui ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623939/HBASE-10377-v1.patch
        against trunk revision .
        ATTACHMENT ID: 12623939

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623939/HBASE-10377-v1.patch against trunk revision . ATTACHMENT ID: 12623939 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8473//console This message is automatically generated.
        Hide
        stack added a comment -

        +1 from me. Nice looking test.

        Show
        stack added a comment - +1 from me. Nice looking test.
        Hide
        stack added a comment -

        Committed to trunk. Thank you for the nice test Liu Shaohui

        Show
        stack added a comment - Committed to trunk. Thank you for the nice test Liu Shaohui
        stack made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.99.0 [ 12325675 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4838 (See https://builds.apache.org/job/HBase-TRUNK/4838/)
        HBASE-10377 Add test for HBASE-10370 Compaction in out-of-date Store causes region split failure (stack: rev 1559838)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4838 (See https://builds.apache.org/job/HBase-TRUNK/4838/ ) HBASE-10377 Add test for HBASE-10370 Compaction in out-of-date Store causes region split failure (stack: rev 1559838) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #60 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/60/)
        HBASE-10377 Add test for HBASE-10370 Compaction in out-of-date Store causes region split failure (stack: rev 1559838)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #60 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/60/ ) HBASE-10377 Add test for HBASE-10370 Compaction in out-of-date Store causes region split failure (stack: rev 1559838) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Enis Soztutar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        2d 14h 33m 1 Liang Xie 20/Jan/14 13:48
        Patch Available Patch Available Resolved Resolved
        8h 9m 1 stack 20/Jan/14 21:58
        Resolved Resolved Closed Closed
        397d 1h 37m 1 Enis Soztutar 21/Feb/15 23:35

          People

          • Assignee:
            Liu Shaohui
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development