Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, hbase-10070
    • Component/s: hbck
    • Labels:
      None

      Description

      We should support region replicas in HBCK. The changes are probably not that intrusive.

      1. 10362-1.txt
        4 kB
        Devaraj Das
      2. 10362-2.txt
        4 kB
        Devaraj Das
      3. 10362-3.txt
        4 kB
        Devaraj Das
      4. 0011-HBASE-10362.-HBCK-changes-for-supporting-region-repl.patch
        4 kB
        Enis Soztutar

        Activity

        Hide
        Enis Soztutar added a comment -

        I think the patch needs an update with the latest branch changes.

        Show
        Enis Soztutar added a comment - I think the patch needs an update with the latest branch changes.
        Hide
        Devaraj Das added a comment -

        Updated patch with the API change taken into consideration.

        Show
        Devaraj Das added a comment - Updated patch with the API change taken into consideration.
        Hide
        Enis Soztutar added a comment -

        Makes sense to skip checks for region replicas. Why do we set skipCheck in addServer() versus the constructor?

        Show
        Enis Soztutar added a comment - Makes sense to skip checks for region replicas. Why do we set skipCheck in addServer() versus the constructor?
        Hide
        Devaraj Das added a comment -

        I moved the skipCheck in the place where the HbckInfo are constructed.

        Show
        Devaraj Das added a comment - I moved the skipCheck in the place where the HbckInfo are constructed.
        Hide
        Enis Soztutar added a comment -

        +1

        Show
        Enis Soztutar added a comment - +1
        Hide
        Devaraj Das added a comment -

        Could I get another reviewer on this please.

        Show
        Devaraj Das added a comment - Could I get another reviewer on this please.
        Hide
        Nick Dimiduk added a comment -

        Changes look simple enough, +1 for that, but...

        The test simply ensure that a table with replicas does not confuse hbck. Is there a test to verify fixes are applied correctly? Maybe parameterize the test to have it run all methods with both 1 replica and 2? I guess we'll add new behaviors related to replicas as we discover real broken scenarios?

        What do you think, Jonathan Hsieh?

        Show
        Nick Dimiduk added a comment - Changes look simple enough, +1 for that, but... The test simply ensure that a table with replicas does not confuse hbck. Is there a test to verify fixes are applied correctly? Maybe parameterize the test to have it run all methods with both 1 replica and 2? I guess we'll add new behaviors related to replicas as we discover real broken scenarios? What do you think, Jonathan Hsieh ?
        Hide
        Devaraj Das added a comment -

        Nick Dimiduk, for the first pass, yes, the idea is to make sure hbck doesn't get confused with the replica stuff. The test creates a table with multiple replicas and makes sure hbck doesn't fail. That's pretty much the initial goal. Later on, when the replica feature is more complete, and for example, it is made aware of splits and merges, at that point, we'll see if we need more work in the hbck side.

        Show
        Devaraj Das added a comment - Nick Dimiduk , for the first pass, yes, the idea is to make sure hbck doesn't get confused with the replica stuff. The test creates a table with multiple replicas and makes sure hbck doesn't fail. That's pretty much the initial goal. Later on, when the replica feature is more complete, and for example, it is made aware of splits and merges, at that point, we'll see if we need more work in the hbck side.
        Hide
        Nick Dimiduk added a comment -

        Makes sense. Simple patch, my +1 stands.

        Show
        Nick Dimiduk added a comment - Makes sense. Simple patch, my +1 stands.
        Hide
        Nick Dimiduk added a comment -

        This is tagged for trunk, not HBASE-10070 branch. Is that intentional?

        Show
        Nick Dimiduk added a comment - This is tagged for trunk, not HBASE-10070 branch. Is that intentional?
        Hide
        Devaraj Das added a comment -

        Thanks, guys for the review. Committed to hbase-10070 (and updated the fix version too, Nick Dimiduk).

        Show
        Devaraj Das added a comment - Thanks, guys for the review. Committed to hbase-10070 (and updated the fix version too, Nick Dimiduk ).
        Hide
        Jonathan Hsieh added a comment -

        It would be good to have additions to make sure the replicas are up in the correct nodes and to verify the correctness of those assignments as well. Is there a follow on jira for that?

        Show
        Jonathan Hsieh added a comment - It would be good to have additions to make sure the replicas are up in the correct nodes and to verify the correctness of those assignments as well. Is there a follow on jira for that?
        Hide
        Devaraj Das added a comment -

        Jonathan Hsieh, makes sense to make that an option in hbck. Will create a jira for that.

        Show
        Devaraj Das added a comment - Jonathan Hsieh , makes sense to make that an option in hbck. Will create a jira for that.
        Hide
        Enis Soztutar added a comment -

        Attaching rebased patch for master that is committed

        Show
        Enis Soztutar added a comment - Attaching rebased patch for master that is committed
        Hide
        Enis Soztutar added a comment -

        Committed to master as part of hbase-10070 branch merge

        Show
        Enis Soztutar added a comment - Committed to master as part of hbase-10070 branch merge
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5245 (See https://builds.apache.org/job/HBase-TRUNK/5245/)
        HBASE-10362. HBCK changes for supporting region replicas (enis: rev 87b2b923e229e335b7e81b79656b5259b5a0d1b1)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5245 (See https://builds.apache.org/job/HBase-TRUNK/5245/ ) HBASE-10362 . HBCK changes for supporting region replicas (enis: rev 87b2b923e229e335b7e81b79656b5259b5a0d1b1) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Devaraj Das
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development