Details

    • Hadoop Flags:
      Reviewed

      Description

      Region replicas should be opened in read-only mode, and the "replica" mode so that they serve queries from the primary regions' files.

      This jira will also capture periodic refreshing of the store files from the secondary regions so that they can get flushed and compacted files according to the "region snapshots" section in the design doc for the parent jira.

      1. 0010-HBASE-10352-Region-and-RegionServer-changes-for-open.patch
        80 kB
        Enis Soztutar
      2. hbase-10352_v3.patch
        72 kB
        Enis Soztutar
      3. hbase-10352_v2.patch
        70 kB
        Enis Soztutar

        Issue Links

          Activity

          Enis Soztutar made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5245 (See https://builds.apache.org/job/HBase-TRUNK/5245/)
          HBASE-10352 Region and RegionServer changes for opening region replicas, and refreshing store files (enis: rev d7d9f8db622049ccff411c7fe2792404b81fa331)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConsistencyControl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
          • hbase-common/src/main/resources/hbase-default.xml
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StorefileRefresherChore.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5245 (See https://builds.apache.org/job/HBase-TRUNK/5245/ ) HBASE-10352 Region and RegionServer changes for opening region replicas, and refreshing store files (enis: rev d7d9f8db622049ccff411c7fe2792404b81fa331) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerRegionReplicaUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConsistencyControl.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java hbase-common/src/main/resources/hbase-default.xml hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StorefileRefresherChore.java
          Enis Soztutar made changes -
          Fix Version/s 0.99.0 [ 12325675 ]
          Hide
          Enis Soztutar added a comment -

          Committed to master as part of hbase-10070 branch merge

          Show
          Enis Soztutar added a comment - Committed to master as part of hbase-10070 branch merge
          Hide
          Enis Soztutar added a comment -

          Attaching rebased patch for master that is committed

          Show
          Enis Soztutar added a comment - Attaching rebased patch for master that is committed
          Enis Soztutar made changes -
          Enis Soztutar made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s hbase-10070 [ 12326176 ]
          Fix Version/s 0.99.0 [ 12325675 ]
          Resolution Fixed [ 1 ]
          Hide
          Enis Soztutar added a comment -

          Thanks for reviews! I've committed this to the hbase-10070 branch.

          Show
          Enis Soztutar added a comment - Thanks for reviews! I've committed this to the hbase-10070 branch.
          Hide
          stack added a comment -

          Done. LGTM. Minor comment up on rb but looks great.

          Show
          stack added a comment - Done. LGTM. Minor comment up on rb but looks great.
          Hide
          Enis Soztutar added a comment -

          Ping, ping. Stack, do you have any other comments? I would like to get this in the branch as well.

          Show
          Enis Soztutar added a comment - Ping, ping. Stack , do you have any other comments? I would like to get this in the branch as well.
          Enis Soztutar made changes -
          Attachment hbase-10352_v3.patch [ 12629172 ]
          Hide
          Enis Soztutar added a comment -

          Patch from RB.

          Show
          Enis Soztutar added a comment - Patch from RB.
          Hide
          Devaraj Das added a comment -

          LGTM overall. One nit is that, given the considerations in HBASE-10347 about names, should we make this patch adhere to that - "primary" to "default" and "secondary" to "replica"...

          Show
          Devaraj Das added a comment - LGTM overall. One nit is that, given the considerations in HBASE-10347 about names, should we make this patch adhere to that - "primary" to "default" and "secondary" to "replica"...
          Enis Soztutar made changes -
          Attachment hbase-10352_v2.patch [ 12627763 ]
          Hide
          Enis Soztutar added a comment -

          Attaching patch from RB.

          Show
          Enis Soztutar added a comment - Attaching patch from RB.
          Hide
          Enis Soztutar added a comment -

          Attaching a patch for review. It applies to the branch hbase-10070.

          Running the unit tests manually, since hadoopqa won't work over the branch.

          Show
          Enis Soztutar added a comment - Attaching a patch for review. It applies to the branch hbase-10070. Running the unit tests manually, since hadoopqa won't work over the branch.
          Enis Soztutar made changes -
          Remote Link This issue links to "https://reviews.apache.org/r/17853/ (Web Link)" [ 14107 ]
          Enis Soztutar made changes -
          Field Original Value New Value
          Component/s Region Assignment [ 12319661 ]
          Component/s regionserver [ 12312139 ]
          Enis Soztutar created issue -

            People

            • Assignee:
              Enis Soztutar
              Reporter:
              Enis Soztutar
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development