Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, hbase-10070
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As per design in the parent jira, this jira will capture the changes in the master side (especially AM / RegionStates) for creating tables with region replicas, and making sure the regions are assigned on create and failover.

      1. 10350-1.txt
        67 kB
        Devaraj Das
      2. 10350-3.txt
        61 kB
        Devaraj Das
      3. 10350-4-5.txt
        47 kB
        Devaraj Das
      4. 10350-4-6.txt
        48 kB
        Devaraj Das
      5. 0007-HBASE-10350.-Master-AM-RegionStates-changes-to-creat.patch
        94 kB
        Enis Soztutar

        Activity

        Enis Soztutar created issue -
        Enis Soztutar made changes -
        Field Original Value New Value
        Assignee Devaraj Das [ devaraj ]
        Hide
        Devaraj Das added a comment -

        Patch on top of HBASE-10347 and HBASE-10348.

        Show
        Devaraj Das added a comment - Patch on top of HBASE-10347 and HBASE-10348 .
        Devaraj Das made changes -
        Attachment 10350-1.txt [ 12627277 ]
        Devaraj Das made changes -
        Attachment 10350-1.txt [ 12627277 ]
        Devaraj Das made changes -
        Rank Ranked lower
        Hide
        Devaraj Das added a comment -

        This is the right patch.

        Show
        Devaraj Das added a comment - This is the right patch.
        Devaraj Das made changes -
        Attachment 10350-1.txt [ 12627278 ]
        Hide
        Enis Soztutar added a comment -

        Can you also put an RB. Thanks.

        Show
        Enis Soztutar added a comment - Can you also put an RB. Thanks.
        Hide
        Devaraj Das added a comment -

        https://reviews.apache.org/r/17865/ (had forgotten to paste the link here earlier).

        Show
        Devaraj Das added a comment - https://reviews.apache.org/r/17865/ (had forgotten to paste the link here earlier).
        Hide
        Devaraj Das added a comment -

        RB seems to be not working currently. Attaching the revised patch here. I removed the changes to do with BaseLoadBalancer, but I didn't remove the test cases. I commented them out with TODO saying when they should be uncommented.

        Show
        Devaraj Das added a comment - RB seems to be not working currently. Attaching the revised patch here. I removed the changes to do with BaseLoadBalancer, but I didn't remove the test cases. I commented them out with TODO saying when they should be uncommented.
        Devaraj Das made changes -
        Attachment 10350-3.txt [ 12628139 ]
        Hide
        Devaraj Das added a comment -

        Patch with some minor changes (over what's there on RB).

        Show
        Devaraj Das added a comment - Patch with some minor changes (over what's there on RB).
        Devaraj Das made changes -
        Attachment 10350-4-5.txt [ 12628938 ]
        Hide
        Devaraj Das added a comment -

        Could I get one more reviewer to look at this before I commit to the branch...

        Show
        Devaraj Das added a comment - Could I get one more reviewer to look at this before I commit to the branch...
        Hide
        Enis Soztutar added a comment -

        Forwarding my +1 from RB.

        Show
        Enis Soztutar added a comment - Forwarding my +1 from RB.
        Hide
        Jimmy Xiang added a comment -

        Looks good to me. +1.

        Show
        Jimmy Xiang added a comment - Looks good to me. +1.
        Hide
        Devaraj Das added a comment -

        Thanks for the reviews, Enis and Jimmy. This is the patch I am going to commit in the branch (there was one minor conflict).

        Show
        Devaraj Das added a comment - Thanks for the reviews, Enis and Jimmy. This is the patch I am going to commit in the branch (there was one minor conflict).
        Devaraj Das made changes -
        Attachment 10350-4-6.txt [ 12629823 ]
        Devaraj Das made changes -
        Fix Version/s hbase-10070 [ 12326176 ]
        Hide
        Devaraj Das added a comment -

        Committed to branch hbase-10070.

        Show
        Devaraj Das added a comment - Committed to branch hbase-10070.
        Enis Soztutar made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Enis Soztutar made changes -
        Fix Version/s 0.99.0 [ 12325675 ]
        Hide
        stack added a comment -

        RegionReplicaUtil.java is in client package but is used by master and by catalog. Hoist it up to package above?

        Show
        stack added a comment - RegionReplicaUtil.java is in client package but is used by master and by catalog. Hoist it up to package above?
        Enis Soztutar made changes -
        Hide
        Enis Soztutar added a comment -

        Attaching rebased patch for master that is committed

        Show
        Enis Soztutar added a comment - Attaching rebased patch for master that is committed
        Hide
        Enis Soztutar added a comment -

        Committed to master as part of hbase-10070 branch merge

        Show
        Enis Soztutar added a comment - Committed to master as part of hbase-10070 branch merge
        Enis Soztutar made changes -
        Fix Version/s 0.99.0 [ 12325675 ]
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5245 (See https://builds.apache.org/job/HBase-TRUNK/5245/)
        HBASE-10350. Master/AM/RegionStates changes to create and assign region replicas (ddas) (enis: rev 3d8ee3a06e26d8535a0a3bac363739d77b11b060)

        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RackManager.java
        • hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionReplicaUtil.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ModifyRegionUtils.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/SnapshotOfRegionAssignmentFromMeta.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5245 (See https://builds.apache.org/job/HBase-TRUNK/5245/ ) HBASE-10350 . Master/AM/RegionStates changes to create and assign region replicas (ddas) (enis: rev 3d8ee3a06e26d8535a0a3bac363739d77b11b060) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java hbase-server/src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RackManager.java hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionReplicaUtil.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ModifyRegionUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/SnapshotOfRegionAssignmentFromMeta.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Enis Soztutar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        35d 1h 12m 1 Enis Soztutar 20/Feb/14 00:03
        Resolved Resolved Closed Closed
        366d 23h 25m 1 Enis Soztutar 21/Feb/15 23:29

          People

          • Assignee:
            Devaraj Das
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development