HBase
  1. HBase
  2. HBASE-10339

Mutation::getFamilyMap method was lost in 98

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.99.0
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: None
    • Labels:
      None

      Description

      When backward compat work was done in several jiras, this method was missed. First the return type was changed, then the method was rename to not break the callers via new return type, but the legacy method was never re-added as far as I see

      1. HBASE-10339.patch
        1 kB
        Sergey Shelukhin

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #54 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/54/)
        HBASE-10339 Mutation::getFamilyMap method was lost in 98 (sershe: rev 1558267)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #54 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/54/ ) HBASE-10339 Mutation::getFamilyMap method was lost in 98 (sershe: rev 1558267) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #82 (See https://builds.apache.org/job/HBase-0.98/82/)
        HBASE-10339 Mutation::getFamilyMap method was lost in 98 (sershe: rev 1558268)

        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #82 (See https://builds.apache.org/job/HBase-0.98/82/ ) HBASE-10339 Mutation::getFamilyMap method was lost in 98 (sershe: rev 1558268) /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #75 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/75/)
        HBASE-10339 Mutation::getFamilyMap method was lost in 98 (sershe: rev 1558268)

        • /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #75 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/75/ ) HBASE-10339 Mutation::getFamilyMap method was lost in 98 (sershe: rev 1558268) /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4820 (See https://builds.apache.org/job/HBase-TRUNK/4820/)
        HBASE-10339 Mutation::getFamilyMap method was lost in 98 (sershe: rev 1558267)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4820 (See https://builds.apache.org/job/HBase-TRUNK/4820/ ) HBASE-10339 Mutation::getFamilyMap method was lost in 98 (sershe: rev 1558267) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
        Hide
        Sergey Shelukhin added a comment -

        committed to 98 and trunk

        Show
        Sergey Shelukhin added a comment - committed to 98 and trunk
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Andrew Purtell added a comment -

        Ok, +1

        Show
        Andrew Purtell added a comment - Ok, +1
        Hide
        Sergey Shelukhin added a comment -

        It's needed for 0.94 backward compat in Hive (and potential other projects)... otherwise they would require a shim
        I think it should not be dropped before 94 is distant past...

        Show
        Sergey Shelukhin added a comment - It's needed for 0.94 backward compat in Hive (and potential other projects)... otherwise they would require a shim I think it should not be dropped before 94 is distant past...
        Hide
        stack added a comment -

        Sergey Shelukhin What Andrew Purtell says. You need it?

        Show
        stack added a comment - Sergey Shelukhin What Andrew Purtell says. You need it?
        Hide
        Andrew Purtell added a comment -

        The criteria for 0.98 is wire compatibility not binary (API) compatibility, and we've already broken that with the KV comparator changes IIRC. This patch only adds back a method tagged as deprecated, so it's harmless, but is it needed?

        Show
        Andrew Purtell added a comment - The criteria for 0.98 is wire compatibility not binary (API) compatibility, and we've already broken that with the KV comparator changes IIRC. This patch only adds back a method tagged as deprecated, so it's harmless, but is it needed?
        Hide
        Sergey Shelukhin added a comment -

        Hmm, 96 doesn't appear to be affected, let me double check

        Show
        Sergey Shelukhin added a comment - Hmm, 96 doesn't appear to be affected, let me double check
        Hide
        Sergey Shelukhin added a comment -

        stack Andrew Purtell do you mind taking a look? backward compat with 94 issue

        Show
        Sergey Shelukhin added a comment - stack Andrew Purtell do you mind taking a look? backward compat with 94 issue
        Hide
        Sergey Shelukhin added a comment -

        Simple patch, applies to all 3 branches

        Show
        Sergey Shelukhin added a comment - Simple patch, applies to all 3 branches

          People

          • Assignee:
            Sergey Shelukhin
            Reporter:
            Sergey Shelukhin
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development