Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HBASE-10297_V3.patch
      20 kB
      Anoop Sam John
    2. HBASE-10297_V2.patch
      20 kB
      Anoop Sam John
    3. HBASE-10297.patch
      20 kB
      Anoop Sam John

      Activity

      Hide
      Enis Soztutar added a comment -

      Closing this issue after 0.99.0 release.

      Show
      Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
      Hide
      Anoop Sam John added a comment -

      Ram offline told me that he is having a patch for fixing the user issue. Let us fix that in another issue and close this as this was closed long time back.

      Show
      Anoop Sam John added a comment - Ram offline told me that he is having a patch for fixing the user issue. Let us fix that in another issue and close this as this was closed long time back.
      Hide
      Andrew Purtell added a comment -

      Since you can't assume there's a user in a real test cluster named 'user1' we need to parameterize what user names to use. So, some kind of command line option. For the minicluster test, automatically set that CLI option to the name of the current user.

      Show
      Andrew Purtell added a comment - Since you can't assume there's a user in a real test cluster named 'user1' we need to parameterize what user names to use. So, some kind of command line option. For the minicluster test, automatically set that CLI option to the name of the current user.
      Hide
      ramkrishna.s.vasudevan added a comment -

      But the above permission problem happens only when run with minicluster Andy. Not when run in a real cluster. In real cluster the only thing we may need is have a user called 'user1'.
      So with mvn verify what should we do to get it running ?

      Show
      ramkrishna.s.vasudevan added a comment - But the above permission problem happens only when run with minicluster Andy. Not when run in a real cluster. In real cluster the only thing we may need is have a user called 'user1'. So with mvn verify what should we do to get it running ?
      Hide
      Andrew Purtell added a comment -

      I think this test also does not work with mvn verify

      mvn verify -Dit.test=IntegrationTestWithCellVisibilityLoadAndVerify -Dtest.output.tofile=false
      

      Confirmed. The test creates a user that is not real, 'user1' while the process is running as user 'apurtell'. There is an inevitable permission problem.

      [...]
      2014-07-10 13:30:36,504 ERROR [IPC Server handler 0 on 43020] security.UserGroupInformation(1494): PriviledgedActionException as:user1 (auth:SIMPLE) cause:org.apache.hadoop.security.AccessControlException: Permission denied: user=user1, access=WRITE, inode="/user":apurtell:supergroup:drwxr-xr-x
      [...]
      
      Results :
      
      Failed tests:   testLoadAndVerify(org.apache.hadoop.hbase.test.IntegrationTestWithCellVisibilityLoadAndVerify)
      
      Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
      

      Let's fix it. Reopening. Please close again after addendum commit or if opening a new JIRA to deal with the issue.

      Show
      Andrew Purtell added a comment - I think this test also does not work with mvn verify mvn verify -Dit.test=IntegrationTestWithCellVisibilityLoadAndVerify -Dtest.output.tofile=false Confirmed. The test creates a user that is not real, 'user1' while the process is running as user 'apurtell'. There is an inevitable permission problem. [...] 2014-07-10 13:30:36,504 ERROR [IPC Server handler 0 on 43020] security.UserGroupInformation(1494): PriviledgedActionException as:user1 (auth:SIMPLE) cause:org.apache.hadoop.security.AccessControlException: Permission denied: user=user1, access=WRITE, inode="/user":apurtell:supergroup:drwxr-xr-x [...] Results : Failed tests: testLoadAndVerify(org.apache.hadoop.hbase.test.IntegrationTestWithCellVisibilityLoadAndVerify) Tests run: 1, Failures: 1, Errors: 0, Skipped: 0 Let's fix it. Reopening. Please close again after addendum commit or if opening a new JIRA to deal with the issue.
      Hide
      ramkrishna.s.vasudevan added a comment -

      I think this test also does not work with mvn verify

       mvn verify -Dit.test=IntegrationTestWithCellVisibilityLoadAndVerify -Dtest.output.tofile=false
      
      Show
      ramkrishna.s.vasudevan added a comment - I think this test also does not work with mvn verify mvn verify -Dit.test=IntegrationTestWithCellVisibilityLoadAndVerify -Dtest.output.tofile= false
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #47 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/47/)
      HBASE-10297 LoadAndVerify Integration Test for cell visibility (anoopsamjohn: rev 1556770)

      • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java
      • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #47 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/47/ ) HBASE-10297 LoadAndVerify Integration Test for cell visibility (anoopsamjohn: rev 1556770) /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
      Hide
      Hudson added a comment -

      FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #59 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/59/)
      HBASE-10297 LoadAndVerify Integration Test for cell visibility (anoopsamjohn: rev 1556771)

      • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java
      • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
      Show
      Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #59 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/59/ ) HBASE-10297 LoadAndVerify Integration Test for cell visibility (anoopsamjohn: rev 1556771) /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-0.98 #65 (See https://builds.apache.org/job/HBase-0.98/65/)
      HBASE-10297 LoadAndVerify Integration Test for cell visibility (anoopsamjohn: rev 1556771)

      • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java
      • /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #65 (See https://builds.apache.org/job/HBase-0.98/65/ ) HBASE-10297 LoadAndVerify Integration Test for cell visibility (anoopsamjohn: rev 1556771) /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java /hbase/branches/0.98/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
      Hide
      Hudson added a comment -

      SUCCESS: Integrated in HBase-TRUNK #4801 (See https://builds.apache.org/job/HBase-TRUNK/4801/)
      HBASE-10297 LoadAndVerify Integration Test for cell visibility (anoopsamjohn: rev 1556770)

      • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java
      • /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
      Show
      Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4801 (See https://builds.apache.org/job/HBase-TRUNK/4801/ ) HBASE-10297 LoadAndVerify Integration Test for cell visibility (anoopsamjohn: rev 1556770) /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java /hbase/trunk/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
      Hide
      Anoop Sam John added a comment -

      Committed to 0.98 and Trunk. Thanks Ram, Andy for your reviews.

      Show
      Anoop Sam John added a comment - Committed to 0.98 and Trunk. Thanks Ram, Andy for your reviews.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12622116/HBASE-10297_V3.patch
      against trunk revision .
      ATTACHMENT ID: 12622116

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

      +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      -1 release audit. The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings).

      +1 lineLengths. The patch does not introduce lines longer than 100

      -1 site. The patch appears to cause mvn site goal to fail.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//testReport/
      Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622116/HBASE-10297_V3.patch against trunk revision . ATTACHMENT ID: 12622116 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8373//console This message is automatically generated.
      Hide
      Andrew Purtell added a comment -

      +1

      I don't think the test failures are related, but perhaps run HadoopQA one more time.

      The Javadoc for the test needs updating to describe what additional things this new integration test checks for. Can be done at commit time.

      Show
      Andrew Purtell added a comment - +1 I don't think the test failures are related, but perhaps run HadoopQA one more time. The Javadoc for the test needs updating to describe what additional things this new integration test checks for. Can be done at commit time.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12621935/HBASE-10297_V2.patch
      against trunk revision .
      ATTACHMENT ID: 12621935

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

      +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      -1 release audit. The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings).

      +1 lineLengths. The patch does not introduce lines longer than 100

      -1 site. The patch appears to cause mvn site goal to fail.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster
      org.apache.hadoop.hbase.TestIOFencing

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//testReport/
      Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621935/HBASE-10297_V2.patch against trunk revision . ATTACHMENT ID: 12621935 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster org.apache.hadoop.hbase.TestIOFencing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8362//console This message is automatically generated.
      Hide
      Anoop Sam John added a comment -
      Show
      Anoop Sam John added a comment - This fixes the line length >100 issues. https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt These not related to this patch.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12621921/HBASE-10297.patch
      against trunk revision .
      ATTACHMENT ID: 12621921

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

      +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      -1 release audit. The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings).

      -1 lineLengths. The patch introduces the following lines longer than 100:
      + for (long idxInBlock = 0; idxInBlock < BLOCK_SIZE && i < recordsToWrite; idxInBlock+, i+) {
      + .println(" -Dloadmapper.num_to_write=<n> Number of rows per mapper (default 100,000 per mapper)");
      + .println(" -Dloadmapper.numPresplits=<n> Number of presplit regions to start with (default 40)");
      + .println(" -Dverify.scannercaching=<n> Number hbase scanner caching rows to read (default 50)");

      -1 site. The patch appears to cause mvn site goal to fail.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//testReport/
      Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621921/HBASE-10297.patch against trunk revision . ATTACHMENT ID: 12621921 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings). -1 lineLengths . The patch introduces the following lines longer than 100: + for (long idxInBlock = 0; idxInBlock < BLOCK_SIZE && i < recordsToWrite; idxInBlock+ , i +) { + .println(" -Dloadmapper.num_to_write=<n> Number of rows per mapper (default 100,000 per mapper)"); + .println(" -Dloadmapper.numPresplits=<n> Number of presplit regions to start with (default 40)"); + .println(" -Dverify.scannercaching=<n> Number hbase scanner caching rows to read (default 50)"); -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8359//console This message is automatically generated.
      Hide
      ramkrishna.s.vasudevan added a comment -

      Already reviewed internally. +1

      Show
      ramkrishna.s.vasudevan added a comment - Already reviewed internally. +1
      Hide
      Anoop Sam John added a comment -
      Show
      Anoop Sam John added a comment - Ping Andrew Purtell , ramkrishna.s.vasudevan

        People

        • Assignee:
          Anoop Sam John
          Reporter:
          Anoop Sam John
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development