HBase
  1. HBase
  2. HBASE-10279

TestStore.testDeleteExpiredStoreFiles is flaky

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.16
    • Component/s: None
    • Labels:
      None

      Description

      TestStore.testDeleteExpiredStoreFiles relies on wall clock time, if there is a blip on the machine running the test, first compaction might be delayed enough in order to compact away multiple of the files, and have the test fail.

      The simplest fix is to just double the time given from 1s/file to 2s/file.

      1. 10279-0.94.txt
        2 kB
        Lars Hofhansl

        Activity

        Hide
        Lars Hofhansl added a comment -

        Or better, use the EnvironmentEdge correctly.

        Show
        Lars Hofhansl added a comment - Or better, use the EnvironmentEdge correctly.
        Hide
        Lars Hofhansl added a comment -

        Patch for 0.94. Uses EnvironmentEdge instead.
        The change to Store.java is not needed, but good to have.

        Show
        Lars Hofhansl added a comment - Patch for 0.94. Uses EnvironmentEdge instead. The change to Store.java is not needed, but good to have.
        Hide
        Lars Hofhansl added a comment -
        Show
        Lars Hofhansl added a comment - Andrew Purtell , FYI
        Hide
        Andrew Purtell added a comment -

        I assume you pinged me to pick this up for trunk Lars Hofhansl, so that's what I will do.

        Show
        Andrew Purtell added a comment - I assume you pinged me to pick this up for trunk Lars Hofhansl , so that's what I will do.
        Hide
        Andrew Purtell added a comment -

        Looks like trunk already has a change like the patch on this issue.

        Show
        Andrew Purtell added a comment - Looks like trunk already has a change like the patch on this issue.
        Hide
        Lars Hofhansl added a comment -

        Arghh. Should've looked there first.

        Show
        Lars Hofhansl added a comment - Arghh. Should've looked there first.
        Hide
        Lars Hofhansl added a comment -

        This was fixed a while back with HBASE-6832. IncrementingEnvironmentEdge is a bit different trunk.
        I'll commit by patch to 0.94. Thanks for looking Andrew Purtell

        Show
        Lars Hofhansl added a comment - This was fixed a while back with HBASE-6832 . IncrementingEnvironmentEdge is a bit different trunk. I'll commit by patch to 0.94. Thanks for looking Andrew Purtell
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.94 only (similar was added in 0.95, so all other branches have it)

        Show
        Lars Hofhansl added a comment - Committed to 0.94 only (similar was added in 0.95, so all other branches have it)
        Hide
        Hudson added a comment -

        ABORTED: Integrated in HBase-0.94-JDK7 #15 (See https://builds.apache.org/job/HBase-0.94-JDK7/15/)
        HBASE-10279 TestStore.testDeleteExpiredStoreFiles is flaky (larsh: rev 1555321)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
        Show
        Hudson added a comment - ABORTED: Integrated in HBase-0.94-JDK7 #15 (See https://builds.apache.org/job/HBase-0.94-JDK7/15/ ) HBASE-10279 TestStore.testDeleteExpiredStoreFiles is flaky (larsh: rev 1555321) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
        Hide
        Hudson added a comment -

        ABORTED: Integrated in HBase-0.94 #1250 (See https://builds.apache.org/job/HBase-0.94/1250/)
        HBASE-10279 TestStore.testDeleteExpiredStoreFiles is flaky (larsh: rev 1555321)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
        Show
        Hudson added a comment - ABORTED: Integrated in HBase-0.94 #1250 (See https://builds.apache.org/job/HBase-0.94/1250/ ) HBASE-10279 TestStore.testDeleteExpiredStoreFiles is flaky (larsh: rev 1555321) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-security #378 (See https://builds.apache.org/job/HBase-0.94-security/378/)
        HBASE-10279 TestStore.testDeleteExpiredStoreFiles is flaky (larsh: rev 1555321)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #378 (See https://builds.apache.org/job/HBase-0.94-security/378/ ) HBASE-10279 TestStore.testDeleteExpiredStoreFiles is flaky (larsh: rev 1555321) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java

          People

          • Assignee:
            Lars Hofhansl
            Reporter:
            Lars Hofhansl
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development