HBase
  1. HBase
  2. HBASE-10188

Deprecate ServerName constructors, but make it public.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.96.1
    • Fix Version/s: 0.96.2, 0.96.1.1
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It's in our public interface, we can't remove it that easily... See HBASE-10012?

      1. hbase-10188.v2.patch
        2 kB
        Jonathan Hsieh
      2. 10188.v1.patch
        2 kB
        Nicolas Liochon

        Issue Links

          Activity

          Hide
          Nicolas Liochon added a comment -

          patch for 0.96 only, but should build on trunk, so let's test it on trunk.

          Show
          Nicolas Liochon added a comment - patch for 0.96 only, but should build on trunk, so let's test it on trunk.
          Hide
          Jonathan Hsieh added a comment -

          nit:

          +  /**
          +   * @deprecated since 0.96, removed in 0.98 use {@link #valueOf(String, int, long)} instead.
          +   */
          

          Should be private in 0.98 instead of removed in 0.98 right?

          Otherwise, +1 lgtm.

          Show
          Jonathan Hsieh added a comment - nit: + /** + * @deprecated since 0.96, removed in 0.98 use {@link #valueOf( String , int , long )} instead. + */ Should be private in 0.98 instead of removed in 0.98 right? Otherwise, +1 lgtm.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619108/10188.v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619108/10188.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8203//console This message is automatically generated.
          Hide
          Jonathan Hsieh added a comment -

          I'm committing v2 to 0.96 branch and for 0.96.1.1

          Show
          Jonathan Hsieh added a comment - I'm committing v2 to 0.96 branch and for 0.96.1.1
          Hide
          Nicolas Liochon added a comment -

          Thanks Jon.

          Show
          Nicolas Liochon added a comment - Thanks Jon.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96 #231 (See https://builds.apache.org/job/hbase-0.96/231/)
          HBASE-10188 Deprecate ServerName constructors, but make it public (Nicolas Liochon) (jmhsieh: rev 1551661)

          • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #231 (See https://builds.apache.org/job/hbase-0.96/231/ ) HBASE-10188 Deprecate ServerName constructors, but make it public (Nicolas Liochon) (jmhsieh: rev 1551661) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.96-hadoop2 #153 (See https://builds.apache.org/job/hbase-0.96-hadoop2/153/)
          HBASE-10188 Deprecate ServerName constructors, but make it public (Nicolas Liochon) (jmhsieh: rev 1551661)

          • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #153 (See https://builds.apache.org/job/hbase-0.96-hadoop2/153/ ) HBASE-10188 Deprecate ServerName constructors, but make it public (Nicolas Liochon) (jmhsieh: rev 1551661) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
          Hide
          Sergey Shelukhin added a comment -

          This is not in 0.98?

          Show
          Sergey Shelukhin added a comment - This is not in 0.98?
          Hide
          Jonathan Hsieh added a comment -

          0.96 was the deprecation version, 0.98 made them private which is roughly equivalent of removing the methods. This was essentially a 0.96 only patch to preserve our api compat rule (deprecate in one major then remove in next) with 0.94.

          Show
          Jonathan Hsieh added a comment - 0.96 was the deprecation version, 0.98 made them private which is roughly equivalent of removing the methods. This was essentially a 0.96 only patch to preserve our api compat rule (deprecate in one major then remove in next) with 0.94.
          Hide
          Sergey Shelukhin added a comment -

          I have no use case for this patch now, but I wonder as we get to higher cadence if the rule should be changed... people are just starting to upgrade from 94 and we already remove APIs.
          Any change raises the ghosts of HBase shim in Hive, Pig, etc... Like Hadoop shim everyone is force to use.
          I wonder if we should only remove when the requisite major release (in this case 94) is reasonably dead and support is dropped from places.

          Show
          Sergey Shelukhin added a comment - I have no use case for this patch now, but I wonder as we get to higher cadence if the rule should be changed... people are just starting to upgrade from 94 and we already remove APIs. Any change raises the ghosts of HBase shim in Hive, Pig, etc... Like Hadoop shim everyone is force to use. I wonder if we should only remove when the requisite major release (in this case 94) is reasonably dead and support is dropped from places.
          Hide
          Jonathan Hsieh added a comment -

          What are you suggesting? adding the api back to 0.98 as well? There are multiple other api removals in 0.98 already but we've decided to keep the wire api compatible with 0.96. This is similar to what happened in 0.92->0.94 – api changes but wire compat.

          Show
          Jonathan Hsieh added a comment - What are you suggesting? adding the api back to 0.98 as well? There are multiple other api removals in 0.98 already but we've decided to keep the wire api compatible with 0.96. This is similar to what happened in 0.92->0.94 – api changes but wire compat.
          Hide
          Sergey Shelukhin added a comment -

          We may luck out and this API would not be used by other projects.

          Show
          Sergey Shelukhin added a comment - We may luck out and this API would not be used by other projects.

            People

            • Assignee:
              Nicolas Liochon
              Reporter:
              Nicolas Liochon
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development